Big[U]Int64Array.at returns bigint, not number #46733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigint is needed to represent all 64-bit ints that these arrays could contain.
typescript-bot
added
Author: Team
For Uncommitted Bug
weswigham
approved these changes
Nov 8, 2021
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
types are in fact just wrong, function returns a bigint at runtime.
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
bigint is needed to represent all 64-bit ints that these arrays could contain.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bigint is needed to represent all 64-bit ints that these arrays could contain.
Breaks jsdom and jsreport-core on DT, and any package that depends on es2022 and
@types/node