Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing file name in generated diagnostics file #46821

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

blaumeise20
Copy link
Contributor

This fixes a confusing generated message.

diagnosticInformationMap.generated.ts line 2:

// generated from './diagnosticInformationMap.generated.ts' by 'src/compiler'
->
// generated from './diagnosticMessages.json' by 'src/compiler'

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 16, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Nov 17, 2021

Probably should say "in"

- // generated from './diagnosticMessages.json' by 'src/compiler'
+ // generated from './diagnosticMessages.json' in 'src/compiler'

@sandersn sandersn added the Housekeeping Housekeeping PRs label Jan 28, 2022
@sandersn sandersn merged commit 0b9f8b4 into microsoft:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug Housekeeping Housekeeping PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants