Import chalk with import() syntax #46931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
This makes code compatible with chalk v5.0.0.
Contributor
|
Confirmed this works locally also - thanks @uhyo! |
Merged
Contributor
|
Do we want to depend on |
rbuckton
added a commit
that referenced
this pull request
Dec 2, 2021
* Pin chalk to ^4.1 * Revert #46931
andrewbranch
pushed a commit
to andrewbranch/TypeScript
that referenced
this pull request
Dec 3, 2021
* Pin chalk to ^4.1 * Revert microsoft#46931
andrewbranch
added a commit
that referenced
this pull request
Dec 3, 2021
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
This makes code compatible with chalk v5.0.0.
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Pin chalk to ^4.1 * Revert microsoft#46931
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46930
chalk v5.0.0 was released and we cannot build TypeScript now if we have run
npm installafter the release. 😢This PR changes the script so that it works with chalk v5.0.0. Fortunately, the new code is compatible with both chalk 4.x and 5.0.