Use features for selected module resolution rather than all features … #47007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for type reference directives, since they can add restrictions to resolutions
typescript-bot
added
Author: Team
For Milestone Bug
RyanCavanaugh
approved these changes
Dec 3, 2021
DanielRosenwasser
approved these changes
Dec 3, 2021
|
@typescript-bot cherry-pick this to release-4.5 |
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
|
Hey @andrewbranch, I've opened #47016 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Dec 3, 2021
Component commits: 48b9027 Use features for selected module resolution rather than all features for type reference directives, since they can add restrictions to resolutions
DanielRosenwasser
pushed a commit
that referenced
this pull request
Dec 7, 2021
…e-4.5 (#47016) * Cherry-pick PR #47007 into release-4.5 Component commits: 48b9027 Use features for selected module resolution rather than all features for type reference directives, since they can add restrictions to resolutions * Update baselines for error in stable release versions Co-authored-by: Wesley Wigham <t-weswig@microsoft.com> Co-authored-by: Andrew Branch <andrew@wheream.io>
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
…for type reference directives, since they can add restrictions to resolutions (microsoft#47007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for type reference directives, since they can add restrictions to resolutions (eg,
exportsthat don't contain atypesresolution and no adjacent declaration files to the js ones blocking use of a top-leveltypesfield). This should prevent the new module resolution features from affecting people who don't opt-in to them via the new module modes (though I'm pleased with how quickly it seems some of the affected packages reacted to add atypesentry to their exports!).Fixes #46860
cc @DanielRosenwasser because I imagine you'll want to backport this to 4.5