Refactor named imports to default instead of namespace when esModuleInterop is on and module is an export=
#47744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a module declares an
export =
, we let you import the resolved export’s members with named imports, but this is generally asking for a bad time. If you haveesModuleInterop
enabled, the best thing to do with anexport =
is to default-import it. However, the refactor we offer is to convert the named imports to a namespace (import *
) import. That’s definitely the most correct translation from named imports, but if you were already doing something super sketchy by using named imports, we can nudge you in the direction of doing something better by replacing them with a default import instead a namespace import.Closes #46047