Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary check in getNarrowableTypeForReference #47953

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Remove unnecessary check in getNarrowableTypeForReference #47953

merged 2 commits into from
Feb 18, 2022

Conversation

ahejlsberg
Copy link
Member

Fixes #47890.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Feb 18, 2022
@ahejlsberg
Copy link
Member Author

@RyanCavanaugh @DanielRosenwasser We'll want to cherry pick this one.

@RyanCavanaugh
Copy link
Member

@typescript-bot cherry-pick this to release-4.6

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 18, 2022 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into release-4.6 on this PR at f4dcf88. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Feb 18, 2022
Merged
@typescript-bot
Copy link
Collaborator

Hey @RyanCavanaugh, I've opened #47957 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Feb 18, 2022
@ahejlsberg @typescript-bot
Cherry-pick PR microsoft#47953 into release-4.6
cf97370 
Component commits:
aa1c25d Remove unnecessary check in getNarrowableTypeForReference

f4dcf88 Add regression test
@ahejlsberg ahejlsberg merged commit db226a8 into main Feb 18, 2022
@ahejlsberg ahejlsberg deleted the fix47890 branch February 18, 2022 19:03
DanielRosenwasser pushed a commit that referenced this pull request Feb 19, 2022
@ahejlsberg
Cherry-pick PR #47953 into release-4.6 (#47957)
ded20c6 
Component commits:
aa1c25d Remove unnecessary check in getNarrowableTypeForReference

f4dcf88 Add regression test

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
@RyanCavanaugh RyanCavanaugh mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts4.6.1-rc regression: Property ... does not exist on type 'Partial<MyStorage>[K]'
3 participants
@ahejlsberg @RyanCavanaugh @typescript-bot