Error when accessing this before super #4814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // (()=>this); // No Error | ||
| // super(); | ||
| // } | ||
| if ((<ConstructorDeclaration>container).hasSeenSuperBeforeThis === undefined) { |
There was a problem hiding this comment.
Would it be better to make this a value on NodeCheckFlags, rather than a property on ConstructorDeclaration?
There was a problem hiding this comment.
+1 to this. in general storing anything on nodes in the checker is not a good practice
added 5 commits
October 6, 2015 19:46
Conflicts: src/compiler/checker.ts src/compiler/diagnosticInformationMap.generated.ts src/compiler/types.ts
| @@ -6577,6 +6577,21 @@ namespace ts { | |||
| let container = getThisContainer(node, /* includeArrowFunctions */ true); | |||
| let needToCaptureLexicalThis = false; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Should we special case this before super, or should we consider a more general purpose approach to TDZ that encompasses both this before super and use before declaration for let and const? I imagine there may be more cases like this in the future.
There was a problem hiding this comment.
I agree with you though I think that will need to be a separate change. Here is a issue #5232
|
Close this PR in flavor of #5833. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #4211