Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(48291): TS1193 in JS File #48304

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #48291

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Mar 17, 2022
@RyanCavanaugh RyanCavanaugh merged commit c1cf901 into microsoft:main Mar 17, 2022
@RyanCavanaugh
Copy link
Member

Thanks as always @a-tarasyuk !

@Bartel-C8
Copy link

Will this be merged in 4.6.x branch as well? For me in 4.6.4 this is still broken?

@Bartel-C8
Copy link

@a-tarasyuk , just pinging you to get a notification, as I suspect you won't get an notificaiton automatically. Thanks!

@RyanCavanaugh
Copy link
Member

We generally only backport critical fixes, which this isn't. 4.7 will be the first release containing this fix

@Bartel-C8
Copy link

@RyanCavanaugh : I understand the general concern.

But in my specific case I am bound to 4.5.x then.
As my TS error resides in a module dependency, I have no control to update is (and actually it's just a TS bug, so nothing to be fixed upstream).
And upstepping to 4.7.x would mean upstepping my whole Webpack build (Electron) process, which involves updating ts-loader, which needs an updated webpack version (4 to 5), which is unfortunately not possible due to other issues...

Thank you anyway.
Kind regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS1193 in JS File
5 participants