Fixed multiple prologue directives with parameter properties #48687
Conversation
typescript-bot
added
the
For Milestone Bug
| @@ -35405,7 +35405,7 @@ namespace ts { | |||
| superCallStatement = statement; | |||
| break; | |||
| } | |||
| if (!isPrologueDirective(statement) && nodeImmediatelyReferencesSuperOrThis(statement)) { | |||
| if (nodeImmediatelyReferencesSuperOrThis(statement)) { | |||
There was a problem hiding this comment.
This change isn't necessary for the PR; I just had only noticed the check is unnecessary after #29374 was merged 😄
| const indexAfterLastPrologueStatement = factory.copyPrologue(body.statements, statements, /*ensureUseStrict*/ false, visitor); | ||
| const superStatementIndex = findSuperStatementIndex(body.statements, indexAfterLastPrologueStatement); | ||
| const prologueStatementCount = factory.copyPrologue(body.statements, statements, /*ensureUseStrict*/ false, visitor); | ||
| const superStatementIndex = findSuperStatementIndex(body.statements, prologueStatementCount); |
There was a problem hiding this comment.
I'm nitpicking the variable name here. Both variable names are correct; prologueStatementCount just makes more sense to me -- especially in the context of the new array spread below.
|
Thanks for fixing this! |
JoshuaKGoldberg
deleted the
fix-parameter-properties-and-prologue-directives
branch
|
@typescript-bot cherry-pick this to release-4.6 |
|
Heya @jakebailey, I've started to run the task to cherry-pick this into |
|
Hey @jakebailey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.6 manually. |
|
Sent #48782 manually. This PR is needed for the other PRs thanks to this PR affecting the base |
Two issues:
super()Fixes #48671