Skip to content

[Experiment] feat(40793): Enable constants as computed values for string enums #49809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[Experiment] feat(40793): Enable constants as computed values for string enums #49809

wants to merge 0 commits into from

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #40793

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 6, 2022
@a-tarasyuk a-tarasyuk marked this pull request as ready for review July 7, 2022 16:22
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #40793. If you can get it accepted, this PR will have a better chance of being reviewed.

@DanielRosenwasser
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 14, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 76fe6a3. You can monitor the build here.

Update: The results are in!

@RyanCavanaugh
Copy link
Member

Another test I'd like to see (might think of more) is whether TDZ violations are caught

enum A {
  B = C
}
const C = "hello";

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..49809
Metric main 49809 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 360,139k (± 0.01%) 360,101k (± 0.02%) -38k (- 0.01%) 359,990k 360,250k
Parse Time 2.10s (± 0.77%) 2.10s (± 0.54%) +0.00s (+ 0.05%) 2.07s 2.12s
Bind Time 0.89s (± 0.75%) 0.90s (± 0.85%) +0.00s (+ 0.34%) 0.88s 0.92s
Check Time 5.99s (± 0.61%) 6.00s (± 0.76%) +0.01s (+ 0.13%) 5.94s 6.15s
Emit Time 6.15s (± 0.39%) 6.16s (± 0.64%) +0.01s (+ 0.10%) 6.07s 6.24s
Total Time 15.14s (± 0.46%) 15.16s (± 0.53%) +0.02s (+ 0.13%) 15.05s 15.39s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,693k (± 0.01%) 206,687k (± 0.04%) -5k (- 0.00%) 206,571k 206,931k
Parse Time 0.83s (± 1.11%) 0.83s (± 0.88%) -0.00s (- 0.48%) 0.81s 0.84s
Bind Time 0.53s (± 1.25%) 0.53s (± 1.16%) -0.00s (- 0.38%) 0.52s 0.54s
Check Time 7.13s (± 0.56%) 7.14s (± 0.64%) +0.01s (+ 0.15%) 7.06s 7.23s
Emit Time 2.51s (± 0.96%) 2.52s (± 1.00%) +0.02s (+ 0.68%) 2.46s 2.57s
Total Time 11.00s (± 0.43%) 11.02s (± 0.63%) +0.02s (+ 0.19%) 10.88s 11.18s
Monaco - node (v10.16.3, x64)
Memory used 344,052k (± 0.02%) 343,971k (± 0.02%) -81k (- 0.02%) 343,805k 344,162k
Parse Time 1.59s (± 0.59%) 1.60s (± 0.50%) +0.01s (+ 0.50%) 1.58s 1.61s
Bind Time 0.75s (± 0.63%) 0.75s (± 0.59%) -0.00s (- 0.13%) 0.74s 0.76s
Check Time 5.97s (± 0.51%) 5.96s (± 0.61%) -0.01s (- 0.18%) 5.87s 6.04s
Emit Time 3.25s (± 0.41%) 3.27s (± 0.92%) +0.02s (+ 0.65%) 3.23s 3.37s
Total Time 11.56s (± 0.34%) 11.59s (± 0.46%) +0.02s (+ 0.19%) 11.48s 11.72s
TFS - node (v10.16.3, x64)
Memory used 305,139k (± 0.02%) 305,132k (± 0.03%) -7k (- 0.00%) 304,924k 305,340k
Parse Time 1.28s (± 0.74%) 1.28s (± 0.58%) -0.00s (- 0.08%) 1.27s 1.30s
Bind Time 0.72s (± 0.90%) 0.71s (± 0.70%) -0.01s (- 0.97%) 0.71s 0.73s
Check Time 5.41s (± 0.75%) 5.43s (± 0.59%) +0.01s (+ 0.26%) 5.37s 5.50s
Emit Time 3.44s (± 1.18%) 3.48s (± 0.99%) +0.03s (+ 0.99%) 3.37s 3.54s
Total Time 10.86s (± 0.49%) 10.90s (± 0.31%) +0.04s (+ 0.36%) 10.84s 10.98s
material-ui - node (v10.16.3, x64)
Memory used 469,424k (± 0.01%) 469,498k (± 0.01%) +74k (+ 0.02%) 469,395k 469,650k
Parse Time 1.83s (± 0.81%) 1.84s (± 0.71%) +0.00s (+ 0.11%) 1.81s 1.86s
Bind Time 0.68s (± 1.58%) 0.68s (± 2.16%) -0.00s (- 0.29%) 0.66s 0.71s
Check Time 14.55s (± 0.44%) 14.57s (± 0.62%) +0.02s (+ 0.14%) 14.41s 14.76s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.06s (± 0.41%) 17.08s (± 0.52%) +0.02s (+ 0.12%) 16.91s 17.26s
xstate - node (v10.16.3, x64)
Memory used 581,294k (± 1.26%) 581,302k (± 1.26%) +8k (+ 0.00%) 577,880k 610,941k
Parse Time 2.60s (± 0.28%) 2.60s (± 0.20%) -0.00s (- 0.12%) 2.59s 2.61s
Bind Time 1.03s (± 0.90%) 1.03s (± 0.98%) -0.00s (- 0.19%) 1.01s 1.06s
Check Time 1.56s (± 0.67%) 1.55s (± 0.61%) -0.01s (- 0.45%) 1.53s 1.58s
Emit Time 0.07s (± 3.14%) 0.07s (± 4.13%) +0.00s (+ 1.41%) 0.07s 0.08s
Total Time 5.26s (± 0.40%) 5.25s (± 0.31%) -0.01s (- 0.21%) 5.21s 5.29s
Angular - node (v12.1.0, x64)
Memory used 337,513k (± 0.08%) 337,751k (± 0.03%) +238k (+ 0.07%) 337,598k 337,958k
Parse Time 2.09s (± 0.43%) 2.10s (± 0.55%) +0.01s (+ 0.67%) 2.07s 2.13s
Bind Time 0.86s (± 1.52%) 0.86s (± 1.14%) +0.00s (+ 0.12%) 0.85s 0.89s
Check Time 5.83s (± 0.56%) 5.84s (± 0.67%) +0.01s (+ 0.21%) 5.78s 5.94s
Emit Time 6.38s (± 0.75%) 6.42s (± 0.74%) +0.04s (+ 0.58%) 6.32s 6.53s
Total Time 15.16s (± 0.53%) 15.22s (± 0.55%) +0.06s (+ 0.43%) 15.10s 15.44s
Compiler-Unions - node (v12.1.0, x64)
Memory used 194,165k (± 0.10%) 194,304k (± 0.02%) +140k (+ 0.07%) 194,208k 194,398k
Parse Time 0.83s (± 0.87%) 0.83s (± 0.74%) -0.00s (- 0.36%) 0.82s 0.84s
Bind Time 0.55s (± 0.87%) 0.55s (± 1.61%) +0.00s (+ 0.00%) 0.53s 0.57s
Check Time 6.71s (± 0.50%) 6.74s (± 0.67%) +0.03s (+ 0.43%) 6.64s 6.84s
Emit Time 2.55s (± 1.06%) 2.52s (± 0.85%) -0.03s (- 1.22%) 2.46s 2.56s
Total Time 10.63s (± 0.28%) 10.63s (± 0.59%) -0.01s (- 0.06%) 10.50s 10.79s
Monaco - node (v12.1.0, x64)
Memory used 326,935k (± 0.02%) 326,953k (± 0.02%) +18k (+ 0.01%) 326,824k 327,077k
Parse Time 1.58s (± 0.89%) 1.58s (± 1.34%) -0.00s (- 0.19%) 1.54s 1.63s
Bind Time 0.75s (± 1.47%) 0.74s (± 0.40%) -0.01s (- 1.07%) 0.74s 0.75s
Check Time 5.84s (± 0.65%) 5.80s (± 0.52%) -0.04s (- 0.67%) 5.76s 5.89s
Emit Time 3.33s (± 0.67%) 3.30s (± 0.78%) -0.03s (- 0.81%) 3.26s 3.39s
Total Time 11.51s (± 0.45%) 11.43s (± 0.47%) -0.08s (- 0.70%) 11.31s 11.53s
TFS - node (v12.1.0, x64)
Memory used 289,621k (± 0.07%) 289,664k (± 0.05%) +43k (+ 0.01%) 289,074k 289,828k
Parse Time 1.30s (± 0.73%) 1.30s (± 0.68%) +0.00s (+ 0.08%) 1.28s 1.32s
Bind Time 0.72s (± 0.66%) 0.72s (± 0.96%) -0.00s (- 0.28%) 0.70s 0.73s
Check Time 5.35s (± 0.50%) 5.34s (± 0.59%) -0.01s (- 0.19%) 5.30s 5.43s
Emit Time 3.49s (± 1.17%) 3.54s (± 0.63%) +0.05s (+ 1.40%) 3.49s 3.58s
Total Time 10.85s (± 0.54%) 10.90s (± 0.26%) +0.04s (+ 0.39%) 10.82s 10.97s
material-ui - node (v12.1.0, x64)
Memory used 448,421k (± 0.05%) 448,343k (± 0.07%) -79k (- 0.02%) 447,088k 448,593k
Parse Time 1.82s (± 0.55%) 1.83s (± 0.71%) +0.01s (+ 0.38%) 1.81s 1.87s
Bind Time 0.68s (± 0.73%) 0.68s (± 1.01%) 0.00s ( 0.00%) 0.66s 0.69s
Check Time 13.13s (± 0.55%) 13.05s (± 0.42%) -0.08s (- 0.59%) 12.91s 13.18s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.63s (± 0.46%) 15.56s (± 0.35%) -0.07s (- 0.45%) 15.42s 15.65s
xstate - node (v12.1.0, x64)
Memory used 546,599k (± 1.31%) 546,765k (± 1.31%) +166k (+ 0.03%) 543,430k 575,804k
Parse Time 2.54s (± 0.74%) 2.57s (± 0.58%) +0.03s (+ 1.26%) 2.54s 2.60s
Bind Time 1.03s (± 0.85%) 1.03s (± 0.98%) -0.01s (- 0.68%) 1.01s 1.05s
Check Time 1.50s (± 0.64%) 1.51s (± 0.59%) +0.00s (+ 0.33%) 1.49s 1.53s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.15s (± 0.48%) 5.17s (± 0.41%) +0.03s (+ 0.56%) 5.14s 5.23s
Angular - node (v14.15.1, x64)
Memory used 335,862k (± 0.00%) 335,891k (± 0.01%) +29k (+ 0.01%) 335,811k 335,938k
Parse Time 2.07s (± 0.39%) 2.06s (± 0.50%) -0.01s (- 0.29%) 2.04s 2.09s
Bind Time 0.90s (± 0.52%) 0.90s (± 0.75%) -0.00s (- 0.33%) 0.89s 0.92s
Check Time 5.80s (± 0.44%) 5.77s (± 0.45%) -0.04s (- 0.65%) 5.72s 5.83s
Emit Time 6.41s (± 0.49%) 6.38s (± 1.07%) -0.03s (- 0.55%) 6.29s 6.62s
Total Time 15.18s (± 0.24%) 15.10s (± 0.60%) -0.08s (- 0.53%) 14.96s 15.39s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,749k (± 0.12%) 192,835k (± 0.02%) +86k (+ 0.04%) 192,785k 192,900k
Parse Time 0.85s (± 0.72%) 0.85s (± 0.58%) -0.01s (- 0.59%) 0.84s 0.86s
Bind Time 0.57s (± 1.23%) 0.57s (± 1.13%) +0.00s (+ 0.18%) 0.56s 0.59s
Check Time 6.76s (± 0.74%) 6.76s (± 0.56%) -0.00s (- 0.07%) 6.66s 6.82s
Emit Time 2.50s (± 0.59%) 2.51s (± 0.86%) +0.01s (+ 0.36%) 2.48s 2.57s
Total Time 10.68s (± 0.52%) 10.68s (± 0.54%) -0.00s (- 0.00%) 10.55s 10.80s
Monaco - node (v14.15.1, x64)
Memory used 325,727k (± 0.01%) 325,724k (± 0.01%) -3k (- 0.00%) 325,658k 325,770k
Parse Time 1.58s (± 0.93%) 1.58s (± 0.43%) +0.00s (+ 0.13%) 1.58s 1.61s
Bind Time 0.79s (± 1.05%) 0.78s (± 0.87%) -0.00s (- 0.25%) 0.77s 0.80s
Check Time 5.69s (± 0.36%) 5.69s (± 0.54%) +0.00s (+ 0.02%) 5.62s 5.75s
Emit Time 3.37s (± 0.89%) 3.38s (± 0.30%) +0.01s (+ 0.18%) 3.35s 3.40s
Total Time 11.43s (± 0.36%) 11.44s (± 0.31%) +0.01s (+ 0.06%) 11.35s 11.50s
TFS - node (v14.15.1, x64)
Memory used 288,799k (± 0.00%) 288,798k (± 0.01%) -1k (- 0.00%) 288,736k 288,848k
Parse Time 1.34s (± 2.21%) 1.33s (± 1.03%) -0.02s (- 1.26%) 1.30s 1.35s
Bind Time 0.75s (± 2.03%) 0.77s (± 4.53%) +0.02s (+ 2.39%) 0.73s 0.85s
Check Time 5.37s (± 0.60%) 5.33s (± 0.42%) -0.03s (- 0.63%) 5.30s 5.40s
Emit Time 3.59s (± 2.10%) 3.62s (± 1.62%) +0.04s (+ 0.98%) 3.49s 3.71s
Total Time 11.05s (± 0.80%) 11.05s (± 0.48%) +0.00s (+ 0.05%) 10.94s 11.16s
material-ui - node (v14.15.1, x64)
Memory used 446,694k (± 0.01%) 446,685k (± 0.01%) -10k (- 0.00%) 446,647k 446,750k
Parse Time 1.88s (± 0.54%) 1.88s (± 0.58%) -0.00s (- 0.05%) 1.85s 1.90s
Bind Time 0.72s (± 1.04%) 0.72s (± 0.97%) +0.00s (+ 0.56%) 0.70s 0.74s
Check Time 13.20s (± 0.71%) 13.24s (± 0.77%) +0.04s (+ 0.30%) 13.06s 13.51s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.80s (± 0.59%) 15.84s (± 0.69%) +0.04s (+ 0.28%) 15.62s 16.12s
xstate - node (v14.15.1, x64)
Memory used 541,267k (± 0.00%) 541,285k (± 0.00%) +18k (+ 0.00%) 541,238k 541,354k
Parse Time 2.60s (± 0.31%) 2.59s (± 0.41%) -0.01s (- 0.38%) 2.57s 2.62s
Bind Time 1.16s (± 1.26%) 1.15s (± 1.01%) -0.01s (- 0.60%) 1.13s 1.18s
Check Time 1.55s (± 0.44%) 1.55s (± 0.74%) +0.00s (+ 0.13%) 1.53s 1.57s
Emit Time 0.07s (± 4.66%) 0.07s (± 4.66%) 0.00s ( 0.00%) 0.07s 0.08s
Total Time 5.38s (± 0.34%) 5.37s (± 0.35%) -0.02s (- 0.28%) 5.32s 5.41s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49809 10
Baseline main 10

TSServer

Comparison Report - main..49809
Metric main 49809 Delta Best Worst
xstateTSServer - node (v10.16.3, x64)
Initial load time 2,167.10ms (± 0.45%) 2,161.10ms (± 0.52%) -6.00ms (- 0.28%) 2,129.00ms 2,185.00ms
Geterr time 762.70ms (± 0.94%) 761.40ms (± 0.68%) -1.30ms (- 0.17%) 752.00ms 777.00ms
References time 97.00ms (± 1.57%) 96.70ms (± 1.09%) -0.30ms (- 0.31%) 95.00ms 100.00ms
Navto time 251.30ms (± 0.87%) 252.70ms (± 0.72%) +1.40ms (+ 0.56%) 248.00ms 256.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 245.50ms (± 1.36%) 245.70ms (± 0.63%) +0.20ms (+ 0.08%) 242.00ms 249.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
xstateTSServer - node (v12.1.0, x64)
Initial load time 2,093.70ms (± 0.66%) 2,103.90ms (± 0.56%) +10.20ms (+ 0.49%) 2,084.00ms 2,133.00ms
Geterr time 752.10ms (± 0.58%) 748.00ms (± 0.41%) -4.10ms (- 0.55%) 739.00ms 754.00ms
References time 69.00ms (± 1.67%) 68.00ms (± 1.62%) -1.00ms (- 1.45%) 66.00ms 71.00ms
Navto time 240.60ms (± 1.19%) 240.60ms (± 0.93%) 0.00ms ( 0.00%) 235.00ms 245.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 239.20ms (± 0.96%) 241.90ms (± 0.78%) +2.70ms (+ 1.13%) 238.00ms 247.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
xstateTSServer - node (v14.15.1, x64)
Initial load time 2,230.40ms (± 0.69%) 2,231.20ms (± 0.62%) +0.80ms (+ 0.04%) 2,204.00ms 2,272.00ms
Geterr time 771.70ms (± 0.51%) 768.90ms (± 0.27%) -2.80ms (- 0.36%) 765.00ms 773.00ms
References time 64.50ms (± 0.58%) 65.00ms (± 1.35%) +0.50ms (+ 0.78%) 64.00ms 68.00ms
Navto time 252.10ms (± 0.71%) 249.50ms (± 0.31%) -2.60ms (- 1.03%) 248.00ms 251.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 243.50ms (± 0.70%) 241.70ms (± 0.65%) -1.80ms (- 0.74%) 239.00ms 246.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49809 10
Baseline main 10

Developer Information:

Download Benchmark

@DanielRosenwasser DanielRosenwasser mentioned this pull request Jul 15, 2022
Closed
@a-tarasyuk a-tarasyuk closed this Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@DanielRosenwasser DanielRosenwasser

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable constants as computed values for string enums
4 participants
@a-tarasyuk @typescript-bot @DanielRosenwasser @RyanCavanaugh