feat(25758): Computed properties no throws if there is a duplicate

[a-tarasyuk]

Fixes #25758
Fixes #43186
Fixes #49666

[RyanCavanaugh]

@typescript-bot test top100

[typescript-bot]

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 69b4751. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/49848/merge:

Everything looks good!

[RyanCavanaugh]

@typescript-bot perf test this

[typescript-bot]

Heya @RyanCavanaugh, I'm starting to run the perf test suite on this PR at 69b4751. Hold tight - I'll update this comment with the log link once the build has been queued.

[jakebailey]

@typescript-bot perf test this but maybe work this time?

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at 69b4751. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..49848

Metric	main	49848	Delta	Best	Worst
Angular - node (v18.10.0, x64)
Memory used	352,922k (± 0.03%)	352,881k (± 0.03%)	-41k (- 0.01%)	352,619k	353,078k
Parse Time	1.55s (± 0.57%)	1.55s (± 0.44%)	-0.00s (- 0.26%)	1.53s	1.56s
Bind Time	0.61s (± 1.01%)	0.61s (± 1.22%)	+0.00s (+ 0.33%)	0.60s	0.64s
Check Time	4.42s (± 0.60%)	4.39s (± 0.31%)	-0.03s (- 0.63%)	4.36s	4.42s
Emit Time	4.92s (± 0.66%)	4.90s (± 0.77%)	-0.02s (- 0.35%)	4.84s	4.98s
Total Time	11.49s (± 0.43%)	11.45s (± 0.44%)	-0.04s (- 0.38%)	11.37s	11.57s
Compiler-Unions - node (v18.10.0, x64)
Memory used	200,206k (± 0.84%)	199,686k (± 0.96%)	-520k (- 0.26%)	195,692k	201,514k
Parse Time	0.60s (± 0.96%)	0.60s (± 1.21%)	+0.00s (+ 0.33%)	0.59s	0.62s
Bind Time	0.36s (± 1.11%)	0.36s (± 1.11%)	-0.00s (- 0.55%)	0.35s	0.37s
Check Time	5.34s (± 0.55%)	5.35s (± 0.77%)	+0.02s (+ 0.36%)	5.28s	5.47s
Emit Time	1.81s (± 1.13%)	1.82s (± 1.24%)	+0.01s (+ 0.44%)	1.78s	1.88s
Total Time	8.11s (± 0.51%)	8.13s (± 0.60%)	+0.02s (+ 0.30%)	8.01s	8.20s
Monaco - node (v18.10.0, x64)
Memory used	331,724k (± 0.01%)	331,684k (± 0.01%)	-40k (- 0.01%)	331,618k	331,754k
Parse Time	1.16s (± 0.63%)	1.16s (± 0.65%)	+0.01s (+ 0.52%)	1.15s	1.18s
Bind Time	0.56s (± 0.93%)	0.56s (± 0.85%)	-0.00s (- 0.71%)	0.54s	0.56s
Check Time	4.30s (± 0.76%)	4.30s (± 0.74%)	+0.00s (+ 0.02%)	4.22s	4.36s
Emit Time	2.63s (± 0.85%)	2.63s (± 0.62%)	+0.00s (+ 0.11%)	2.60s	2.67s
Total Time	8.64s (± 0.59%)	8.65s (± 0.48%)	+0.01s (+ 0.12%)	8.56s	8.74s
TFS - node (v18.10.0, x64)
Memory used	294,722k (± 0.01%)	294,725k (± 0.01%)	+3k (+ 0.00%)	294,650k	294,813k
Parse Time	0.94s (± 0.95%)	0.94s (± 1.07%)	+0.00s (+ 0.11%)	0.92s	0.97s
Bind Time	0.59s (± 3.49%)	0.59s (± 3.52%)	+0.00s (+ 0.17%)	0.55s	0.63s
Check Time	4.00s (± 0.42%)	4.01s (± 0.43%)	+0.01s (+ 0.15%)	3.97s	4.06s
Emit Time	2.63s (± 0.55%)	2.63s (± 0.71%)	+0.00s (+ 0.08%)	2.59s	2.66s
Total Time	8.15s (± 0.40%)	8.16s (± 0.52%)	+0.01s (+ 0.11%)	8.08s	8.24s
material-ui - node (v18.10.0, x64)
Memory used	439,000k (± 0.01%)	439,005k (± 0.02%)	+5k (+ 0.00%)	438,916k	439,195k
Parse Time	1.35s (± 0.57%)	1.35s (± 0.75%)	+0.00s (+ 0.30%)	1.33s	1.38s
Bind Time	0.44s (± 0.51%)	0.44s (± 1.18%)	0.00s ( 0.00%)	0.43s	0.45s
Check Time	10.85s (± 0.63%)	10.86s (± 0.58%)	+0.01s (+ 0.10%)	10.77s	11.08s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	12.64s (± 0.55%)	12.66s (± 0.55%)	+0.02s (+ 0.13%)	12.56s	12.90s
xstate - node (v18.10.0, x64)
Memory used	556,694k (± 0.02%)	556,683k (± 0.01%)	-11k (- 0.00%)	556,550k	556,777k
Parse Time	1.92s (± 0.42%)	1.92s (± 0.40%)	-0.00s (- 0.21%)	1.90s	1.93s
Bind Time	0.68s (± 1.29%)	0.69s (± 2.15%)	+0.01s (+ 1.47%)	0.67s	0.73s
Check Time	1.11s (± 0.87%)	1.10s (± 0.47%)	-0.01s (- 0.72%)	1.09s	1.12s
Emit Time	0.06s (± 0.00%)	0.06s (± 0.00%)	0.00s ( 0.00%)	0.06s	0.06s
Total Time	3.76s (± 0.43%)	3.76s (± 0.63%)	-0.00s (- 0.03%)	3.73s	3.83s
Angular - node (v16.17.1, x64)
Memory used	352,207k (± 0.07%)	352,450k (± 0.02%)	+243k (+ 0.07%)	352,189k	352,539k
Parse Time	1.91s (± 0.97%)	1.90s (± 0.61%)	-0.01s (- 0.52%)	1.88s	1.93s
Bind Time	0.75s (± 0.69%)	0.75s (± 0.78%)	-0.00s (- 0.27%)	0.74s	0.76s
Check Time	5.73s (± 0.87%)	5.70s (± 0.62%)	-0.03s (- 0.54%)	5.63s	5.77s
Emit Time	6.13s (± 1.17%)	6.09s (± 0.77%)	-0.04s (- 0.62%)	6.01s	6.24s
Total Time	14.52s (± 0.74%)	14.44s (± 0.36%)	-0.08s (- 0.54%)	14.36s	14.56s
Compiler-Unions - node (v16.17.1, x64)
Memory used	198,050k (± 0.49%)	197,724k (± 0.37%)	-326k (- 0.16%)	197,347k	200,646k
Parse Time	0.78s (± 0.79%)	0.79s (± 1.14%)	+0.00s (+ 0.51%)	0.77s	0.80s
Bind Time	0.46s (± 1.09%)	0.45s (± 1.09%)	-0.00s (- 0.22%)	0.45s	0.47s
Check Time	6.42s (± 0.29%)	6.44s (± 0.78%)	+0.02s (+ 0.30%)	6.30s	6.57s
Emit Time	2.29s (± 1.52%)	2.28s (± 0.89%)	-0.01s (- 0.22%)	2.25s	2.35s
Total Time	9.94s (± 0.35%)	9.96s (± 0.62%)	+0.02s (+ 0.19%)	9.81s	10.11s
Monaco - node (v16.17.1, x64)
Memory used	331,135k (± 0.01%)	331,112k (± 0.01%)	-23k (- 0.01%)	331,059k	331,192k
Parse Time	1.43s (± 0.74%)	1.43s (± 0.66%)	+0.01s (+ 0.42%)	1.42s	1.46s
Bind Time	0.69s (± 0.75%)	0.69s (± 0.89%)	+0.00s (+ 0.29%)	0.68s	0.70s
Check Time	5.47s (± 0.57%)	5.48s (± 1.10%)	+0.00s (+ 0.05%)	5.42s	5.71s
Emit Time	3.25s (± 0.52%)	3.25s (± 0.48%)	+0.00s (+ 0.06%)	3.23s	3.30s
Total Time	10.84s (± 0.33%)	10.85s (± 0.57%)	+0.01s (+ 0.14%)	10.77s	11.09s
TFS - node (v16.17.1, x64)
Memory used	294,087k (± 0.01%)	294,096k (± 0.02%)	+9k (+ 0.00%)	293,903k	294,178k
Parse Time	1.22s (± 1.05%)	1.23s (± 1.68%)	+0.01s (+ 0.98%)	1.20s	1.30s
Bind Time	0.65s (± 0.58%)	0.64s (± 0.46%)	-0.00s (- 0.47%)	0.64s	0.65s
Check Time	5.14s (± 0.67%)	5.10s (± 0.29%)	-0.03s (- 0.66%)	5.07s	5.14s
Emit Time	3.48s (± 0.75%)	3.47s (± 0.74%)	-0.01s (- 0.17%)	3.42s	3.53s
Total Time	10.48s (± 0.47%)	10.46s (± 0.41%)	-0.02s (- 0.24%)	10.38s	10.55s
material-ui - node (v16.17.1, x64)
Memory used	438,366k (± 0.01%)	438,355k (± 0.01%)	-11k (- 0.00%)	438,270k	438,410k
Parse Time	1.72s (± 1.18%)	1.72s (± 1.27%)	+0.01s (+ 0.41%)	1.69s	1.77s
Bind Time	0.54s (± 0.68%)	0.54s (± 0.74%)	+0.00s (+ 0.56%)	0.53s	0.55s
Check Time	12.48s (± 0.45%)	12.47s (± 0.85%)	-0.01s (- 0.07%)	12.32s	12.84s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	14.73s (± 0.42%)	14.73s (± 0.78%)	-0.00s (- 0.01%)	14.54s	15.12s
xstate - node (v16.17.1, x64)
Memory used	554,431k (± 0.02%)	554,402k (± 0.02%)	-29k (- 0.01%)	554,259k	554,677k
Parse Time	2.30s (± 0.28%)	2.31s (± 0.52%)	+0.00s (+ 0.22%)	2.29s	2.35s
Bind Time	0.90s (± 2.30%)	0.88s (± 1.05%)	-0.02s (- 1.78%)	0.87s	0.90s
Check Time	1.43s (± 0.98%)	1.43s (± 0.43%)	+0.00s (+ 0.07%)	1.42s	1.44s
Emit Time	0.07s (± 0.00%)	0.07s (± 0.00%)	0.00s ( 0.00%)	0.07s	0.07s
Total Time	4.70s (± 0.35%)	4.69s (± 0.31%)	-0.01s (- 0.21%)	4.67s	4.73s
Angular - node (v14.15.1, x64)
Memory used	346,641k (± 0.01%)	346,648k (± 0.01%)	+7k (+ 0.00%)	346,569k	346,703k
Parse Time	2.08s (± 0.84%)	2.08s (± 1.30%)	+0.00s (+ 0.10%)	2.05s	2.18s
Bind Time	0.80s (± 0.43%)	0.80s (± 0.28%)	+0.00s (+ 0.25%)	0.79s	0.80s
Check Time	5.98s (± 0.34%)	5.98s (± 0.35%)	-0.00s (- 0.03%)	5.93s	6.01s
Emit Time	6.28s (± 0.56%)	6.27s (± 0.42%)	-0.01s (- 0.10%)	6.22s	6.33s
Total Time	15.13s (± 0.18%)	15.13s (± 0.37%)	-0.01s (- 0.03%)	15.03s	15.31s
Compiler-Unions - node (v14.15.1, x64)
Memory used	190,932k (± 0.68%)	190,945k (± 0.67%)	+13k (+ 0.01%)	190,312k	196,143k
Parse Time	0.86s (± 0.95%)	0.86s (± 0.98%)	+0.00s (+ 0.47%)	0.85s	0.89s
Bind Time	0.49s (± 0.60%)	0.49s (± 0.60%)	0.00s ( 0.00%)	0.49s	0.50s
Check Time	6.72s (± 0.33%)	6.71s (± 0.68%)	-0.01s (- 0.16%)	6.61s	6.80s
Emit Time	2.41s (± 0.79%)	2.42s (± 0.67%)	+0.01s (+ 0.46%)	2.40s	2.47s
Total Time	10.48s (± 0.28%)	10.49s (± 0.53%)	+0.00s (+ 0.04%)	10.38s	10.63s
Monaco - node (v14.15.1, x64)
Memory used	326,556k (± 0.01%)	326,593k (± 0.01%)	+37k (+ 0.01%)	326,528k	326,631k
Parse Time	1.58s (± 0.53%)	1.58s (± 0.79%)	+0.00s (+ 0.25%)	1.56s	1.61s
Bind Time	0.73s (± 0.41%)	0.73s (± 0.71%)	-0.00s (- 0.14%)	0.72s	0.74s
Check Time	5.73s (± 0.67%)	5.73s (± 0.36%)	-0.00s (- 0.02%)	5.70s	5.79s
Emit Time	3.40s (± 0.77%)	3.39s (± 0.79%)	-0.01s (- 0.26%)	3.34s	3.44s
Total Time	11.44s (± 0.52%)	11.44s (± 0.30%)	-0.01s (- 0.05%)	11.37s	11.54s
TFS - node (v14.15.1, x64)
Memory used	289,707k (± 0.01%)	289,697k (± 0.01%)	-10k (- 0.00%)	289,634k	289,741k
Parse Time	1.30s (± 0.97%)	1.29s (± 0.50%)	-0.01s (- 0.69%)	1.28s	1.31s
Bind Time	0.80s (± 0.72%)	0.80s (± 0.28%)	-0.00s (- 0.25%)	0.80s	0.81s
Check Time	5.41s (± 0.37%)	5.39s (± 0.64%)	-0.01s (- 0.26%)	5.32s	5.50s
Emit Time	3.62s (± 0.73%)	3.63s (± 0.89%)	+0.01s (+ 0.28%)	3.58s	3.73s
Total Time	11.13s (± 0.39%)	11.12s (± 0.48%)	-0.01s (- 0.10%)	11.05s	11.27s
material-ui - node (v14.15.1, x64)
Memory used	434,402k (± 0.04%)	434,475k (± 0.01%)	+73k (+ 0.02%)	434,396k	434,508k
Parse Time	1.88s (± 0.33%)	1.88s (± 0.51%)	+0.01s (+ 0.32%)	1.86s	1.91s
Bind Time	0.59s (± 0.62%)	0.59s (± 0.58%)	+0.00s (+ 0.17%)	0.58s	0.59s
Check Time	12.85s (± 0.91%)	12.90s (± 0.54%)	+0.05s (+ 0.37%)	12.79s	13.15s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.32s (± 0.77%)	15.37s (± 0.44%)	+0.05s (+ 0.35%)	15.29s	15.62s
xstate - node (v14.15.1, x64)
Memory used	543,460k (± 0.01%)	543,473k (± 0.01%)	+13k (+ 0.00%)	543,406k	543,538k
Parse Time	2.60s (± 0.36%)	2.61s (± 0.62%)	+0.00s (+ 0.19%)	2.58s	2.65s
Bind Time	0.98s (± 1.11%)	0.99s (± 0.77%)	+0.00s (+ 0.31%)	0.97s	1.01s
Check Time	1.50s (± 0.50%)	1.51s (± 0.49%)	+0.01s (+ 0.40%)	1.50s	1.53s
Emit Time	0.07s (± 0.00%)	0.07s (± 0.00%)	0.00s ( 0.00%)	0.07s	0.07s
Total Time	5.17s (± 0.34%)	5.18s (± 0.41%)	+0.01s (+ 0.19%)	5.13s	5.22s

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-126-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	49848	10
Baseline	main	10

TSServer

Comparison Report - main..49848

Metric	main	49848	Delta	Best	Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	1,064ms (± 0.51%)	1,065ms (± 0.34%)	+1ms (+ 0.06%)	1,054ms	1,074ms
Req 2 - geterr	2,700ms (± 0.40%)	2,726ms (± 0.60%)	+26ms (+ 0.95%)	2,701ms	2,762ms
Req 3 - references	191ms (± 0.70%)	192ms (± 1.66%)	+1ms (+ 0.68%)	189ms	203ms
Req 4 - navto	144ms (± 0.71%)	145ms (± 0.90%)	+0ms (+ 0.28%)	142ms	147ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	43ms (± 0.79%)	44ms (± 1.85%)	+1ms (+ 1.62%)	43ms	47ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	1,129ms (± 0.70%)	1,136ms (± 0.49%)	+7ms (+ 0.66%)	1,124ms	1,151ms
Req 2 - geterr	1,607ms (± 0.56%)	1,609ms (± 0.58%)	+3ms (+ 0.16%)	1,585ms	1,628ms
Req 3 - references	198ms (± 0.50%)	198ms (± 0.67%)	-0ms (- 0.15%)	196ms	201ms
Req 4 - navto	160ms (± 1.68%)	160ms (± 1.74%)	-0ms (- 0.13%)	155ms	166ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	85ms (± 4.56%)	86ms (± 6.07%)	+1ms (+ 0.82%)	77ms	102ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	1,616ms (± 0.40%)	1,622ms (± 0.50%)	+6ms (+ 0.36%)	1,607ms	1,640ms
Req 2 - geterr	573ms (± 0.59%)	576ms (± 0.94%)	+4ms (+ 0.63%)	567ms	592ms
Req 3 - references	51ms (± 0.65%)	52ms (± 2.14%)	+1ms (+ 1.37%)	51ms	56ms
Req 4 - navto	203ms (± 0.35%)	202ms (± 0.52%)	-1ms (- 0.25%)	200ms	204ms
Req 5 - completionInfo count	3,206 (± 0.00%)	3,206 (± 0.00%)	0 ( 0.00%)	3,206	3,206
Req 5 - completionInfo	216ms (± 1.72%)	216ms (± 0.99%)	-0ms (- 0.14%)	212ms	221ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	1,324ms (± 0.45%)	1,327ms (± 0.41%)	+4ms (+ 0.27%)	1,314ms	1,336ms
Req 2 - geterr	3,278ms (± 0.50%)	3,270ms (± 0.67%)	-8ms (- 0.25%)	3,246ms	3,344ms
Req 3 - references	222ms (± 1.21%)	222ms (± 1.02%)	-0ms (- 0.09%)	218ms	228ms
Req 4 - navto	156ms (± 0.52%)	157ms (± 0.49%)	+1ms (+ 0.90%)	155ms	159ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	71ms (±19.22%)	65ms (±21.08%)	🟩-6ms (- 8.29%)	52ms	99ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	1,405ms (± 0.32%)	1,406ms (± 0.47%)	+1ms (+ 0.07%)	1,391ms	1,421ms
Req 2 - geterr	2,103ms (± 0.54%)	2,104ms (± 0.37%)	+1ms (+ 0.04%)	2,085ms	2,116ms
Req 3 - references	231ms (± 0.71%)	232ms (± 0.81%)	+1ms (+ 0.35%)	229ms	236ms
Req 4 - navto	168ms (± 0.53%)	167ms (± 0.58%)	-1ms (- 0.36%)	165ms	169ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	54ms (± 6.26%)	51ms (± 0.66%)	🟩-2ms (- 4.29%)	51ms	52ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	1,930ms (± 0.46%)	1,926ms (± 0.31%)	-5ms (- 0.25%)	1,915ms	1,941ms
Req 2 - geterr	728ms (± 0.64%)	728ms (± 0.40%)	-0ms (- 0.05%)	723ms	735ms
Req 3 - references	61ms (± 1.83%)	60ms (± 0.67%)	-1ms (- 0.83%)	59ms	61ms
Req 4 - navto	204ms (± 0.78%)	205ms (± 0.51%)	+1ms (+ 0.64%)	203ms	207ms
Req 5 - completionInfo count	3,206 (± 0.00%)	3,206 (± 0.00%)	0 ( 0.00%)	3,206	3,206
Req 5 - completionInfo	259ms (± 0.41%)	259ms (± 0.68%)	+0ms (+ 0.04%)	255ms	264ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	1,453ms (± 0.48%)	1,455ms (± 0.49%)	+2ms (+ 0.17%)	1,443ms	1,476ms
Req 2 - geterr	3,507ms (± 0.50%)	3,518ms (± 0.51%)	+10ms (+ 0.30%)	3,485ms	3,558ms
Req 3 - references	233ms (± 0.29%)	234ms (± 0.46%)	+1ms (+ 0.34%)	231ms	236ms
Req 4 - navto	171ms (± 0.61%)	172ms (± 0.56%)	+1ms (+ 0.41%)	170ms	174ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	56ms (± 4.20%)	56ms (± 4.93%)	+0ms (+ 0.54%)	54ms	66ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	1,537ms (± 0.62%)	1,531ms (± 0.62%)	-7ms (- 0.44%)	1,511ms	1,551ms
Req 2 - geterr	2,324ms (± 0.47%)	2,308ms (± 0.37%)	-15ms (- 0.66%)	2,289ms	2,322ms
Req 3 - references	245ms (± 0.78%)	245ms (± 0.90%)	+1ms (+ 0.37%)	243ms	253ms
Req 4 - navto	181ms (± 0.84%)	180ms (± 0.72%)	-2ms (- 0.99%)	177ms	183ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	55ms (± 1.36%)	54ms (± 0.82%)	-1ms (- 0.91%)	53ms	55ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,147ms (± 0.41%)	2,153ms (± 0.34%)	+6ms (+ 0.27%)	2,138ms	2,168ms
Req 2 - geterr	751ms (± 0.39%)	756ms (± 0.32%)	+6ms (+ 0.76%)	752ms	761ms
Req 3 - references	67ms (± 3.08%)	66ms (± 2.53%)	-1ms (- 0.75%)	63ms	70ms
Req 4 - navto	228ms (± 0.54%)	235ms (± 6.29%)	+7ms (+ 3.11%)	227ms	295ms
Req 5 - completionInfo count	3,206 (± 0.00%)	3,206 (± 0.00%)	0 ( 0.00%)	3,206	3,206
Req 5 - completionInfo	274ms (± 1.05%)	275ms (± 1.33%)	+1ms (+ 0.47%)	268ms	282ms

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-126-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	49848	10
Baseline	main	10

Developer Information:

Download Benchmark

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 80dccc9. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 80dccc9. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 80dccc9. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 80dccc9. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 80dccc9. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/49848/merge:

Everything looks good!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49848

Metric	main	49848	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	363,011k (± 0.00%)	362,994k (± 0.01%)	~	362,964k	363,015k	p=0.173 n=6
Parse Time	3.52s (± 0.59%)	3.52s (± 0.80%)	~	3.49s	3.56s	p=0.871 n=6
Bind Time	1.18s (± 0.44%)	1.18s (± 0.99%)	~	1.16s	1.19s	p=0.929 n=6
Check Time	9.45s (± 0.61%)	9.45s (± 0.39%)	~	9.42s	9.52s	p=0.686 n=6
Emit Time	7.93s (± 0.54%)	7.93s (± 0.31%)	~	7.90s	7.96s	p=0.686 n=6
Total Time	22.09s (± 0.45%)	22.08s (± 0.15%)	~	22.05s	22.14s	p=0.936 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,680k (± 0.04%)	193,264k (± 0.73%)	~	192,589k	196,143k	p=0.575 n=6
Parse Time	1.57s (± 1.63%)	1.58s (± 2.43%)	~	1.50s	1.60s	p=0.624 n=6
Bind Time	0.82s (± 0.92%)	0.82s (± 0.00%)	~	0.82s	0.82s	p=0.598 n=6
Check Time	10.12s (± 0.32%)	10.05s (± 0.59%)	~	9.99s	10.15s	p=0.106 n=6
Emit Time	3.00s (± 0.88%)	2.99s (± 1.19%)	~	2.95s	3.05s	p=0.418 n=6
Total Time	15.51s (± 0.20%)	15.44s (± 0.42%)	~	15.35s	15.52s	p=0.077 n=6
Monaco - node (v16.17.1, x64)
Memory used	346,714k (± 0.00%)	346,716k (± 0.01%)	~	346,690k	346,763k	p=0.936 n=6
Parse Time	2.73s (± 0.61%)	2.73s (± 0.15%)	~	2.72s	2.73s	p=0.924 n=6
Bind Time	1.09s (± 0.37%)	1.09s (± 1.25%)	~	1.08s	1.12s	p=0.753 n=6
Check Time	7.75s (± 0.45%)	7.76s (± 0.42%)	~	7.71s	7.79s	p=0.685 n=6
Emit Time	4.48s (± 0.76%)	4.45s (± 0.45%)	~	4.44s	4.49s	p=0.165 n=6
Total Time	16.05s (± 0.40%)	16.03s (± 0.26%)	~	15.96s	16.08s	p=0.520 n=6
TFS - node (v16.17.1, x64)
Memory used	300,142k (± 0.01%)	300,140k (± 0.01%)	~	300,124k	300,178k	p=0.470 n=6
Parse Time	2.17s (± 0.45%)	2.17s (± 0.24%)	~	2.17s	2.18s	p=0.504 n=6
Bind Time	1.24s (± 0.61%)	1.24s (± 0.33%)	~	1.24s	1.25s	p=1.000 n=6
Check Time	7.21s (± 0.49%)	7.18s (± 0.55%)	~	7.14s	7.25s	p=0.167 n=6
Emit Time	4.36s (± 0.69%)	4.34s (± 0.61%)	~	4.30s	4.37s	p=0.329 n=6
Total Time	14.99s (± 0.44%)	14.94s (± 0.24%)	~	14.90s	14.99s	p=0.170 n=6
material-ui - node (v16.17.1, x64)
Memory used	477,755k (± 0.00%)	477,754k (± 0.01%)	~	477,661k	477,827k	p=1.000 n=6
Parse Time	3.22s (± 0.75%)	3.23s (± 0.36%)	~	3.21s	3.24s	p=0.418 n=6
Bind Time	0.95s (± 0.86%)	0.96s (± 0.43%)	~	0.95s	0.96s	p=0.248 n=6
Check Time	18.12s (± 0.76%)	18.10s (± 0.51%)	~	18.00s	18.21s	p=1.000 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.30s (± 0.61%)	22.29s (± 0.44%)	~	22.19s	22.41s	p=0.873 n=6
xstate - node (v16.17.1, x64)
Memory used	550,664k (± 0.02%)	550,691k (± 0.02%)	~	550,599k	550,905k	p=0.688 n=6
Parse Time	3.96s (± 0.58%)	3.95s (± 0.30%)	~	3.93s	3.96s	p=1.000 n=6
Bind Time	1.79s (± 0.42%)	1.79s (± 0.65%)	~	1.77s	1.80s	p=0.933 n=6
Check Time	2.99s (± 0.46%)	3.01s (± 0.54%)	~	2.99s	3.03s	p=0.123 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	8.83s (± 0.30%)	8.84s (± 0.31%)	~	8.80s	8.88s	p=0.627 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	49848	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/49848/merge:

Everything looks good!

[typescript-bot]

Hey @jakebailey, the results of running the DT tests are ready.
There were interesting changes:

Errors that changed:

Package: dom-mediacapture-record
Nightly error:

Error: Errors in typescript@local for external dependencies:
../../../node_modules/typescript/lib/lib.dom.d.ts(19298,6): error TS2300: Duplicate identifier 'BitrateMode'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Branch error:

Error: Errors in typescript@local for external dependencies:
../../../../../../built/local/lib.dom.d.ts(19298,6): error TS2300: Duplicate identifier 'BitrateMode'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

[jakebailey]

Checking https://github.com/microsoft/TypeScript/pull/49848/files?w=1 this feels okay to me. This has been in review for a while. Are there any other concerns here?

[a-tarasyuk]

@weswigham Thanks