feat(#48863): Split ES5 lib into individual parts #49853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
typescript-bot
added
the
For Uncommitted Bug
|
Some backstory and a lesson learned whilst implementing these changes... I originally tried to exclude the new |
|
@typescript-bot perf test this (though I'm not sure how well the perf tests measure startup time) |
|
Heya @sandersn, I've started to run the perf test suite on this PR at 0cbbb34. You can monitor the build here. Update: The results are in! |
|
I feel like this is something we need to discuss in a design meeting before reviewing since the code change is fairly simple but also hugely susceptible to going stale. Let's see what performance is like and then I'd vote to close the PR until the design is finalised. |
|
@sandersn Here they are:
CompilerComparison Report - main..49853
System
Hosts
Scenarios
TSServerComparison Report - main..49853
System
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@sandersn thanks for the update, I made a comment in my initial issue outlining a liking better solution to the functionality I'm looking for, but I still think that splitting up the ES5 library will be hugely beneficial to the end goal! |
|
No significant performance difference that I noticed. |
|
To help with PR housekeeping, I'm going to close this until its bug is ready. |
|
For future reference, what could I have done differently to get this one pushed through @sandersn? I understand that a lot of files were changed, and reviewing this would have taken some time, but the overall impact was very low, almost negligible. I'm still keen to champion this improvement if you're accepting contributions from outside collaborators 👍 |
|
That's a tricky one. The state Awaiting More Feedback on the issue tracker means that we're waiting for more people to chime in with reasons why they want this feature. Sometimes that's to know whether more than one person wants it, sometimes that's to find out the variety of things that could be done, and to decide which should be done. We get so many bugs and PRs that we generally don't review any outside PR until there's an accepted bug for it. Finally, for this particular feature: changing the lib, even in obviously non-breaking ways, somehow ends up breaking people. So merging this PR would make us commit to finding and fixing breaks in important libraries before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopes to address #48863, the scale of the changes is small, and non breaking, but the impact on the tests is pretty huge. More context can be found in the linked issue explaining the changes in more depth.