Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(49869): No error in JavaScript on optional binding pattern parameter #50094

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #49869

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 29, 2022
src/compiler/checker.ts Show resolved Hide resolved
@voxpelli
Copy link

voxpelli commented Aug 1, 2022

I think this caused a regression: voxpelli/pony-cause#45

I’ll check it better when I’m at a computer and will try to find time to post a proper issue about it.

@sandersn
Copy link
Member

sandersn commented Aug 1, 2022

@a-tarasyuk looking at the failure, it's a question of whether we want to make Javascript syntax match Typescript syntax:
voxpelli/pony-cause#45 (comment)

@sandersn
Copy link
Member

sandersn commented Aug 1, 2022

After thinking about it a bit, I think consistency with Typescript is more valuable than being able to be explicit about optionality of binding patterns in JSDoc. So currently I'd recommend leaving this fix as-is and changing pony-cause.

@voxpelli
Copy link

voxpelli commented Aug 1, 2022

I disagree, but responded in voxpelli/pony-cause#45 (comment) rather than here so I won't repeat myself here :)

@voxpelli
Copy link

To ensure that this doesn't get lost, I added a proper regression report to the TS-repo: #50286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error in JavaScript on optional binding pattern parameter
4 participants