Skip to content

Leave switch as-is but just extract branches to function calls #50245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Leave switch as-is but just extract branches to function calls #50245

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f671ea7
Swap `forEachChild` to use an array of functions instead of a `switch…
DanielRosenwasser Aug 8, 2022
e42cfaf
Let's see if 'new' changes anything.
DanielRosenwasser Aug 8, 2022
f8e1c2a
Co-locate each assignment into `forEachChildTable`.
DanielRosenwasser Aug 8, 2022
85a0937
Try `push`ing undefined to create a packed Array.
DanielRosenwasser Aug 9, 2022
059572a
Try using an unconditional no-op function.
DanielRosenwasser Aug 9, 2022
79286eb
`forEach` -> `forEachChildIn`
DanielRosenwasser Aug 9, 2022
6269b36
Remove the optional chain if we are pre-filling with no-ops.
DanielRosenwasser Aug 9, 2022
b94b82a
Grab function directly to avoid possible `.call` overhead from downle…
DanielRosenwasser Aug 9, 2022
e9d86d9
Full switch but still using functions for comparison
weswigham Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading