Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On windows handle the long paths in realpathSync.native #50306

Merged
merged 1 commit into from
Aug 15, 2022
Merged

On windows handle the long paths in realpathSync.native #50306

merged 1 commit into from
Aug 15, 2022

Conversation

sheetalkamat
Copy link
Member

Fixes #49470

@sheetalkamat sheetalkamat requested a review from amcasey August 15, 2022 17:52
@sheetalkamat sheetalkamat marked this pull request as ready for review August 15, 2022 17:52
@typescript-bot typescript-bot added Author: Team For Backlog Bug PRs that fix a backlog bug labels Aug 15, 2022
@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 15, 2022 •
edited
Loading

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at b73d93b. You can monitor the build here.

@sheetalkamat sheetalkamat mentioned this pull request Aug 15, 2022
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 15, 2022 •
edited
Loading

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/131839/artifacts?artifactName=tgz&fileId=279EF5891EC300B3E811133242EA473CF3349284515DDA8F708CC7EC039287D402&fileName=/typescript-4.9.0-insiders.20220815.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.9.0-pr-50306-2".;

@sheetalkamat sheetalkamat merged commit 9c1baee into main Aug 15, 2022
@sheetalkamat sheetalkamat deleted the realpathNative branch August 15, 2022 23:57
@amcasey
Copy link
Member

amcasey commented Aug 16, 2022

Gross

LGTM

@sheetalkamat
Copy link
Member Author

sheetalkamat commented Aug 16, 2022 •
edited
Loading

@DanielRosenwasser @amcasey do we need to port this to 4.8 ? 4.7 potentially if we are going to have patch for 4.7 at all?

@fwienber who found this issue and debugged it might be interested in answer to this question

@amcasey
Copy link
Member

amcasey commented Aug 16, 2022

@sheetalkamat The issue linked in the description doesn't have a lot of upvotes. Have we been hearing about a lot of people hitting this issue? I'm not sure I'd backport to 4.7 based on the information I have now.

@sheetalkamat
Copy link
Member Author

sheetalkamat commented Aug 16, 2022 •
edited
Loading

@amcasey its not even the issue linked.. My bad that i assumed the debugging information we received from @fwienber was for that issue.

@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 16, 2022 •
edited
Loading

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-4.8 on this PR at b73d93b. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Aug 16, 2022
Merged
@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #50324 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 16, 2022
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#50306 into release-4.8
11f7beb 
Component commits:
b73d93b On windows handle the long paths in realpathSync.native Fixes microsoft#49470
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 18, 2022
@sheetalkamat
Cherry-pick PR microsoft#50306 into release-4.8 (microsoft#50324)
ccfc09d 
Component commits:
b73d93b On windows handle the long paths in realpathSync.native Fixes microsoft#49470

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@amcasey amcasey Awaiting requested review from amcasey

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forceConsistentCasingInFileNames doesn't work for modules in node_modules
4 participants
@sheetalkamat @typescript-bot @amcasey @andrewbranch