Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT REVIEW] checking if perf testing is broken #50812

Closed
wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Member

No description provided.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 16, 2022

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at ce7854e. You can monitor the build here.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 16, 2022

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 89658ee. You can monitor the build here.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 16, 2022

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at e2ad372. You can monitor the build here.

@jakebailey
Copy link
Member Author

Do ignore the contents of this PR; I'm trying silly things includeing rolling main back to the last state I knew the benchmarks ran on. @weswigham @gabritto are trying other things too, but of course we all can't run perf benchmarks at the same time (and also the release branch was just merged into so now that's running too)

@jakebailey
Copy link
Member Author

AFAIK the issue is that the folder isn't clean, and I broke the folder once in my module testing PR, and that left dirty files that made other tests bad. Fix for now is to clean the PR, but that may slow down perf testing because of reclones of the repo, depending.

@jakebailey jakebailey closed this Sep 16, 2022
@jakebailey jakebailey deleted the empty-commit branch September 16, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants