Skip to content

Ignore the keyofStringsOnly setting so we can see who depends on it and how #50852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RyanCavanaugh
Copy link
Member

Per title

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 19, 2022
@RyanCavanaugh
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 19, 2022

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 7f62105. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 19, 2022

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 7f62105. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 19, 2022

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 7f62105. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/50852/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@jakebailey
Copy link
Member

@typescript-bot run top100

@jakebailey
Copy link
Member

No, I'm silly.

@typescript-bot test top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 19, 2022

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 7f62105. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/50852/merge:

Everything looks good!

@sandersn
Copy link
Member

sandersn commented Oct 5, 2022

@RyanCavanaugh @jakebailey Is this something we intend to ship or is the PR just an experiment?

@jakebailey
Copy link
Member

I think this is just an experiment and would actually be implemented as part of #51000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants