Instance of else clause #5092
Merged
Instance of else clause #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5976,6 +5977,13 @@ namespace ts { | |||
| } | |||
|
|
|||
| if (targetType) { | |||
| if (!assumeTrue) { | |||
| if (type.flags & TypeFlags.Union) { | |||
| return getUnionType(filter((<UnionType>type).types, t => !isTypeSubtypeOf(t, targetType))); | |||
There was a problem hiding this comment.
@RyanCavanaugh what happened with the idea that if the RHS type isn't a subtype of any types in the union, that we just discard the LHS type and take the RHS type? Is that something that we eventually went with?
There was a problem hiding this comment.
I don't remember what we decided on that.
|
@tinganho can you address the merge conflict? |
|
What happened to the |
tinganho
force-pushed
the
instanceOfElseClause
branch
from
c91c905 to
dd54b7a
Compare
|
@RyanCavanaugh I fixed the merge conflict. And |
|
@mhegazy good with this? |
|
👍 |
|
Sorry for the delay. 👍 |
|
thanks! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1719.