Handle jsx runtime implicit synthetic import in find all references #51319
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
src/services/findAllReferences.ts
Outdated
| const range = forEachChildRecursively( | ||
| reference.referencingFile, | ||
| n => isJsxElement(n) || isJsxSelfClosingElement(n) || isJsxFragment(n) ? n : undefined | ||
| ) || reference.referencingFile.statements[0] || reference.referencingFile; |
There was a problem hiding this comment.
I thought a bit more about the statements[0] case. It would be very weird if the first statement in your file is an unrelated import...
Maybe we need to find the first statement that's not an import or an export with a module specifier?
There was a problem hiding this comment.
Not sure it matters - import "./thing" being the ref is probably just as odd as var x = 1. Point is really that the file itself is the reference, we just don't want to say "the whole file is the reference" because it'd be a really really big and useless usage highlight span.
weswigham
force-pushed
the
fix-implicit-jsx-refernce-crash
branch
from
07a6a54 to
86dab1d
Compare
typescript-bot
added
For Milestone Bug
| @@ -0,0 +1,38 @@ | |||
| // === findAllReferences === | |||
| // === /tests/cases/fourslash/project/src/foo.ts === | |||
| // [|<|import * as x from /*FIND ALL REFS*/"[|tslib|]";|]|> | |||
There was a problem hiding this comment.
Since we are already highlighting import do we really want first statement as well ?
There was a problem hiding this comment.
Yep - there's two references in this file, after all - the implicit one and the explicit one.
There was a problem hiding this comment.
Maybe there should be just one if the file already has an explicit import.
Fixes #51221