Skip to content

Avoid unnecessary buildInfo read if host supports caching it (avoids in --build scenario) and some reporting cleanup #51403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 5, 2022
Merged

Avoid unnecessary buildInfo read if host supports caching it (avoids in --build scenario) and some reporting cleanup #51403

merged 6 commits into from
Nov 5, 2022

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Nov 3, 2022 •
edited
Loading

Cherry picked cleanup and fixes from #50293
Basically not picking unnecessary additions to report buildInfo size and read/write times

  1. Fixes issue where earlier PR (Report aggregate statistics for solution as well as some solution perf numbers #50267) forgot to clear the aggregate diagnostics in watch mode after reporting
  2. When manipulating bundle because the d.ts file didnt change, use cached buildInfo instead of reading it again and parsing if available. (This was discovered as part of Report buildInfo size in extendedDiagnostics #50293 and we already do this when reading old program from buildInfo but not when manipulating bundle)

@sheetalkamat
Emit diagnostics when just manipuating bundle at that time itself
4286001 
[4:04:42 PM] Updating output of project '/TypeScript/src/tsserver/tsconfig.json'...

Memory used:        581215K
transformTime time:   0.01s
Source Map time:      0.35s
commentTime time:     0.00s
printTime time:       0.58s
Emit time:            0.90s
I/O Write time:       0.01s
Total time:           0.90s
@sheetalkamat
Pull out getSourceFile and writeFile in a function
adce020
@sheetalkamat
Fix incorrect solutionPerformance reporting in watch mode
8c72073
@sheetalkamat
Remove unnecessary build info read when host can give cached buildInfo
4b0eb14
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 3, 2022
jakebailey
jakebailey reviewed Nov 4, 2022
View reviewed changes
@sheetalkamat sheetalkamat merged commit 354891c into main Nov 5, 2022
@sheetalkamat sheetalkamat deleted the reportingCleanup branch November 5, 2022 02:19
@DanielRosenwasser DanielRosenwasser mentioned this pull request Nov 14, 2022
Closed
sheetalkamat added a commit that referenced this pull request Dec 2, 2022
@sheetalkamat
Revert #51403
99a9457
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey approved these changes

@amcasey amcasey Awaiting requested review from amcasey

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sheetalkamat @jakebailey @typescript-bot