Fix nightly post-#50528 merge #51432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
reviewed
Nov 7, 2022
| const left = column > 0 ? connectors[column - 1][lane] : 0; | ||
| const above = lane > 0 ? connectors[column][lane - 1] : 0; | ||
| let connector = connectors[column][lane]; | ||
| if (!connector) { |
Member
There was a problem hiding this comment.
I actually fixed this on the module branch another way, to add a None = 0 value to the enum instead, that way it's not never.
Member
There was a problem hiding this comment.
(Also thankfully post-modules I ensure all projects get checked, so we should catch these.)
Member
There was a problem hiding this comment.
Though, I think both aren't quite right anyhow given I think what this is checking is not 0, but undefined via out-of-bounds.
jakebailey
approved these changes
Nov 7, 2022
| const left = column > 0 ? connectors[column - 1][lane] : 0; | ||
| const above = lane > 0 ? connectors[column][lane - 1] : 0; | ||
| let connector = connectors[column][lane]; | ||
| if (!connector) { |
Member
There was a problem hiding this comment.
Though, I think both aren't quite right anyhow given I think what this is checking is not 0, but undefined via out-of-bounds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes our nightly publish, which requires a clean post-LKG build. Looks like #50528 missed an instance of enum narrowing behaviors changing a bit in our own codebase between when it was made and when it was merged.