-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Remove some files from the repo root #51446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot user test this I think this is the docker one? Maybe? |
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 01969f8. You can monitor the build here. Update: The results are in! |
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
@typescript-bot user test this slower |
Heya @jakebailey, I've started to run the community code test suite on this PR at 01969f8. You can monitor the build here. |
@typescript-bot user test this slower |
Heya @jakebailey, I've started to run the community code test suite on this PR at 01969f8. You can monitor the build here. |
The long user task appears to be broken, but that seems to be unrelated to this PR. I can confirm from the logs that the docker stuff works as expected: https://typescript.visualstudio.com/TypeScript/_build/results?buildId=139770&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=7cc137c2-61f2-5d65-b5f8-0e03d1af3170&l=1057
This is buildkit output, and it's finding the new paths for the dockerignore and Dockerfile correctly, so this change looks to be safe. |
Fixes #51444
The only potentially scary thing here is the docker change; it requires buildkit, but that should work so long as all of our images are Linux-based (which they are).
This removes 5 files from the repo root.