Skip to content

Remove no-unnecessary-qualifier from eslintrc #51456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Remove no-unnecessary-qualifier from eslintrc #51456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"project": "./tsconfig-base.json"
},
"rules": {
"@typescript-eslint/no-unnecessary-qualifier": "error",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
"no-restricted-globals": ["error",
{ "name": "setTimeout" },
Expand Down
2 changes: 0 additions & 2 deletions src/server/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ import {
TodoComment, TodoCommentDescriptor, TypeAcquisition,
} from "./_namespaces/ts";

/* eslint-disable @typescript-eslint/no-unnecessary-qualifier */

/**
* Declaration module describing the TypeScript Server protocol
*/
Expand Down
2 changes: 1 addition & 1 deletion src/testRunner/unittests/tsserver/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ export class TestServerEventManager {
configFileName: "tsconfig.json",
projectType: "configured",
languageServiceEnabled: true,
version: ts.version, // eslint-disable-line @typescript-eslint/no-unnecessary-qualifier
version: ts.version,
...partial,
});
}
Expand Down
2 changes: 1 addition & 1 deletion src/testRunner/unittests/tsserver/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ describe("unittests:: tsserver:: Session:: General functionality", () => {
};

const expected: ts.server.protocol.StatusResponseBody = {
version: ts.version, // eslint-disable-line @typescript-eslint/no-unnecessary-qualifier
version: ts.version,
};
assert.deepEqual(session.executeCommand(req).response, expected);
});
Expand Down
4 changes: 0 additions & 4 deletions src/typingsInstallerCore/typingsInstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,6 @@ export abstract class TypingsInstaller {
this.sendResponse({
kind: EventBeginInstallTypes,
eventId: requestId,
// qualified explicitly to prevent occasional shadowing
// eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier
typingsInstallerVersion: version,
projectName: req.projectName
} as BeginInstallTypes);
Expand Down Expand Up @@ -401,8 +399,6 @@ export abstract class TypingsInstaller {
projectName: req.projectName,
packagesToInstall: scopedTypings,
installSuccess: ok,
// qualified explicitly to prevent occasional shadowing
// eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier
typingsInstallerVersion: version
};
this.sendResponse(response);
Expand Down