Skip to content

Port of #51626 and #51689 to release-4.9 #51627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 30, 2022
Merged

Port of #51626 and #51689 to release-4.9 #51627

merged 4 commits into from
Nov 30, 2022

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Nov 22, 2022 •
edited
Loading

Porting #51626 and #51689 to release-4.9

@sheetalkamat
When fsEvent for change is repeated
0a01fcb
@sheetalkamat
When trying to check if program is uptodate, read the files from disk…
2de171b 
… to determine the version instead of delaying so that new program is not created if file contents have not changed
@sheetalkamat sheetalkamat changed the base branch from main to release-4.9 November 22, 2022 22:11
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 22, 2022
@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 22, 2022 •
edited
Loading

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 2de171b. You can monitor the build here.

@sheetalkamat sheetalkamat mentioned this pull request Nov 22, 2022
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 22, 2022 •
edited
Loading

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/139076/artifacts?artifactName=tgz&fileId=FDFEBFD7D88247CD31A298D36CE4CF4D755D0D11C7B30BA428B6AB3F1180113F02&fileName=/typescript-4.9.3-insiders.20221122.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.9.3-pr-51627-2".;

DanielRosenwasser
DanielRosenwasser reviewed Nov 29, 2022
View reviewed changes
@DanielRosenwasser
Copy link
Member

Apart from my comment, should this be taken out of draft state?

@sheetalkamat sheetalkamat mentioned this pull request Nov 29, 2022
Merged
@sheetalkamat sheetalkamat changed the title Port of #51626 to release-4.9 Port of #51626 and #51689 to release-4.9 Nov 29, 2022
@sheetalkamat sheetalkamat marked this pull request as ready for review November 29, 2022 23:33
@sheetalkamat sheetalkamat reopened this Nov 30, 2022
@sheetalkamat sheetalkamat merged commit e7a02f4 into release-4.9 Nov 30, 2022
@sheetalkamat sheetalkamat deleted the fileTextNoChange49 branch November 30, 2022 19:22
@cssecautomation cssecautomation mentioned this pull request May 16, 2023
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sheetalkamat @typescript-bot @DanielRosenwasser