Skip to content

Refactor wrapSymbolTrackerToReportForContext to improve perf #51788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor wrapSymbolTrackerToReportForContext to improve perf #51788

wants to merge 1 commit into from

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Dec 6, 2022

In the same vein as #51682, this refactors a function that was extremely polymorphic/megamorphic that seems to account for a significant percentage of emit time in some of our benchmarks.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 6, 2022
@rbuckton
Copy link
Contributor Author

rbuckton commented Dec 6, 2022

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 6, 2022 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at 9f8b104. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51788
Metric main 51788 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 341,078k (± 0.01%) 341,052k (± 0.02%) -26k (- 0.01%) 340,923k 341,154k
Parse Time 1.56s (± 0.95%) 1.58s (± 0.56%) +0.01s (+ 0.90%) 1.56s 1.59s
Bind Time 0.52s (± 0.57%) 0.53s (± 1.82%) +0.00s (+ 0.57%) 0.51s 0.56s
Check Time 4.02s (± 0.50%) 4.00s (± 0.73%) -0.02s (- 0.60%) 3.94s 4.08s
Emit Time 4.28s (± 1.04%) 4.29s (± 1.10%) +0.01s (+ 0.23%) 4.19s 4.38s
Total Time 10.38s (± 0.57%) 10.38s (± 0.61%) +0.00s (+ 0.02%) 10.27s 10.51s
Compiler-Unions - node (v18.10.0, x64)
Memory used 186,211k (± 0.89%) 187,350k (± 1.10%) +1,139k (+ 0.61%) 185,055k 190,794k
Parse Time 0.61s (± 0.85%) 0.61s (± 0.81%) +0.01s (+ 0.99%) 0.61s 0.63s
Bind Time 0.32s (± 1.05%) 0.33s (± 1.14%) +0.00s (+ 0.62%) 0.32s 0.33s
Check Time 5.04s (± 0.60%) 5.04s (± 0.69%) +0.01s (+ 0.18%) 4.95s 5.11s
Emit Time 1.56s (± 1.78%) 1.57s (± 1.22%) +0.01s (+ 0.51%) 1.53s 1.63s
Total Time 7.53s (± 0.45%) 7.55s (± 0.57%) +0.02s (+ 0.32%) 7.46s 7.66s
Monaco - node (v18.10.0, x64)
Memory used 320,461k (± 0.02%) 320,448k (± 0.02%) -13k (- 0.00%) 320,283k 320,608k
Parse Time 1.15s (± 1.19%) 1.15s (± 0.71%) -0.00s (- 0.26%) 1.13s 1.17s
Bind Time 0.49s (± 1.37%) 0.49s (± 1.06%) +0.00s (+ 0.82%) 0.48s 0.50s
Check Time 3.85s (± 0.71%) 3.80s (± 0.32%) -0.05s (- 1.25%) 3.77s 3.82s
Emit Time 2.25s (± 0.81%) 2.25s (± 1.20%) -0.00s (- 0.13%) 2.20s 2.33s
Total Time 7.74s (± 0.49%) 7.69s (± 0.51%) -0.05s (- 0.67%) 7.62s 7.80s
TFS - node (v18.10.0, x64)
Memory used 283,529k (± 0.24%) 283,099k (± 0.15%) -431k (- 0.15%) 282,825k 284,821k
Parse Time 0.94s (± 1.10%) 0.96s (± 1.89%) +0.02s (+ 2.34%) 0.94s 1.03s
Bind Time 0.44s (± 2.55%) 0.49s (± 8.59%) +0.04s (+ 9.98%) 0.43s 0.57s
Check Time 3.78s (± 0.52%) 3.53s (± 0.62%) 🟩-0.25s (- 6.53%) 3.49s 3.58s
Emit Time 2.20s (± 0.60%) 2.21s (± 0.92%) +0.01s (+ 0.45%) 2.17s 2.27s
Total Time 7.36s (± 0.36%) 7.19s (± 0.86%) -0.17s (- 2.31%) 7.07s 7.33s
material-ui - node (v18.10.0, x64)
Memory used 435,993k (± 0.02%) 435,994k (± 0.02%) +1k (+ 0.00%) 435,871k 436,135k
Parse Time 1.31s (± 0.72%) 1.32s (± 0.68%) +0.00s (+ 0.08%) 1.30s 1.34s
Bind Time 0.49s (± 0.74%) 0.49s (± 2.76%) -0.01s (- 1.82%) 0.45s 0.50s
Check Time 10.32s (± 1.35%) 10.22s (± 0.62%) -0.10s (- 0.96%) 10.11s 10.36s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.13s (± 1.22%) 12.02s (± 0.59%) -0.11s (- 0.87%) 11.90s 12.19s
xstate - node (v18.10.0, x64)
Memory used 518,432k (± 0.02%) 518,423k (± 0.01%) -9k (- 0.00%) 518,277k 518,587k
Parse Time 1.87s (± 0.35%) 1.88s (± 0.55%) +0.01s (+ 0.53%) 1.86s 1.90s
Bind Time 0.69s (± 2.45%) 0.70s (± 2.12%) +0.01s (+ 1.29%) 0.69s 0.76s
Check Time 1.04s (± 1.07%) 1.05s (± 0.85%) +0.00s (+ 0.10%) 1.03s 1.07s
Emit Time 0.05s (± 0.00%) 0.05s (± 0.00%) 0.00s ( 0.00%) 0.05s 0.05s
Total Time 3.67s (± 0.61%) 3.69s (± 0.50%) +0.02s (+ 0.52%) 3.65s 3.74s
Angular - node (v16.17.1, x64)
Memory used 340,521k (± 0.01%) 340,486k (± 0.02%) -35k (- 0.01%) 340,273k 340,576k
Parse Time 1.86s (± 0.77%) 1.88s (± 0.59%) +0.01s (+ 0.75%) 1.85s 1.90s
Bind Time 0.64s (± 0.53%) 0.65s (± 0.56%) +0.00s (+ 0.47%) 0.64s 0.65s
Check Time 5.16s (± 0.63%) 5.13s (± 0.50%) -0.02s (- 0.43%) 5.09s 5.19s
Emit Time 5.12s (± 0.74%) 5.14s (± 1.47%) +0.02s (+ 0.45%) 5.06s 5.42s
Total Time 12.78s (± 0.55%) 12.80s (± 0.82%) +0.02s (+ 0.15%) 12.66s 13.16s
Compiler-Unions - node (v16.17.1, x64)
Memory used 187,657k (± 0.59%) 187,280k (± 0.52%) -377k (- 0.20%) 186,579k 189,896k
Parse Time 0.79s (± 0.87%) 0.80s (± 0.77%) +0.01s (+ 1.65%) 0.79s 0.81s
Bind Time 0.42s (± 1.18%) 0.42s (± 0.95%) +0.00s (+ 0.72%) 0.41s 0.43s
Check Time 6.06s (± 0.50%) 6.04s (± 0.37%) -0.02s (- 0.25%) 6.00s 6.11s
Emit Time 1.94s (± 0.72%) 1.95s (± 1.26%) +0.02s (+ 0.88%) 1.90s 2.03s
Total Time 9.20s (± 0.42%) 9.21s (± 0.39%) +0.01s (+ 0.15%) 9.15s 9.33s
Monaco - node (v16.17.1, x64)
Memory used 319,781k (± 0.02%) 319,757k (± 0.01%) -25k (- 0.01%) 319,695k 319,838k
Parse Time 1.40s (± 0.92%) 1.42s (± 0.57%) +0.02s (+ 1.65%) 1.41s 1.44s
Bind Time 0.59s (± 0.98%) 0.59s (± 0.57%) -0.00s (- 0.00%) 0.59s 0.60s
Check Time 4.87s (± 0.79%) 4.84s (± 0.35%) -0.03s (- 0.66%) 4.80s 4.88s
Emit Time 2.74s (± 1.24%) 2.74s (± 0.55%) -0.00s (- 0.15%) 2.70s 2.77s
Total Time 9.61s (± 0.67%) 9.59s (± 0.34%) -0.02s (- 0.17%) 9.53s 9.65s
TFS - node (v16.17.1, x64)
Memory used 282,262k (± 0.02%) 282,257k (± 0.02%) -5k (- 0.00%) 282,081k 282,313k
Parse Time 1.16s (± 1.34%) 1.16s (± 0.93%) -0.00s (- 0.09%) 1.13s 1.18s
Bind Time 0.63s (± 5.62%) 0.65s (± 4.38%) +0.02s (+ 3.82%) 0.57s 0.70s
Check Time 4.75s (± 0.61%) 4.52s (± 0.40%) 🟩-0.23s (- 4.87%) 4.46s 4.54s
Emit Time 2.79s (± 1.88%) 2.77s (± 1.92%) -0.02s (- 0.82%) 2.67s 2.88s
Total Time 9.33s (± 0.57%) 9.10s (± 0.72%) -0.23s (- 2.46%) 8.94s 9.21s
material-ui - node (v16.17.1, x64)
Memory used 435,303k (± 0.00%) 435,311k (± 0.01%) +8k (+ 0.00%) 435,259k 435,357k
Parse Time 1.61s (± 0.28%) 1.64s (± 0.58%) +0.02s (+ 1.43%) 1.61s 1.65s
Bind Time 0.50s (± 0.74%) 0.51s (± 0.67%) +0.00s (+ 0.40%) 0.50s 0.51s
Check Time 11.77s (± 0.62%) 11.84s (± 0.70%) +0.07s (+ 0.63%) 11.64s 12.02s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.89s (± 0.51%) 13.98s (± 0.61%) +0.10s (+ 0.71%) 13.79s 14.18s
xstate - node (v16.17.1, x64)
Memory used 515,998k (± 0.01%) 515,978k (± 0.01%) -21k (- 0.00%) 515,836k 516,158k
Parse Time 2.25s (± 0.26%) 2.26s (± 0.54%) +0.01s (+ 0.27%) 2.23s 2.29s
Bind Time 0.82s (± 1.17%) 0.82s (± 0.81%) +0.01s (+ 0.86%) 0.81s 0.84s
Check Time 1.35s (± 0.60%) 1.36s (± 0.77%) +0.01s (+ 0.59%) 1.34s 1.38s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.49s (± 0.29%) 4.51s (± 0.33%) +0.02s (+ 0.36%) 4.48s 4.54s
Angular - node (v14.15.1, x64)
Memory used 333,987k (± 0.00%) 333,975k (± 0.01%) -12k (- 0.00%) 333,927k 334,030k
Parse Time 2.03s (± 0.33%) 2.04s (± 0.60%) +0.01s (+ 0.44%) 2.02s 2.07s
Bind Time 0.70s (± 0.68%) 0.70s (± 0.67%) +0.00s (+ 0.43%) 0.69s 0.71s
Check Time 5.50s (± 0.70%) 5.50s (± 0.58%) -0.00s (- 0.02%) 5.44s 5.57s
Emit Time 5.34s (± 0.63%) 5.33s (± 0.49%) -0.01s (- 0.17%) 5.27s 5.39s
Total Time 13.57s (± 0.45%) 13.56s (± 0.41%) -0.00s (- 0.02%) 13.46s 13.72s
Compiler-Unions - node (v14.15.1, x64)
Memory used 183,361k (± 0.68%) 182,248k (± 0.57%) -1,113k (- 0.61%) 181,050k 185,080k
Parse Time 0.89s (± 0.63%) 0.90s (± 1.24%) +0.01s (+ 0.90%) 0.88s 0.93s
Bind Time 0.45s (± 0.75%) 0.45s (± 0.66%) -0.00s (- 0.22%) 0.45s 0.46s
Check Time 6.34s (± 0.50%) 6.39s (± 0.70%) +0.05s (+ 0.77%) 6.28s 6.46s
Emit Time 2.04s (± 0.57%) 2.08s (± 1.04%) +0.04s (+ 1.81%) 2.05s 2.15s
Total Time 9.72s (± 0.42%) 9.82s (± 0.53%) +0.10s (+ 1.00%) 9.68s 9.90s
Monaco - node (v14.15.1, x64)
Memory used 314,583k (± 0.01%) 314,578k (± 0.01%) -4k (- 0.00%) 314,535k 314,659k
Parse Time 1.55s (± 0.68%) 1.56s (± 0.64%) +0.01s (+ 0.71%) 1.54s 1.59s
Bind Time 0.63s (± 0.94%) 0.63s (± 0.71%) -0.00s (- 0.32%) 0.62s 0.64s
Check Time 5.19s (± 0.48%) 5.16s (± 0.46%) -0.03s (- 0.60%) 5.09s 5.20s
Emit Time 2.91s (± 0.78%) 2.87s (± 0.96%) -0.03s (- 1.17%) 2.80s 2.94s
Total Time 10.28s (± 0.48%) 10.23s (± 0.39%) -0.05s (- 0.53%) 10.15s 10.32s
TFS - node (v14.15.1, x64)
Memory used 279,370k (± 0.01%) 279,365k (± 0.01%) -5k (- 0.00%) 279,307k 279,426k
Parse Time 1.33s (± 0.98%) 1.33s (± 0.62%) +0.01s (+ 0.68%) 1.32s 1.35s
Bind Time 0.59s (± 0.62%) 0.59s (± 0.76%) +0.00s (+ 0.34%) 0.58s 0.60s
Check Time 5.10s (± 0.40%) 4.82s (± 0.43%) 🟩-0.27s (- 5.37%) 4.79s 4.90s
Emit Time 3.08s (± 0.64%) 3.06s (± 0.47%) -0.01s (- 0.42%) 3.03s 3.10s
Total Time 10.08s (± 0.21%) 9.81s (± 0.33%) -0.27s (- 2.69%) 9.76s 9.92s
material-ui - node (v14.15.1, x64)
Memory used 430,756k (± 0.01%) 430,753k (± 0.01%) -4k (- 0.00%) 430,693k 430,810k
Parse Time 1.86s (± 0.50%) 1.86s (± 0.49%) +0.00s (+ 0.16%) 1.85s 1.89s
Bind Time 0.53s (± 0.76%) 0.53s (± 0.90%) -0.00s (- 0.38%) 0.52s 0.54s
Check Time 12.25s (± 0.60%) 12.14s (± 0.57%) -0.11s (- 0.92%) 11.97s 12.35s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.64s (± 0.49%) 14.53s (± 0.51%) -0.11s (- 0.78%) 14.34s 14.75s
xstate - node (v14.15.1, x64)
Memory used 504,406k (± 0.00%) 504,332k (± 0.01%) -74k (- 0.01%) 504,185k 504,405k
Parse Time 2.54s (± 0.33%) 2.55s (± 0.53%) +0.01s (+ 0.51%) 2.52s 2.58s
Bind Time 0.83s (± 0.41%) 0.84s (± 0.66%) +0.01s (+ 1.08%) 0.83s 0.86s
Check Time 1.48s (± 0.71%) 1.47s (± 0.41%) -0.02s (- 1.15%) 1.46s 1.48s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 4.93s (± 0.25%) 4.93s (± 0.40%) +0.01s (+ 0.12%) 4.90s 4.98s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51788 10
Baseline main 10

TSServer

Comparison Report - main..51788
Metric main 51788 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,048ms (± 0.74%) 1,044ms (± 0.91%) -4ms (- 0.42%) 1,029ms 1,074ms
Req 2 - geterr 2,565ms (± 0.46%) 2,568ms (± 0.42%) +3ms (+ 0.11%) 2,540ms 2,592ms
Req 3 - references 165ms (± 0.34%) 165ms (± 0.69%) 0ms ( 0.00%) 163ms 168ms
Req 4 - navto 137ms (± 0.57%) 137ms (± 0.77%) +0ms (+ 0.07%) 135ms 140ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 60ms (± 2.17%) 60ms (± 1.92%) +1ms (+ 1.34%) 57ms 62ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,100ms (± 0.44%) 1,106ms (± 0.65%) +6ms (+ 0.50%) 1,084ms 1,121ms
Req 2 - geterr 1,600ms (± 0.95%) 1,603ms (± 0.69%) +4ms (+ 0.24%) 1,584ms 1,632ms
Req 3 - references 167ms (± 0.50%) 168ms (± 0.67%) +1ms (+ 0.60%) 166ms 171ms
Req 4 - navto 150ms (± 0.60%) 151ms (± 0.94%) +1ms (+ 0.67%) 148ms 154ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 52ms (± 1.70%) 52ms (± 1.70%) 0ms ( 0.00%) 51ms 55ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,493ms (± 0.37%) 1,504ms (± 0.72%) +11ms (+ 0.72%) 1,483ms 1,536ms
Req 2 - geterr 553ms (± 0.48%) 558ms (± 0.58%) +5ms (+ 0.94%) 551ms 566ms
Req 3 - references 58ms (± 1.67%) 59ms (± 2.45%) +1ms (+ 1.90%) 57ms 62ms
Req 4 - navto 195ms (± 0.37%) 196ms (± 1.00%) +1ms (+ 0.61%) 193ms 201ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 212ms (± 0.94%) 213ms (± 1.40%) +1ms (+ 0.61%) 206ms 219ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,286ms (± 0.36%) 1,304ms (± 0.64%) +18ms (+ 1.36%) 1,290ms 1,329ms
Req 2 - geterr 3,177ms (± 0.61%) 3,205ms (± 0.70%) +29ms (+ 0.90%) 3,164ms 3,256ms
Req 3 - references 190ms (± 0.76%) 192ms (± 1.00%) +2ms (+ 0.89%) 187ms 195ms
Req 4 - navto 149ms (± 0.91%) 150ms (± 0.40%) +1ms (+ 0.80%) 149ms 152ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 60ms (± 2.28%) 60ms (± 2.19%) +0ms (+ 0.67%) 57ms 63ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,382ms (± 0.56%) 1,379ms (± 0.70%) -3ms (- 0.20%) 1,360ms 1,402ms
Req 2 - geterr 2,104ms (± 0.73%) 2,105ms (± 0.50%) +1ms (+ 0.06%) 2,087ms 2,130ms
Req 3 - references 197ms (± 0.51%) 198ms (± 0.72%) +1ms (+ 0.41%) 194ms 201ms
Req 4 - navto 165ms (± 1.03%) 164ms (± 1.27%) -1ms (- 0.55%) 159ms 168ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 55ms (± 2.02%) 55ms (± 1.01%) +0ms (+ 0.18%) 54ms 56ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,804ms (± 0.37%) 1,806ms (± 0.56%) +3ms (+ 0.14%) 1,784ms 1,832ms
Req 2 - geterr 715ms (± 0.54%) 720ms (± 0.70%) +4ms (+ 0.60%) 706ms 729ms
Req 3 - references 66ms (± 1.03%) 67ms (± 1.43%) +0ms (+ 0.30%) 65ms 68ms
Req 4 - navto 196ms (± 0.50%) 198ms (± 1.08%) +2ms (+ 0.92%) 194ms 203ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 252ms (± 0.49%) 255ms (± 0.96%) +3ms (+ 1.07%) 251ms 262ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,443ms (± 0.35%) 1,452ms (± 0.54%) +9ms (+ 0.65%) 1,431ms 1,466ms
Req 2 - geterr 3,431ms (± 0.49%) 3,434ms (± 0.40%) +4ms (+ 0.11%) 3,411ms 3,468ms
Req 3 - references 205ms (± 0.47%) 205ms (± 0.81%) +0ms (+ 0.05%) 201ms 208ms
Req 4 - navto 162ms (± 0.70%) 163ms (± 0.95%) +1ms (+ 0.37%) 160ms 167ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 57ms (± 1.08%) 58ms (± 2.53%) +1ms (+ 1.23%) 56ms 63ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,521ms (± 0.41%) 1,528ms (± 0.45%) +7ms (+ 0.43%) 1,516ms 1,541ms
Req 2 - geterr 2,287ms (± 0.44%) 2,297ms (± 0.47%) +10ms (+ 0.42%) 2,268ms 2,316ms
Req 3 - references 218ms (± 1.20%) 216ms (± 0.66%) -2ms (- 1.01%) 213ms 219ms
Req 4 - navto 173ms (± 0.77%) 174ms (± 0.88%) +2ms (+ 1.04%) 170ms 177ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 56ms (± 0.89%) 56ms (± 1.20%) +0ms (+ 0.18%) 55ms 58ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,984ms (± 0.31%) 1,993ms (± 0.28%) +10ms (+ 0.49%) 1,984ms 2,004ms
Req 2 - geterr 745ms (± 0.30%) 746ms (± 0.44%) +1ms (+ 0.12%) 741ms 752ms
Req 3 - references 72ms (± 1.06%) 72ms (± 1.17%) +1ms (+ 0.70%) 71ms 75ms
Req 4 - navto 219ms (± 0.86%) 219ms (± 0.58%) +0ms (+ 0.09%) 217ms 222ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 270ms (± 0.86%) 269ms (± 0.70%) -1ms (- 0.37%) 265ms 275ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51788 10
Baseline main 10

Startup

Comparison Report - main..51788
Metric main 51788 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 119.27ms (± 0.54%) 117.73ms (± 0.37%) -1.54ms (- 1.29%) 115.63ms 125.05ms
tsserver-startup - node (v16.17.1, x64)
Execution time 199.19ms (± 0.47%) 198.06ms (± 0.27%) -1.13ms (- 0.57%) 194.94ms 204.88ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 193.42ms (± 0.40%) 192.36ms (± 0.29%) -1.06ms (- 0.55%) 189.48ms 200.65ms
typescript-startup - node (v16.17.1, x64)
Execution time 178.18ms (± 0.41%) 177.86ms (± 0.37%) -0.32ms (- 0.18%) 174.90ms 186.57ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51788 10
Baseline main 10

Developer Information:

Download Benchmark

@rbuckton rbuckton mentioned this pull request Dec 7, 2022
Merged
@rbuckton
Copy link
Contributor Author

rbuckton commented Dec 7, 2022 •
edited
Loading

I merged this into #51682 while testing for knock-on effects from the two changes. I'm going to close this PR in favor of the combined version in #51682.

@rbuckton rbuckton closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbuckton rbuckton

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbuckton @typescript-bot