Skip to content

Reduce instance size of Identifier #52175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Reduce instance size of Identifier #52175

wants to merge 1 commit into from

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Jan 9, 2023

Testing a much smaller change than #52170.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 9, 2023
@rbuckton
Copy link
Member Author

rbuckton commented Jan 9, 2023

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2023

Heya @rbuckton, I've started to run the perf test suite on this PR at bb5edf1. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52175
Metric main 52175 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 372,650k (± 0.01%) 382,421k (± 0.01%) +9,771k (+ 2.62%) 382,353k 382,505k
Parse Time 3.94s (± 0.68%) 3.99s (± 0.86%) +0.05s (+ 1.27%) 3.94s 4.04s
Bind Time 1.20s (± 0.73%) 1.21s (± 0.85%) +0.01s (+ 1.10%) 1.20s 1.23s
Check Time 8.60s (± 0.76%) 8.62s (± 0.34%) +0.02s (+ 0.18%) 8.59s 8.66s
Emit Time 7.53s (± 0.94%) 7.54s (± 0.36%) +0.00s (+ 0.06%) 7.48s 7.56s
Total Time 21.27s (± 0.56%) 21.35s (± 0.27%) +0.08s (+ 0.36%) 21.27s 21.43s
Compiler-Unions - node (v18.10.0, x64)
Memory used 198,370k (± 0.03%) 205,458k (± 1.43%) +7,089k (+ 3.57%) 203,499k 209,363k
Parse Time 1.64s (± 1.25%) 1.68s (± 1.04%) +0.04s (+ 2.29%) 1.65s 1.69s
Bind Time 0.79s (± 0.69%) 0.79s (± 0.64%) +0.00s (+ 0.59%) 0.79s 0.80s
Check Time 9.41s (± 0.88%) 9.59s (± 0.37%) +0.18s (+ 1.93%) 9.54s 9.64s
Emit Time 2.78s (± 1.57%) 2.78s (± 1.22%) -0.00s (- 0.08%) 2.73s 2.83s
Total Time 14.62s (± 0.47%) 14.84s (± 0.46%) +0.22s (+ 1.51%) 14.75s 14.92s
Monaco - node (v18.10.0, x64)
Memory used 354,100k (± 0.01%) 362,933k (± 0.01%) +8,833k (+ 2.49%) 362,879k 362,986k
Parse Time 2.93s (± 0.81%) 3.00s (± 0.97%) +0.07s (+ 2.40%) 2.96s 3.04s
Bind Time 1.04s (± 1.11%) 1.05s (± 1.16%) +0.02s (+ 1.51%) 1.04s 1.07s
Check Time 7.21s (± 0.39%) 7.21s (± 0.24%) -0.00s (- 0.05%) 7.19s 7.24s
Emit Time 4.27s (± 0.60%) 4.29s (± 0.77%) +0.02s (+ 0.53%) 4.24s 4.34s
Total Time 15.44s (± 0.32%) 15.55s (± 0.33%) +0.11s (+ 0.69%) 15.49s 15.63s
TFS - node (v18.10.0, x64)
Memory used 310,027k (± 0.00%) 318,901k (± 0.01%) +8,874k (+ 2.86%) 318,879k 318,932k
Parse Time 2.27s (± 0.48%) 2.46s (± 1.67%) +0.20s (+ 8.68%) 2.41s 2.52s
Bind Time 1.16s (± 1.28%) 0.99s (± 1.37%) 🟩-0.17s (-14.63%) 0.98s 1.02s
Check Time 6.82s (± 0.55%) 6.81s (± 0.62%) -0.01s (- 0.14%) 6.74s 6.87s
Emit Time 3.93s (± 0.91%) 3.96s (± 0.87%) +0.03s (+ 0.69%) 3.91s 4.00s
Total Time 14.19s (± 0.52%) 14.22s (± 0.54%) +0.04s (+ 0.28%) 14.12s 14.34s
material-ui - node (v18.10.0, x64)
Memory used 485,241k (± 0.01%) 491,718k (± 0.02%) +6,477k (+ 1.33%) 491,663k 491,892k
Parse Time 3.53s (± 0.24%) 3.57s (± 0.61%) +0.04s (+ 1.11%) 3.55s 3.60s
Bind Time 0.96s (± 0.21%) 0.97s (± 1.37%) +0.02s (+ 1.84%) 0.96s 0.99s
Check Time 16.89s (± 0.45%) 17.03s (± 1.65%) +0.15s (+ 0.86%) 16.80s 17.57s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.38s (± 0.36%) 21.58s (± 1.33%) +0.21s (+ 0.96%) 21.36s 22.13s
xstate - node (v18.10.0, x64)
Memory used 570,291k (± 0.02%) 586,399k (± 0.02%) +16,108k (+ 2.82%) 586,251k 586,576k
Parse Time 4.41s (± 0.72%) 4.65s (± 2.13%) +0.24s (+ 5.33%) 4.49s 4.75s
Bind Time 1.70s (± 0.97%) 1.53s (± 5.30%) 🟩-0.17s (- 9.85%) 1.44s 1.63s
Check Time 2.60s (± 1.19%) 2.58s (± 0.58%) -0.01s (- 0.48%) 2.56s 2.60s
Emit Time 0.08s (± 0.23%) 0.08s (± 0.18%) +0.00s (+ 0.03%) 0.08s 0.08s
Total Time 8.79s (± 0.53%) 8.85s (± 0.37%) +0.06s (+ 0.67%) 8.80s 8.90s
Angular - node (v16.17.1, x64)
Memory used 372,020k (± 0.01%) 381,792k (± 0.01%) +9,773k (+ 2.63%) 381,768k 381,838k
Parse Time 4.13s (± 0.41%) 4.18s (± 0.22%) +0.06s (+ 1.38%) 4.17s 4.19s
Bind Time 1.26s (± 1.06%) 1.26s (± 0.66%) +0.00s (+ 0.27%) 1.25s 1.28s
Check Time 9.31s (± 0.28%) 9.28s (± 0.36%) -0.03s (- 0.31%) 9.24s 9.34s
Emit Time 7.97s (± 0.23%) 7.99s (± 0.42%) +0.02s (+ 0.28%) 7.94s 8.03s
Total Time 22.67s (± 0.20%) 22.72s (± 0.21%) +0.05s (+ 0.23%) 22.67s 22.78s
Compiler-Unions - node (v16.17.1, x64)
Memory used 199,986k (± 0.03%) 205,248k (± 0.05%) +5,261k (+ 2.63%) 205,177k 205,460k
Parse Time 1.79s (± 1.77%) 1.84s (± 0.90%) +0.05s (+ 2.80%) 1.81s 1.85s
Bind Time 0.84s (± 0.86%) 0.84s (± 0.37%) +0.00s (+ 0.20%) 0.84s 0.84s
Check Time 10.04s (± 0.54%) 10.05s (± 0.38%) +0.01s (+ 0.05%) 10.00s 10.11s
Emit Time 3.00s (± 1.15%) 2.99s (± 0.66%) -0.01s (- 0.25%) 2.96s 3.02s
Total Time 15.66s (± 0.70%) 15.72s (± 0.34%) +0.05s (+ 0.34%) 15.68s 15.82s
Monaco - node (v16.17.1, x64)
Memory used 353,429k (± 0.01%) 362,255k (± 0.01%) +8,826k (+ 2.50%) 362,215k 362,321k
Parse Time 3.16s (± 0.66%) 3.20s (± 0.99%) +0.03s (+ 1.06%) 3.17s 3.24s
Bind Time 1.12s (± 0.95%) 1.13s (± 0.84%) +0.01s (+ 1.16%) 1.12s 1.14s
Check Time 7.83s (± 0.36%) 7.89s (± 0.38%) +0.05s (+ 0.69%) 7.85s 7.94s
Emit Time 4.50s (± 0.32%) 4.50s (± 0.20%) +0.00s (+ 0.01%) 4.49s 4.51s
Total Time 16.62s (± 0.25%) 16.72s (± 0.22%) +0.10s (+ 0.61%) 16.67s 16.76s
TFS - node (v16.17.1, x64)
Memory used 309,369k (± 0.00%) 318,248k (± 0.00%) +8,879k (+ 2.87%) 318,225k 318,261k
Parse Time 2.63s (± 0.89%) 2.71s (± 0.60%) +0.08s (+ 3.07%) 2.68s 2.73s
Bind Time 1.05s (± 0.85%) 1.05s (± 0.85%) +0.00s (+ 0.19%) 1.04s 1.07s
Check Time 7.42s (± 0.97%) 7.41s (± 0.44%) -0.01s (- 0.08%) 7.37s 7.44s
Emit Time 4.25s (± 1.43%) 4.24s (± 0.59%) -0.01s (- 0.28%) 4.20s 4.27s
Total Time 15.35s (± 0.94%) 15.41s (± 0.45%) +0.07s (+ 0.42%) 15.34s 15.53s
material-ui - node (v16.17.1, x64)
Memory used 484,511k (± 0.01%) 491,050k (± 0.02%) +6,539k (+ 1.35%) 490,983k 491,182k
Parse Time 3.67s (± 0.34%) 3.73s (± 0.29%) +0.06s (+ 1.67%) 3.71s 3.74s
Bind Time 1.02s (± 0.98%) 1.01s (± 0.70%) -0.01s (- 0.98%) 1.00s 1.02s
Check Time 17.88s (± 0.74%) 17.83s (± 0.13%) -0.05s (- 0.30%) 17.79s 17.86s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.57s (± 0.56%) 22.57s (± 0.10%) -0.00s (- 0.01%) 22.54s 22.59s
xstate - node (v16.17.1, x64)
Memory used 567,872k (± 0.02%) 583,975k (± 0.01%) +16,102k (+ 2.84%) 583,899k 584,090k
Parse Time 4.74s (± 0.30%) 4.89s (± 1.11%) +0.15s (+ 3.22%) 4.82s 4.97s
Bind Time 1.65s (± 0.52%) 1.54s (± 3.43%) 🟩-0.11s (- 6.56%) 1.49s 1.62s
Check Time 2.83s (± 0.38%) 2.83s (± 0.32%) +0.00s (+ 0.01%) 2.82s 2.84s
Emit Time 0.09s (± 0.18%) 0.09s (± 0.24%) +0.00s (+ 0.07%) 0.09s 0.09s
Total Time 9.32s (± 0.28%) 9.36s (± 0.47%) +0.04s (+ 0.46%) 9.31s 9.43s
Angular - node (v14.15.1, x64)
Memory used 365,688k (± 0.01%) 375,447k (± 0.01%) +9,760k (+ 2.67%) 375,420k 375,483k
Parse Time 4.16s (± 0.53%) 4.21s (± 0.59%) +0.05s (+ 1.19%) 4.18s 4.25s
Bind Time 1.30s (± 0.77%) 1.30s (± 1.42%) -0.00s (- 0.19%) 1.27s 1.32s
Check Time 9.68s (± 0.36%) 9.61s (± 0.25%) -0.07s (- 0.72%) 9.59s 9.66s
Emit Time 8.22s (± 1.08%) 8.19s (± 0.43%) -0.02s (- 0.26%) 8.13s 8.22s
Total Time 23.35s (± 0.57%) 23.31s (± 0.27%) -0.05s (- 0.20%) 23.21s 23.37s
Compiler-Unions - node (v14.15.1, x64)
Memory used 195,180k (± 0.01%) 200,420k (± 0.02%) +5,240k (+ 2.68%) 200,375k 200,482k
Parse Time 1.85s (± 0.37%) 1.87s (± 0.14%) +0.03s (+ 1.39%) 1.87s 1.88s
Bind Time 0.87s (± 0.45%) 0.88s (± 0.48%) +0.01s (+ 0.90%) 0.87s 0.88s
Check Time 10.13s (± 0.66%) 10.19s (± 0.67%) +0.06s (+ 0.59%) 10.09s 10.26s
Emit Time 3.14s (± 0.83%) 3.13s (± 0.51%) -0.01s (- 0.34%) 3.11s 3.15s
Total Time 15.99s (± 0.35%) 16.07s (± 0.53%) +0.08s (+ 0.51%) 15.96s 16.15s
Monaco - node (v14.15.1, x64)
Memory used 348,250k (± 0.00%) 357,098k (± 0.01%) +8,848k (+ 2.54%) 357,062k 357,133k
Parse Time 3.22s (± 1.09%) 3.31s (± 1.12%) +0.09s (+ 2.82%) 3.24s 3.35s
Bind Time 1.12s (± 0.58%) 1.13s (± 0.76%) +0.01s (+ 1.12%) 1.12s 1.14s
Check Time 8.16s (± 0.51%) 8.12s (± 0.42%) -0.04s (- 0.53%) 8.09s 8.18s
Emit Time 4.70s (± 0.44%) 4.71s (± 0.37%) +0.02s (+ 0.32%) 4.69s 4.74s
Total Time 17.20s (± 0.41%) 17.28s (± 0.36%) +0.08s (+ 0.46%) 17.18s 17.36s
TFS - node (v14.15.1, x64)
Memory used 304,285k (± 0.00%) 313,196k (± 0.01%) +8,911k (+ 2.93%) 313,181k 313,219k
Parse Time 2.71s (± 1.44%) 2.79s (± 0.87%) +0.08s (+ 2.83%) 2.76s 2.82s
Bind Time 1.08s (± 0.43%) 1.11s (± 1.37%) +0.03s (+ 2.69%) 1.09s 1.13s
Check Time 7.73s (± 0.45%) 7.70s (± 0.39%) -0.03s (- 0.34%) 7.68s 7.75s
Emit Time 4.63s (± 0.65%) 4.62s (± 1.86%) -0.01s (- 0.12%) 4.52s 4.73s
Total Time 16.15s (± 0.56%) 16.22s (± 0.65%) +0.07s (+ 0.42%) 16.09s 16.36s
material-ui - node (v14.15.1, x64)
Memory used 479,979k (± 0.00%) 486,517k (± 0.00%) +6,538k (+ 1.36%) 486,497k 486,550k
Parse Time 3.90s (± 0.68%) 3.94s (± 0.63%) +0.04s (+ 1.13%) 3.91s 3.98s
Bind Time 1.05s (± 0.40%) 1.04s (± 0.89%) -0.00s (- 0.41%) 1.04s 1.06s
Check Time 18.87s (± 0.37%) 18.92s (± 0.42%) +0.05s (+ 0.24%) 18.79s 19.01s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 23.82s (± 0.42%) 23.91s (± 0.40%) +0.09s (+ 0.37%) 23.78s 24.03s
xstate - node (v14.15.1, x64)
Memory used 556,211k (± 0.01%) 572,430k (± 0.00%) +16,219k (+ 2.92%) 572,400k 572,443k
Parse Time 5.11s (± 0.58%) 5.18s (± 0.46%) +0.06s (+ 1.27%) 5.14s 5.21s
Bind Time 1.58s (± 0.57%) 1.59s (± 0.51%) +0.01s (+ 0.63%) 1.58s 1.60s
Check Time 2.99s (± 0.43%) 3.00s (± 0.74%) +0.01s (+ 0.28%) 2.97s 3.03s
Emit Time 0.10s (± 0.16%) 0.10s (± 0.16%) +0.00s (+ 0.00%) 0.10s 0.10s
Total Time 9.78s (± 0.47%) 9.87s (± 0.17%) +0.08s (+ 0.87%) 9.85s 9.89s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52175 6
Baseline main 6

TSServer

Comparison Report - main..52175
Metric main 52175 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,570ms (± 1.01%) 2,549ms (± 1.76%) -20ms (- 0.79%) 2,475ms 2,597ms
Req 2 - geterr 5,334ms (± 1.05%) 5,355ms (± 0.74%) +21ms (+ 0.39%) 5,311ms 5,414ms
Req 3 - references 374ms (± 1.13%) 374ms (± 2.27%) +0ms (+ 0.12%) 368ms 390ms
Req 4 - navto 278ms (± 0.85%) 284ms (± 2.75%) +6ms (+ 2.12%) 277ms 297ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 307ms (± 1.38%) 304ms (± 1.93%) -4ms (- 1.14%) 294ms 310ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,784ms (± 0.81%) 2,787ms (± 0.74%) +3ms (+ 0.12%) 2,763ms 2,820ms
Req 2 - geterr 3,968ms (± 0.39%) 3,978ms (± 1.03%) +10ms (+ 0.24%) 3,938ms 4,033ms
Req 3 - references 360ms (± 0.83%) 363ms (± 0.51%) +3ms (+ 0.83%) 361ms 367ms
Req 4 - navto 291ms (± 1.60%) 292ms (± 0.36%) +1ms (+ 0.29%) 291ms 294ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 67ms (± 2.57%) 70ms (± 4.98%) +3ms (+ 5.17%) 66ms 74ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,371ms (± 0.46%) 3,401ms (± 0.41%) +30ms (+ 0.88%) 3,386ms 3,421ms
Req 2 - geterr 1,538ms (± 1.25%) 1,543ms (± 1.83%) +5ms (+ 0.31%) 1,525ms 1,599ms
Req 3 - references 104ms (± 2.76%) 105ms (± 3.06%) +1ms (+ 0.84%) 99ms 108ms
Req 4 - navto 362ms (± 2.45%) 360ms (± 1.41%) -1ms (- 0.35%) 351ms 365ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 424ms (± 2.14%) 427ms (± 1.36%) +4ms (+ 0.86%) 422ms 439ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,787ms (± 0.31%) 2,786ms (± 0.59%) -1ms (- 0.04%) 2,761ms 2,804ms
Req 2 - geterr 5,941ms (± 1.84%) 5,977ms (± 0.66%) +36ms (+ 0.60%) 5,919ms 6,043ms
Req 3 - references 362ms (± 0.42%) 362ms (± 0.70%) +0ms (+ 0.05%) 359ms 366ms
Req 4 - navto 318ms (±27.22%) 283ms (± 1.41%) 🟩-35ms (-11.13%) 279ms 290ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 93ms (± 6.44%) 92ms (± 3.19%) -2ms (- 1.81%) 88ms 95ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,917ms (± 0.70%) 2,911ms (± 0.93%) -7ms (- 0.23%) 2,868ms 2,940ms
Req 2 - geterr 4,308ms (± 0.48%) 4,283ms (± 0.50%) -25ms (- 0.59%) 4,250ms 4,311ms
Req 3 - references 376ms (± 0.76%) 376ms (± 0.75%) -0ms (- 0.09%) 373ms 380ms
Req 4 - navto 300ms (± 0.72%) 301ms (± 0.48%) +1ms (+ 0.24%) 299ms 303ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 237ms (±52.70%) 316ms (± 1.99%) 🔻+79ms (+33.52%) 307ms 325ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,755ms (± 0.54%) 3,756ms (± 0.27%) +1ms (+ 0.02%) 3,744ms 3,769ms
Req 2 - geterr 1,450ms (± 1.52%) 1,448ms (± 0.81%) -2ms (- 0.15%) 1,428ms 1,462ms
Req 3 - references 112ms (± 2.14%) 109ms (± 3.09%) 🟩-3ms (- 3.09%) 105ms 113ms
Req 4 - navto 347ms (± 0.50%) 349ms (± 1.60%) +2ms (+ 0.51%) 343ms 359ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 470ms (± 1.37%) 462ms (± 2.36%) -8ms (- 1.72%) 451ms 478ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,883ms (± 0.37%) 2,879ms (± 0.39%) -4ms (- 0.13%) 2,868ms 2,893ms
Req 2 - geterr 6,130ms (± 0.41%) 6,145ms (± 0.81%) +15ms (+ 0.25%) 6,080ms 6,210ms
Req 3 - references 378ms (± 0.64%) 376ms (± 0.36%) -1ms (- 0.33%) 375ms 378ms
Req 4 - navto 290ms (± 0.32%) 292ms (± 0.71%) +1ms (+ 0.37%) 288ms 294ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 125ms (±79.16%) 91ms (± 5.12%) 🟩-34ms (-27.42%) 86ms 97ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,025ms (± 0.45%) 3,007ms (± 0.62%) -19ms (- 0.62%) 2,982ms 3,029ms
Req 2 - geterr 4,585ms (± 0.42%) 4,570ms (± 0.69%) -16ms (- 0.34%) 4,542ms 4,623ms
Req 3 - references 403ms (± 0.65%) 403ms (± 0.77%) +0ms (+ 0.02%) 399ms 408ms
Req 4 - navto 306ms (± 1.41%) 303ms (± 2.06%) -2ms (- 0.71%) 292ms 309ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 83ms (± 9.31%) 85ms (±13.62%) +1ms (+ 1.39%) 77ms 102ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,863ms (± 0.75%) 3,848ms (± 0.34%) -15ms (- 0.40%) 3,835ms 3,869ms
Req 2 - geterr 1,469ms (± 0.97%) 1,465ms (± 0.96%) -4ms (- 0.27%) 1,442ms 1,480ms
Req 3 - references 129ms (± 1.44%) 130ms (± 2.28%) +0ms (+ 0.38%) 125ms 133ms
Req 4 - navto 396ms (± 0.31%) 394ms (± 1.39%) -2ms (- 0.46%) 385ms 401ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 494ms (± 0.58%) 502ms (± 0.91%) +8ms (+ 1.56%) 497ms 510ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52175 6
Baseline main 6

Startup

Comparison Report - main..52175
Metric main 52175 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 140.95ms (± 0.57%) 138.80ms (± 0.22%) -2.15ms (- 1.53%) 137.63ms 142.34ms
tsserver-startup - node (v16.17.1, x64)
Execution time 231.61ms (± 0.38%) 229.48ms (± 0.17%) -2.13ms (- 0.92%) 228.07ms 233.95ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 232.80ms (± 0.27%) 232.57ms (± 0.17%) -0.23ms (- 0.10%) 231.03ms 238.71ms
typescript-startup - node (v16.17.1, x64)
Execution time 213.87ms (± 0.19%) 214.28ms (± 0.18%) +0.41ms (+ 0.19%) 212.88ms 219.10ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52175 6
Baseline main 6

Developer Information:

Download Benchmark

@rbuckton rbuckton closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants