Use a `const` type parameter for `Object.freeze`. #52317

DanielRosenwasser · 2023-01-19T23:40:37Z

This PR removes an unnecessary signature from Object.freeze by using TypeScript 5.0's new const type parameters.

I think if we want to try this out, 5.0 beta is the right time.

DanielRosenwasser · 2023-01-19T23:41:13Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-01-19T23:41:17Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 241b3f2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-19T23:41:17Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 241b3f2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-19T23:41:17Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 241b3f2. You can monitor the build here.

typescript-bot · 2023-01-19T23:41:17Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 241b3f2. You can monitor the build here.

typescript-bot · 2023-01-19T23:41:17Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 241b3f2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-19T23:41:17Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 241b3f2. You can monitor the build here.

typescript-bot · 2023-01-19T23:41:17Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at 241b3f2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-19T23:41:17Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 241b3f2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-19T23:43:01Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/143202/artifacts?artifactName=tgz&fileId=28CB761571B2A532E58B46779FF657A82496E5A569938B732DB238B8D316BD1502&fileName=/typescript-5.0.0-insiders.20230119.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52317-9".;

src/lib/es5.d.ts

typescript-bot · 2023-01-19T23:53:07Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/52317/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

[NEW] error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Readonly<{ readonly initialize: SyncHook<[], void, UnsetAdditionalOptions>; readonly shouldEmit: SyncBailHook<[Compilation], boolean, UnsetAdditionalOptions>; ... 29 more ...; readonly entryOption: SyncBailHook<...>; }>'.
[NEW] error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Readonly<{ readonly buildModule: SyncHook<[Module], void, UnsetAdditionalOptions>; readonly rebuildModule: SyncHook<[Module], void, UnsetAdditionalOptions>; ... 87 more ...; readonly normalModuleLoader: SyncHook<...>; }>'.
- lib/ProgressPlugin.js#L468
[MISSING] error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Readonly<{ initialize: SyncHook<[], void, UnsetAdditionalOptions>; shouldEmit: SyncBailHook<[Compilation], boolean, UnsetAdditionalOptions>; ... 29 more ...; entryOption: SyncBailHook<...>; }>'.
[MISSING] error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Readonly<{ buildModule: SyncHook<[Module], void, UnsetAdditionalOptions>; rebuildModule: SyncHook<[Module], void, UnsetAdditionalOptions>; ... 87 more ...; readonly normalModuleLoader: SyncHook<...>; }>'.
- lib/ProgressPlugin.js#L468

typescript-bot · 2023-01-19T23:53:13Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/52317/merge:

Everything looks good!

typescript-bot · 2023-01-20T00:00:38Z

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-01-20T00:02:40Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52317

_Metric	_main	₅₂₃₁₇	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{358,166k (± 0.01%)}	_{358,176k (± 0.02%)}	_{+10k (+ 0.00%)}	_358,099k	_358,256k
_{Parse Time}	_{4.11s (± 0.29%)}	_{4.15s (± 0.21%)}	_{+0.04s (+ 0.92%)}	_4.13s	_4.15s
_{Bind Time}	_{1.25s (± 0.70%)}	_{1.24s (± 0.15%)}	_{-0.02s (- 1.33%)}	_1.23s	_1.24s
_{Check Time}	_{9.52s (± 0.54%)}	_{9.51s (± 0.29%)}	_{-0.01s (- 0.13%)}	_9.47s	_9.53s
_{Emit Time}	_{7.95s (± 0.50%)}	_{8.06s (± 0.54%)}	_{+0.11s (+ 1.33%)}	_8.00s	_8.11s
_{Total Time}	_{22.83s (± 0.35%)}	_{22.95s (± 0.24%)}	_{+0.12s (+ 0.51%)}	_22.86s	_23.02s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,866k (± 0.08%)}	_{194,307k (± 0.02%)}	_{+441k (+ 0.23%)}	_194,265k	_194,359k
_{Parse Time}	_{1.81s (± 1.20%)}	_{1.80s (± 0.20%)}	_{-0.01s (- 0.43%)}	_1.80s	_1.81s
_{Bind Time}	_{0.85s (± 0.20%)}	_{0.84s (± 0.53%)}	_{-0.01s (- 0.95%)}	_0.83s	_0.85s
_{Check Time}	_{10.35s (± 0.37%)}	_{10.38s (± 0.58%)}	_{+0.03s (+ 0.32%)}	_10.28s	_10.45s
_{Emit Time}	_{3.14s (± 5.23%)}	_{3.07s (± 1.29%)}	_{-0.07s (- 2.35%)}	_3.03s	_3.14s
_{Total Time}	_{16.15s (± 1.10%)}	_{16.09s (± 0.52%)}	_{-0.06s (- 0.37%)}	_15.99s	_16.23s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,113k (± 0.01%)}	_{343,216k (± 0.01%)}	_{-1,897k (- 0.55%)}	_343,169k	_343,239k
_{Parse Time}	_{3.12s (± 1.64%)}	_{3.11s (± 1.24%)}	_{-0.01s (- 0.21%)}	_3.07s	_3.18s
_{Bind Time}	_{1.12s (± 0.77%)}	_{1.10s (± 0.99%)}	_{-0.03s (- 2.37%)}	_1.08s	_1.11s
_{Check Time}	_{7.86s (± 0.31%)}	_{7.86s (± 0.22%)}	_{-0.00s (- 0.04%)}	_7.84s	_7.88s
_{Emit Time}	_{4.57s (± 0.70%)}	_{4.53s (± 0.59%)}	_{-0.03s (- 0.73%)}	_4.50s	_4.56s
_{Total Time}	_{16.67s (± 0.39%)}	_{16.61s (± 0.37%)}	_{-0.06s (- 0.39%)}	_16.55s	_16.70s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,924k (± 0.01%)}	_{299,618k (± 0.00%)}	_{-306k (- 0.10%)}	_299,603k	_299,634k
_{Parse Time}	_{2.43s (± 0.73%)}	_{2.45s (± 0.95%)}	_{+0.01s (+ 0.52%)}	_2.41s	_2.47s
_{Bind Time}	_{1.27s (± 0.91%)}	_{1.26s (± 1.36%)}	_{-0.00s (- 0.36%)}	_1.23s	_1.28s
_{Check Time}	_{7.48s (± 0.60%)}	_{7.47s (± 0.39%)}	_{-0.01s (- 0.08%)}	_7.43s	_7.51s
_{Emit Time}	_{4.24s (± 0.45%)}	_{4.23s (± 0.78%)}	_{-0.01s (- 0.26%)}	_4.20s	_4.28s
_{Total Time}	_{15.42s (± 0.39%)}	_{15.41s (± 0.30%)}	_{-0.01s (- 0.04%)}	_15.34s	_15.46s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,695k (± 0.00%)}	_{475,349k (± 0.01%)}	_{-346k (- 0.07%)}	_475,312k	_475,381k
_{Parse Time}	_{3.67s (± 0.40%)}	_{3.66s (± 0.33%)}	_{-0.01s (- 0.28%)}	_3.65s	_3.68s
_{Bind Time}	_{1.01s (± 0.65%)}	_{1.01s (± 0.48%)}	_{-0.01s (- 0.89%)}	_1.00s	_1.01s
_{Check Time}	_{18.05s (± 0.68%)}	_{18.05s (± 1.48%)}	_{-0.00s (- 0.00%)}	_17.87s	_18.59s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.73s (± 0.55%)}	_{22.71s (± 1.20%)}	_{-0.02s (- 0.07%)}	_22.55s	_23.27s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{543,940k (± 0.01%)}	_{544,488k (± 0.02%)}	_{+548k (+ 0.10%)}	_544,348k	_544,635k
_{Parse Time}	_{4.59s (± 0.75%)}	_{4.60s (± 0.65%)}	_{+0.01s (+ 0.27%)}	_4.57s	_4.66s
_{Bind Time}	_{1.79s (± 0.67%)}	_{1.78s (± 0.55%)}	_{-0.01s (- 0.75%)}	_1.77s	_1.79s
_{Check Time}	_{2.94s (± 0.65%)}	_{2.95s (± 0.30%)}	_{+0.01s (+ 0.25%)}	_2.93s	_2.96s
_{Emit Time}	_{0.09s (± 4.62%)}	_{0.09s (± 7.08%)}	_{+0.00s (+ 1.69%)}	_0.08s	_0.10s
_{Total Time}	_{9.42s (± 0.45%)}	_{9.42s (± 0.46%)}	_{+0.01s (+ 0.07%)}	_9.37s	_9.50s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₁₇	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

DanielRosenwasser · 2023-01-20T00:16:52Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot perf test this faster

typescript-bot · 2023-01-20T00:16:56Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at bedfac1. You can monitor the build here.

typescript-bot · 2023-01-20T00:16:56Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at bedfac1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:16:56Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at bedfac1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:16:56Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at bedfac1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:16:56Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at bedfac1. You can monitor the build here.

typescript-bot · 2023-01-20T00:16:56Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at bedfac1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:16:56Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at bedfac1. You can monitor the build here.

typescript-bot · 2023-01-20T00:19:04Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/143231/artifacts?artifactName=tgz&fileId=D513BBD7D2E92BD8C59FE26687B5A5D7FE98CE9809E93573C555B4E9A2C83C3302&fileName=/typescript-5.0.0-insiders.20230120.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52317-22".;

jakebailey · 2023-01-20T00:21:13Z

tests/baselines/reference/checkIndexConstraintOfJavascriptClassExpression.errors.txt

@@ -9,7 +9,7 @@ tests/cases/compiler/weird.js(9,17): error TS7006: Parameter 'error' implicitly
 someFunction(function(BaseClass) {
 ~~~~~~~~~~~~
 !!! error TS2552: Cannot find name 'someFunction'. Did you mean 'Function'?
-!!! related TS2728 /.ts/lib.es5.d.ts:321:13: 'Function' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:315:13: 'Function' is declared here.


I really want to send a PR which changes the baselines to filter out all line numbers from lib.*.d.ts files; it really sucks to modify a baseline and have it all be line numbers that don't matter.

I was thinking the same - however, maybe start conservative and only do that on related spans.

The other problem is that when you add a new overload to a lib, more than just line numbers change; any use gets more symbols too, so it's not a perfect solution.

typescript-bot · 2023-01-20T00:28:17Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/52317/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

[NEW] error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Readonly<{ readonly initialize: SyncHook<[], void, UnsetAdditionalOptions>; readonly shouldEmit: SyncBailHook<[Compilation], boolean, UnsetAdditionalOptions>; ... 29 more ...; readonly entryOption: SyncBailHook<...>; }>'.
[NEW] error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Readonly<{ readonly buildModule: SyncHook<[Module], void, UnsetAdditionalOptions>; readonly rebuildModule: SyncHook<[Module], void, UnsetAdditionalOptions>; ... 87 more ...; readonly normalModuleLoader: SyncHook<...>; }>'.
- lib/ProgressPlugin.js#L468
[MISSING] error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Readonly<{ initialize: SyncHook<[], void, UnsetAdditionalOptions>; shouldEmit: SyncBailHook<[Compilation], boolean, UnsetAdditionalOptions>; ... 29 more ...; entryOption: SyncBailHook<...>; }>'.
[MISSING] error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Readonly<{ buildModule: SyncHook<[Module], void, UnsetAdditionalOptions>; rebuildModule: SyncHook<[Module], void, UnsetAdditionalOptions>; ... 87 more ...; readonly normalModuleLoader: SyncHook<...>; }>'.
- lib/ProgressPlugin.js#L468

typescript-bot · 2023-01-20T00:28:18Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/52317/merge:

Everything looks good!

typescript-bot · 2023-01-20T00:32:49Z

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

jakebailey · 2023-01-20T00:36:50Z

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

This one's actually interesting!

DanielRosenwasser · 2023-01-20T00:39:10Z

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

This one's actually interesting!

There were already mapped through Readonly - so while useful to view, I don't think there's any regression.

typescript-bot · 2023-01-20T01:23:31Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/52317/merge:

Something interesting changed - please have a look.

Details

babel/babel

⚠️ Note that built also had errors ⚠️

Req #710 - definitionAndBoundSpan
    at getConstructorDefinedThisAssignmentTypes (/typescript-main/built/local/tsserver.js:55613:11)
    at getWidenedTypeForAssignmentDeclaration (/typescript-main/built/local/tsserver.js:55427:78)
    at getTypeOfVariableOrParameterOrPropertyWorker (/typescript-main/built/local/tsserver.js:55811:14)
    at getTypeOfVariableOrParameterOrProperty (/typescript-main/built/local/tsserver.js:55759:20)
    at getTypeOfSymbol (/typescript-main/built/local/tsserver.js:56076:14)
    at checkPropertyAccessExpressionOrQualifiedName (/typescript-main/built/local/tsserver.js:72744:116)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72508:94)
    at getSymbolOfNameOrPropertyAccessExpression (/typescript-main/built/local/tsserver.js:83998:11)
    at getSymbolAtLocation (/typescript-main/built/local/tsserver.js:84123:18)
    at Object.getSymbolAtLocation (/typescript-main/built/local/tsserver.js:47227:21)
    at getSymbol (/typescript-main/built/local/tsserver.js:157251:26)
    at getDefinitionAtPosition (/typescript-main/built/local/tsserver.js:157054:43)
    at Object.getDefinitionAndBoundSpan (/typescript-main/built/local/tsserver.js:157235:23)
    at Object.getDefinitionAndBoundSpan2 [as getDefinitionAndBoundSpan] (/typescript-main/built/local/tsserver.js:137622:38)
    at IOSession.getDefinitionAndBoundSpan (/typescript-main/built/local/tsserver.js:179293:73)
    at definitionAndBoundSpan (/typescript-main/built/local/tsserver.js:178275:43)
    at /typescript-main/built/local/tsserver.js:180796:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:180788:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:180796:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:180838:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:182289:14)

Req #710 - definitionAndBoundSpan
    at getConstructorDefinedThisAssignmentTypes (/typescript-52317/built/local/tsserver.js:55613:11)
    at getWidenedTypeForAssignmentDeclaration (/typescript-52317/built/local/tsserver.js:55427:78)
    at getTypeOfVariableOrParameterOrPropertyWorker (/typescript-52317/built/local/tsserver.js:55811:14)
    at getTypeOfVariableOrParameterOrProperty (/typescript-52317/built/local/tsserver.js:55759:20)
    at getTypeOfSymbol (/typescript-52317/built/local/tsserver.js:56076:14)
    at checkPropertyAccessExpressionOrQualifiedName (/typescript-52317/built/local/tsserver.js:72744:116)
    at checkPropertyAccessExpression (/typescript-52317/built/local/tsserver.js:72508:94)
    at getSymbolOfNameOrPropertyAccessExpression (/typescript-52317/built/local/tsserver.js:83998:11)
    at getSymbolAtLocation (/typescript-52317/built/local/tsserver.js:84123:18)
    at Object.getSymbolAtLocation (/typescript-52317/built/local/tsserver.js:47227:21)
    at getSymbol (/typescript-52317/built/local/tsserver.js:157251:26)
    at getDefinitionAtPosition (/typescript-52317/built/local/tsserver.js:157054:43)
    at Object.getDefinitionAndBoundSpan (/typescript-52317/built/local/tsserver.js:157235:23)
    at Object.getDefinitionAndBoundSpan2 [as getDefinitionAndBoundSpan] (/typescript-52317/built/local/tsserver.js:137622:38)
    at IOSession.getDefinitionAndBoundSpan (/typescript-52317/built/local/tsserver.js:179293:73)
    at definitionAndBoundSpan (/typescript-52317/built/local/tsserver.js:178275:43)
    at /typescript-52317/built/local/tsserver.js:180796:69
    at IOSession.executeWithRequestId (/typescript-52317/built/local/tsserver.js:180788:14)
    at IOSession.executeCommand (/typescript-52317/built/local/tsserver.js:180796:29)
    at IOSession.onMessage (/typescript-52317/built/local/tsserver.js:180838:51)
    at Interface.<anonymous> (/typescript-52317/built/local/tsserver.js:182289:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults1/babel.babel.rawError.txt in the artifact folder

Last few requests

{"seq":707,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/sourcemaps/real-world-babel-file2/output.js","line":462,"offset":5,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":708,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/sourcemaps/real-world-babel-file2/output.js","line":462,"offset":5,"entryNames":["arguments"]}}
{"seq":709,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/sourcemaps/real-world-babel-file2/output.js","line":462,"offset":25}}
{"seq":710,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/sourcemaps/real-world-babel-file2/output.js","line":494,"offset":26}}

Repro Steps

git clone https://github.com/babel/babel --recurse-submodules
In dir babel, run git reset --hard 0f68471ef79933e192b69f2ebdf586fb5d5e54ce
Back in the initial folder, download RepoResults1/babel.babel.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./babel ./babel.babel.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

typescript-bot · 2023-01-20T01:44:43Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/52317/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

6 of 53 projects failed to build with the old tsc and were ignored

extensions/markdown-language-features/server/tsconfig.json

error TS2322: Type 'Readonly<{ readonly kind: "full"; readonly items: readonly []; }>' is not assignable to type 'FullDocumentDiagnosticReport | UnchangedDocumentDiagnosticReport'.

typescript-bot · 2023-01-20T01:46:31Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/52317/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

6 of 53 projects failed to build with the old tsc and were ignored

extensions/markdown-language-features/server/tsconfig.json

error TS2322: Type 'Readonly<{ readonly kind: "full"; readonly items: readonly []; }>' is not assignable to type 'FullDocumentDiagnosticReport | UnchangedDocumentDiagnosticReport'.

typescript-bot · 2023-01-20T01:52:09Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/52317/merge:

Something interesting changed - please have a look.

Details

babel/babel

⚠️ Note that built also had errors ⚠️

Req #710 - definitionAndBoundSpan
    at getConstructorDefinedThisAssignmentTypes (/typescript-main/built/local/tsserver.js:55613:11)
    at getWidenedTypeForAssignmentDeclaration (/typescript-main/built/local/tsserver.js:55427:78)
    at getTypeOfVariableOrParameterOrPropertyWorker (/typescript-main/built/local/tsserver.js:55811:14)
    at getTypeOfVariableOrParameterOrProperty (/typescript-main/built/local/tsserver.js:55759:20)
    at getTypeOfSymbol (/typescript-main/built/local/tsserver.js:56076:14)
    at checkPropertyAccessExpressionOrQualifiedName (/typescript-main/built/local/tsserver.js:72744:116)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72508:94)
    at getSymbolOfNameOrPropertyAccessExpression (/typescript-main/built/local/tsserver.js:83998:11)
    at getSymbolAtLocation (/typescript-main/built/local/tsserver.js:84123:18)
    at Object.getSymbolAtLocation (/typescript-main/built/local/tsserver.js:47227:21)
    at getSymbol (/typescript-main/built/local/tsserver.js:157251:26)
    at getDefinitionAtPosition (/typescript-main/built/local/tsserver.js:157054:43)
    at Object.getDefinitionAndBoundSpan (/typescript-main/built/local/tsserver.js:157235:23)
    at Object.getDefinitionAndBoundSpan2 [as getDefinitionAndBoundSpan] (/typescript-main/built/local/tsserver.js:137622:38)
    at IOSession.getDefinitionAndBoundSpan (/typescript-main/built/local/tsserver.js:179293:73)
    at definitionAndBoundSpan (/typescript-main/built/local/tsserver.js:178275:43)
    at /typescript-main/built/local/tsserver.js:180796:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:180788:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:180796:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:180838:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:182289:14)

Req #710 - definitionAndBoundSpan
    at getConstructorDefinedThisAssignmentTypes (/typescript-52317/built/local/tsserver.js:55613:11)
    at getWidenedTypeForAssignmentDeclaration (/typescript-52317/built/local/tsserver.js:55427:78)
    at getTypeOfVariableOrParameterOrPropertyWorker (/typescript-52317/built/local/tsserver.js:55811:14)
    at getTypeOfVariableOrParameterOrProperty (/typescript-52317/built/local/tsserver.js:55759:20)
    at getTypeOfSymbol (/typescript-52317/built/local/tsserver.js:56076:14)
    at checkPropertyAccessExpressionOrQualifiedName (/typescript-52317/built/local/tsserver.js:72744:116)
    at checkPropertyAccessExpression (/typescript-52317/built/local/tsserver.js:72508:94)
    at getSymbolOfNameOrPropertyAccessExpression (/typescript-52317/built/local/tsserver.js:83998:11)
    at getSymbolAtLocation (/typescript-52317/built/local/tsserver.js:84123:18)
    at Object.getSymbolAtLocation (/typescript-52317/built/local/tsserver.js:47227:21)
    at getSymbol (/typescript-52317/built/local/tsserver.js:157251:26)
    at getDefinitionAtPosition (/typescript-52317/built/local/tsserver.js:157054:43)
    at Object.getDefinitionAndBoundSpan (/typescript-52317/built/local/tsserver.js:157235:23)
    at Object.getDefinitionAndBoundSpan2 [as getDefinitionAndBoundSpan] (/typescript-52317/built/local/tsserver.js:137622:38)
    at IOSession.getDefinitionAndBoundSpan (/typescript-52317/built/local/tsserver.js:179293:73)
    at definitionAndBoundSpan (/typescript-52317/built/local/tsserver.js:178275:43)
    at /typescript-52317/built/local/tsserver.js:180796:69
    at IOSession.executeWithRequestId (/typescript-52317/built/local/tsserver.js:180788:14)
    at IOSession.executeCommand (/typescript-52317/built/local/tsserver.js:180796:29)
    at IOSession.onMessage (/typescript-52317/built/local/tsserver.js:180838:51)
    at Interface.<anonymous> (/typescript-52317/built/local/tsserver.js:182289:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults1/babel.babel.rawError.txt in the artifact folder

Last few requests

{"seq":707,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/sourcemaps/real-world-babel-file2/output.js","line":462,"offset":5,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":708,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/sourcemaps/real-world-babel-file2/output.js","line":462,"offset":5,"entryNames":["arguments"]}}
{"seq":709,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/sourcemaps/real-world-babel-file2/output.js","line":462,"offset":25}}
{"seq":710,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/sourcemaps/real-world-babel-file2/output.js","line":494,"offset":26}}

Repro Steps

git clone https://github.com/babel/babel --recurse-submodules
In dir babel, run git reset --hard 0f68471ef79933e192b69f2ebdf586fb5d5e54ce
Back in the initial folder, download RepoResults1/babel.babel.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./babel ./babel.babel.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

typescript-bot · 2023-01-20T03:08:45Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52317

_Metric	_main	₅₂₃₁₇	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{358,170k (± 0.01%)}	_{358,197k (± 0.01%)}	_{+27k (+ 0.01%)}	_358,145k	_358,250k
_{Parse Time}	_{4.13s (± 0.44%)}	_{4.15s (± 0.16%)}	_{+0.02s (+ 0.52%)}	_4.14s	_4.16s
_{Bind Time}	_{1.24s (± 0.39%)}	_{1.25s (± 0.50%)}	_{+0.01s (+ 0.80%)}	_1.24s	_1.26s
_{Check Time}	_{9.52s (± 0.65%)}	_{9.51s (± 0.33%)}	_{-0.01s (- 0.11%)}	_9.48s	_9.56s
_{Emit Time}	_{8.05s (± 0.55%)}	_{8.08s (± 0.50%)}	_{+0.03s (+ 0.37%)}	_8.03s	_8.14s
_{Total Time}	_{22.95s (± 0.48%)}	_{23.00s (± 0.21%)}	_{+0.05s (+ 0.22%)}	_22.92s	_23.05s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,267k (± 0.02%)}	_{194,183k (± 0.05%)}	_{-84k (- 0.04%)}	_194,087k	_194,326k
_{Parse Time}	_{1.80s (± 0.58%)}	_{1.80s (± 0.38%)}	_{-0.00s (- 0.13%)}	_1.79s	_1.81s
_{Bind Time}	_{0.85s (± 0.97%)}	_{0.85s (± 0.58%)}	_{+0.00s (+ 0.36%)}	_0.84s	_0.86s
_{Check Time}	_{10.36s (± 0.69%)}	_{10.31s (± 0.70%)}	_{-0.04s (- 0.40%)}	_10.26s	_10.45s
_{Emit Time}	_{3.02s (± 0.90%)}	_{3.07s (± 1.55%)}	_{+0.05s (+ 1.61%)}	_3.04s	_3.17s
_{Total Time}	_{16.03s (± 0.56%)}	_{16.04s (± 0.72%)}	_{+0.01s (+ 0.05%)}	_15.95s	_16.26s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,251k (± 0.01%)}	_{343,216k (± 0.01%)}	_{-35k (- 0.01%)}	_343,191k	_343,247k
_{Parse Time}	_{3.11s (± 1.27%)}	_{3.10s (± 0.92%)}	_{-0.01s (- 0.37%)}	_3.06s	_3.14s
_{Bind Time}	_{1.10s (± 0.50%)}	_{1.10s (± 0.16%)}	_{-0.00s (- 0.40%)}	_1.09s	_1.10s
_{Check Time}	_{7.92s (± 0.26%)}	_{7.87s (± 0.26%)}	_{-0.04s (- 0.54%)}	_7.85s	_7.90s
_{Emit Time}	_{4.54s (± 0.72%)}	_{4.52s (± 0.50%)}	_{-0.02s (- 0.39%)}	_4.50s	_4.56s
_{Total Time}	_{16.67s (± 0.39%)}	_{16.59s (± 0.31%)}	_{-0.08s (- 0.48%)}	_16.51s	_16.67s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,659k (± 0.00%)}	_{299,641k (± 0.01%)}	_{-18k (- 0.01%)}	_299,618k	_299,671k
_{Parse Time}	_{2.46s (± 0.80%)}	_{2.45s (± 0.85%)}	_{-0.01s (- 0.44%)}	_2.42s	_2.47s
_{Bind Time}	_{1.26s (± 0.49%)}	_{1.27s (± 0.91%)}	_{+0.00s (+ 0.23%)}	_1.25s	_1.28s
_{Check Time}	_{7.45s (± 0.23%)}	_{7.47s (± 0.64%)}	_{+0.02s (+ 0.32%)}	_7.40s	_7.51s
_{Emit Time}	_{4.25s (± 0.42%)}	_{4.23s (± 0.79%)}	_{-0.02s (- 0.45%)}	_4.19s	_4.28s
_{Total Time}	_{15.42s (± 0.09%)}	_{15.41s (± 0.52%)}	_{-0.00s (- 0.03%)}	_15.31s	_15.52s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,373k (± 0.00%)}	_{475,325k (± 0.00%)}	_{-48k (- 0.01%)}	_475,302k	_475,361k
_{Parse Time}	_{3.63s (± 0.28%)}	_{3.65s (± 0.47%)}	_{+0.02s (+ 0.65%)}	_3.63s	_3.67s
_{Bind Time}	_{1.00s (± 0.70%)}	_{1.01s (± 0.62%)}	_{+0.01s (+ 0.53%)}	_1.00s	_1.02s
_{Check Time}	_{18.07s (± 1.21%)}	_{17.95s (± 0.45%)}	_{-0.12s (- 0.65%)}	_17.87s	_18.05s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.70s (± 0.99%)}	_{22.61s (± 0.39%)}	_{-0.09s (- 0.39%)}	_22.52s	_22.72s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{544,522k (± 0.02%)}	_{544,498k (± 0.02%)}	_{-24k (- 0.00%)}	_544,340k	_544,620k
_{Parse Time}	_{4.58s (± 0.67%)}	_{4.62s (± 0.66%)}	_{+0.04s (+ 0.86%)}	_4.58s	_4.67s
_{Bind Time}	_{1.78s (± 0.34%)}	_{1.79s (± 0.31%)}	_{+0.01s (+ 0.44%)}	_1.78s	_1.80s
_{Check Time}	_{2.95s (± 0.49%)}	_{2.95s (± 0.31%)}	_{+0.01s (+ 0.29%)}	_2.94s	_2.97s
_{Emit Time}	_{0.09s (± 0.15%)}	_{0.09s (± 0.17%)}	_{+0.00s (+ 0.07%)}	_0.09s	_0.09s
_{Total Time}	_{9.40s (± 0.41%)}	_{9.44s (± 0.53%)}	_{+0.04s (+ 0.44%)}	_9.37s	_9.52s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₁₇	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

jakebailey · 2023-01-20T05:48:43Z

That tsserver trace is fixed by ~~#52321~~ #51524.

DanielRosenwasser · 2023-01-20T20:09:32Z

Literally talked myself out of this during today's design meeting. It almost makes sense until you realize that nested objects aren't frozen.

While lots of users would like for Object.freeze to do deep immutability, it doesn't. And while you might want it to be a signal for deep immutability for TypeScript, you can achieve that by doing your own interface merging and adding a new signature to freeze in ObjectConstructor.

DanielRosenwasser added 2 commits January 19, 2023 23:39

Use a const type parameter for Object.freeze.

4d51879

Accepted baselines.

241b3f2

typescript-bot assigned DanielRosenwasser Jan 19, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 19, 2023

Andarist reviewed Jan 19, 2023

View reviewed changes

src/lib/es5.d.ts Outdated Show resolved Hide resolved

DanielRosenwasser added 2 commits January 20, 2023 00:15

Remove (hopefully) unnecessary overload.

9705b71

Accepted baselines.

bedfac1

DanielRosenwasser marked this pull request as ready for review January 20, 2023 00:17

DanielRosenwasser requested review from ahejlsberg, jakebailey and weswigham January 20, 2023 00:17

jakebailey reviewed Jan 20, 2023

View reviewed changes

jakebailey mentioned this pull request Jan 20, 2023

Fix debug assert in getConstructorDefinedThisAssignmentTypes #52321

Closed

jakebailey mentioned this pull request Jan 20, 2023

Elide line:col info in "!!! related" errors when from default lib.d.ts files #52330

Merged

DanielRosenwasser mentioned this pull request Jan 20, 2023

Design Meeting Notes, 1/20/2023 #52337

Closed

DanielRosenwasser closed this Jan 20, 2023

jakebailey mentioned this pull request Jan 20, 2023

fix(51521): Using a of property declared after an initializing constructor triggers an assertion failure in JS #51524

Merged

This was referenced Aug 27, 2023

숫자 야구 게임 과제 제출 Gamangjum-lihou/effective-typescript-assignment#1

Open

숫자 야구 게임 과제 제출 Gamangjum-lihou/effective-typescript-assignment#3

Open

Use a const type parameter for Object.freeze. #52317

Use a const type parameter for Object.freeze. #52317

Conversation

DanielRosenwasser commented Jan 19, 2023 • edited Loading

DanielRosenwasser commented Jan 19, 2023

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023 • edited Loading

typescript-bot commented Jan 19, 2023

typescript-bot commented Jan 19, 2023

typescript-bot commented Jan 20, 2023

typescript-bot commented Jan 20, 2023

DanielRosenwasser commented Jan 20, 2023

typescript-bot commented Jan 20, 2023 • edited Loading

typescript-bot commented Jan 20, 2023 • edited Loading

typescript-bot commented Jan 20, 2023 • edited Loading

typescript-bot commented Jan 20, 2023 • edited Loading

typescript-bot commented Jan 20, 2023 • edited Loading

typescript-bot commented Jan 20, 2023 • edited Loading

typescript-bot commented Jan 20, 2023 • edited Loading

typescript-bot commented Jan 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

typescript-bot commented Jan 20, 2023

typescript-bot commented Jan 20, 2023

typescript-bot commented Jan 20, 2023

jakebailey commented Jan 20, 2023

DanielRosenwasser commented Jan 20, 2023

typescript-bot commented Jan 20, 2023

Last few requests

Repro Steps

typescript-bot commented Jan 20, 2023

typescript-bot commented Jan 20, 2023

typescript-bot commented Jan 20, 2023

Last few requests

Repro Steps

typescript-bot commented Jan 20, 2023

jakebailey commented Jan 20, 2023 • edited Loading

DanielRosenwasser commented Jan 20, 2023 • edited Loading

Use a `const` type parameter for `Object.freeze`. #52317

Use a `const` type parameter for `Object.freeze`. #52317

DanielRosenwasser commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 19, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

jakebailey commented Jan 20, 2023 •

edited

Loading

DanielRosenwasser commented Jan 20, 2023 •

edited

Loading