-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(52440): typeof ... === "undefined" check on mapped object member doesn't narrow correctly, for only some purposes #52456
Conversation
This looks right but I don't want to get surprised @typescript-bot test this |
Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at e09645c. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at e09645c. You can monitor the build here. |
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at e09645c. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at e09645c. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at e09645c. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at e09645c. You can monitor the build here. |
Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at e09645c. You can monitor the build here. Update: The results are in! |
@RyanCavanaugh Here are the results of running the user test suite comparing Everything looks good! |
1 similar comment
@RyanCavanaugh Here are the results of running the user test suite comparing Everything looks good! |
Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
@RyanCavanaugh Here are the results of running the top-repos suite comparing Everything looks good! |
1 similar comment
@RyanCavanaugh Here are the results of running the top-repos suite comparing Everything looks good! |
@RyanCavanaugh Here they are:
CompilerComparison Report - main..52456
System
Hosts
Scenarios
TSServerComparison Report - main..52456
System
Hosts
Scenarios
StartupComparison Report - main..52456
System
Hosts
Scenarios
Developer Information: |
Thanks! |
Fixes #52440