Skip to content

fix(52514): overload Tags do not receive noImplicitAny errors on missing return types #52518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2023
Merged

fix(52514): overload Tags do not receive noImplicitAny errors on missing return types #52518

merged 4 commits into from
Jan 31, 2023

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #52514

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jan 30, 2023
@a-tarasyuk a-tarasyuk marked this pull request as ready for review January 30, 2023 21:31
sandersn
sandersn requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think the error position can be expressed more succinctly.

@sandersn sandersn merged commit 7c22023 into microsoft:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@sandersn sandersn

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@overload Tags do not receive noImplicitAny errors on missing return types
4 participants
@a-tarasyuk @sandersn @DanielRosenwasser @typescript-bot