Fix string completions depending on contextual signatures #52717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Andarist
commented
Feb 10, 2023
| //// entry: sendTo((ctx) => ctx.child, { type: "/*2*/" }), | ||
| //// }); | ||
|
|
||
| verify.completions({ marker: "1", includes: [`"EVENT"`] }) |
There was a problem hiding this comment.
this one was already working since the omitted node~ was already producing { type: any } and thus didn't fail the applicability check, whereas when requesting the string completion the type was { type: '' } and it was failing the check and thus failing to provide the completions
|
Can you explain what bug is fixed here? Preferably also filing a bug to track the problem. |
Andarist
commented
Mar 3, 2023
tests/cases/fourslash/completionsForStringDependingOnContexSensitiveSignature.ts
Outdated
Show resolved
Hide resolved
Andarist
commented
Mar 3, 2023
tests/cases/fourslash/completionsForStringDependingOnContexSensitiveSignature.ts
Outdated
Show resolved
Hide resolved
…sitiveSignature.ts
andrewbranch
approved these changes
Mar 7, 2023
sandersn
approved these changes
Mar 8, 2023
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53073
cc @andrewbranch