Remove the specialcase intended for strictNullChecks: false in Awaited

[Andarist]

A colleague of mine asked me why this branch is needed here. I couldn't figure it out so I decided to run the TS test suite without this to learn more about it... but the whole thing just passed.

There are two possible situations here:

• this is redundant
• the test suite lacks the appropriate test case

If it's the second situation - then I would appreciate if somebody could provide that test case so I could add it, cause I don't know what that would look like.

This type was added here with this special branch there, right from the start. cc @rbuckton

[typescript-bot]

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

[RyanCavanaugh]

Maybe this will help, not sure:

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt

[typescript-bot]

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 7e8f046. You can monitor the build here.

[typescript-bot]

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 7e8f046. You can monitor the build here.

[typescript-bot]

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 7e8f046. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 7e8f046. You can monitor the build here.

Update: The results are in!

[jakebailey]

Not sure if our benchmarks use it but it's less work to do while checking so maybe...

@typescript-bot perf test this

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at 7e8f046. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/52949/merge:

Everything looks good!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52949

Metric	main	52949	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	359,718k (± 0.02%)	359,740k (± 0.01%)	~	359,661k	359,785k	p=0.689 n=6
Parse Time	3.49s (± 0.66%)	3.48s (± 1.05%)	~	3.44s	3.54s	p=0.872 n=6
Bind Time	1.13s (± 0.67%)	1.13s (± 0.72%)	~	1.12s	1.14s	p=0.729 n=6
Check Time	8.67s (± 0.69%)	8.67s (± 0.49%)	~	8.60s	8.72s	p=1.000 n=6
Emit Time	7.46s (± 0.81%)	7.47s (± 0.81%)	~	7.40s	7.56s	p=1.000 n=6
Total Time	20.75s (± 0.51%)	20.75s (± 0.27%)	~	20.65s	20.80s	p=0.335 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	190,717k (± 1.24%)	192,986k (± 1.46%)	~	189,635k	195,568k	p=0.378 n=6
Parse Time	1.49s (± 1.39%)	1.49s (± 1.17%)	~	1.47s	1.52s	p=0.565 n=6
Bind Time	0.78s (± 1.05%)	0.77s (± 1.06%)	~	0.76s	0.78s	p=0.077 n=6
Check Time	9.42s (± 0.52%)	9.37s (± 0.42%)	~	9.32s	9.42s	p=0.078 n=6
Emit Time	2.77s (± 0.68%)	2.74s (± 0.58%)	~	2.72s	2.76s	p=0.051 n=6
Total Time	14.45s (± 0.36%)	14.37s (± 0.26%)	-0.08s (- 0.54%)	14.34s	14.44s	p=0.015 n=6
Monaco - node (v18.10.0, x64)
Memory used	343,839k (± 0.01%)	343,827k (± 0.01%)	~	343,793k	343,884k	p=0.422 n=6
Parse Time	2.64s (± 1.06%)	2.61s (± 1.02%)	~	2.58s	2.64s	p=0.226 n=6
Bind Time	1.01s (± 0.51%)	1.01s (± 0.40%)	~	1.00s	1.01s	p=0.114 n=6
Check Time	7.05s (± 0.23%)	7.00s (± 0.33%)	-0.05s (- 0.64%)	6.98s	7.04s	p=0.012 n=6
Emit Time	4.21s (± 0.59%)	4.22s (± 0.76%)	~	4.17s	4.25s	p=0.466 n=6
Total Time	14.91s (± 0.37%)	14.85s (± 0.26%)	~	14.79s	14.90s	p=0.077 n=6
TFS - node (v18.10.0, x64)
Memory used	299,858k (± 0.01%)	299,864k (± 0.01%)	~	299,844k	299,888k	p=0.936 n=6
Parse Time	2.07s (± 1.13%)	2.06s (± 1.25%)	~	2.02s	2.10s	p=0.222 n=6
Bind Time	1.14s (± 0.73%)	1.13s (± 0.48%)	-0.01s (- 0.87%)	1.13s	1.14s	p=0.038 n=6
Check Time	6.53s (± 0.35%)	6.49s (± 0.28%)	-0.04s (- 0.59%)	6.47s	6.51s	p=0.024 n=6
Emit Time	3.87s (± 1.02%)	3.85s (± 0.67%)	~	3.81s	3.89s	p=0.747 n=6
Total Time	13.61s (± 0.42%)	13.54s (± 0.26%)	-0.07s (- 0.55%)	13.50s	13.59s	p=0.024 n=6
material-ui - node (v18.10.0, x64)
Memory used	476,424k (± 0.00%)	476,386k (± 0.00%)	-38k (- 0.01%)	476,356k	476,407k	p=0.024 n=6
Parse Time	3.17s (± 0.61%)	3.15s (± 0.74%)	~	3.12s	3.18s	p=0.124 n=6
Bind Time	0.91s (± 0.45%)	0.91s (± 0.57%)	~	0.90s	0.91s	p=0.114 n=6
Check Time	17.17s (± 0.87%)	17.06s (± 0.54%)	~	16.97s	17.17s	p=0.173 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.25s (± 0.66%)	21.11s (± 0.40%)	~	21.02s	21.21s	p=0.173 n=6
xstate - node (v18.10.0, x64)
Memory used	548,237k (± 0.04%)	548,138k (± 0.03%)	~	547,948k	548,374k	p=0.471 n=6
Parse Time	4.08s (± 0.69%)	4.08s (± 0.61%)	~	4.05s	4.11s	p=1.000 n=6
Bind Time	1.67s (± 0.99%)	1.66s (± 0.49%)	~	1.65s	1.67s	p=1.000 n=6
Check Time	2.79s (± 0.70%)	2.77s (± 0.27%)	~	2.76s	2.78s	p=0.164 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	8.62s (± 0.54%)	8.59s (± 0.24%)	~	8.57s	8.62s	p=0.366 n=6
Angular - node (v16.17.1, x64)
Memory used	359,035k (± 0.01%)	359,044k (± 0.01%)	~	359,022k	359,079k	p=0.575 n=6
Parse Time	3.73s (± 0.80%)	3.72s (± 0.40%)	~	3.69s	3.73s	p=0.513 n=6
Bind Time	1.19s (± 0.63%)	1.19s (± 0.34%)	~	1.18s	1.19s	p=0.389 n=6
Check Time	9.45s (± 0.64%)	9.42s (± 0.40%)	~	9.40s	9.50s	p=0.220 n=6
Emit Time	7.93s (± 0.62%)	7.91s (± 0.63%)	~	7.83s	7.98s	p=0.625 n=6
Total Time	22.31s (± 0.52%)	22.24s (± 0.31%)	~	22.15s	22.36s	p=0.225 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	191,374k (± 0.04%)	191,409k (± 0.03%)	~	191,352k	191,487k	p=0.471 n=6
Parse Time	1.59s (± 1.31%)	1.55s (± 1.35%)	-0.04s (- 2.21%)	1.52s	1.57s	p=0.023 n=6
Bind Time	0.83s (± 0.49%)	0.82s (± 0.63%)	-0.01s (- 1.41%)	0.81s	0.82s	p=0.007 n=6
Check Time	10.09s (± 0.27%)	10.03s (± 0.74%)	~	9.91s	10.12s	p=0.197 n=6
Emit Time	3.04s (± 0.77%)	3.01s (± 0.44%)	-0.03s (- 0.93%)	2.99s	3.03s	p=0.033 n=6
Total Time	15.54s (± 0.24%)	15.41s (± 0.57%)	-0.12s (- 0.79%)	15.27s	15.51s	p=0.013 n=6
Monaco - node (v16.17.1, x64)
Memory used	343,078k (± 0.00%)	343,091k (± 0.01%)	~	343,064k	343,121k	p=0.378 n=6
Parse Time	2.81s (± 0.52%)	2.80s (± 0.69%)	~	2.78s	2.83s	p=0.370 n=6
Bind Time	1.09s (± 0.58%)	1.09s (± 1.07%)	~	1.08s	1.11s	p=0.485 n=6
Check Time	7.69s (± 0.67%)	7.67s (± 0.54%)	~	7.62s	7.74s	p=0.630 n=6
Emit Time	4.45s (± 1.41%)	4.42s (± 0.77%)	~	4.38s	4.47s	p=0.573 n=6
Total Time	16.04s (± 0.63%)	15.98s (± 0.36%)	~	15.93s	16.09s	p=0.468 n=6
TFS - node (v16.17.1, x64)
Memory used	299,217k (± 0.01%)	299,236k (± 0.01%)	~	299,221k	299,260k	p=0.128 n=6
Parse Time	2.20s (± 0.85%)	2.19s (± 0.61%)	~	2.17s	2.20s	p=0.554 n=6
Bind Time	1.24s (± 1.10%)	1.25s (± 1.63%)	~	1.21s	1.27s	p=0.157 n=6
Check Time	7.17s (± 0.58%)	7.17s (± 0.52%)	~	7.10s	7.21s	p=0.809 n=6
Emit Time	4.34s (± 0.70%)	4.33s (± 0.69%)	~	4.28s	4.36s	p=0.687 n=6
Total Time	14.94s (± 0.52%)	14.93s (± 0.51%)	~	14.78s	14.98s	p=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used	475,712k (± 0.01%)	475,728k (± 0.01%)	~	475,683k	475,801k	p=0.378 n=6
Parse Time	3.33s (± 0.41%)	3.33s (± 0.16%)	~	3.32s	3.33s	p=0.341 n=6
Bind Time	0.96s (± 0.54%)	0.96s (± 0.00%)	~	0.96s	0.96s	p=0.174 n=6
Check Time	18.11s (± 0.47%)	18.04s (± 0.25%)	~	17.97s	18.11s	p=0.148 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.41s (± 0.37%)	22.33s (± 0.23%)	~	22.24s	22.40s	p=0.077 n=6
xstate - node (v16.17.1, x64)
Memory used	545,722k (± 0.01%)	545,744k (± 0.02%)	~	545,642k	545,893k	p=0.936 n=6
Parse Time	4.27s (± 0.21%)	4.25s (± 0.23%)	-0.02s (- 0.51%)	4.24s	4.26s	p=0.011 n=6
Bind Time	1.75s (± 0.72%)	1.74s (± 0.60%)	~	1.72s	1.75s	p=0.067 n=6
Check Time	2.99s (± 0.51%)	2.99s (± 0.25%)	~	2.98s	3.00s	p=0.363 n=6
Emit Time	0.09s (± 5.53%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=0.174 n=6
Total Time	9.11s (± 0.28%)	9.07s (± 0.24%)	-0.04s (- 0.49%)	9.04s	9.10s	p=0.019 n=6
Angular - node (v14.15.1, x64)
Memory used	352,779k (± 0.00%)	352,780k (± 0.00%)	~	352,767k	352,807k	p=0.936 n=6
Parse Time	3.76s (± 0.50%)	3.71s (± 0.37%)	-0.05s (- 1.24%)	3.70s	3.73s	p=0.007 n=6
Bind Time	1.26s (± 0.67%)	1.25s (± 0.44%)	-0.01s (- 0.80%)	1.24s	1.25s	p=0.038 n=6
Check Time	9.74s (± 0.62%)	9.72s (± 0.68%)	~	9.65s	9.84s	p=0.520 n=6
Emit Time	8.39s (± 0.56%)	8.34s (± 0.87%)	~	8.26s	8.45s	p=0.196 n=6
Total Time	23.16s (± 0.28%)	23.02s (± 0.56%)	-0.14s (- 0.59%)	22.88s	23.24s	p=0.045 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used	186,599k (± 0.01%)	186,614k (± 0.02%)	~	186,563k	186,645k	p=0.336 n=6
Parse Time	1.59s (± 0.65%)	1.59s (± 0.86%)	~	1.57s	1.61s	p=0.315 n=6
Bind Time	0.85s (± 0.61%)	0.84s (± 0.49%)	-0.01s (- 0.98%)	0.83s	0.84s	p=0.022 n=6
Check Time	10.21s (± 0.15%)	10.19s (± 0.67%)	~	10.11s	10.28s	p=0.806 n=6
Emit Time	3.13s (± 0.96%)	3.12s (± 0.99%)	~	3.08s	3.17s	p=0.624 n=6
Total Time	15.78s (± 0.20%)	15.73s (± 0.44%)	~	15.63s	15.79s	p=0.258 n=6
Monaco - node (v14.15.1, x64)
Memory used	338,068k (± 0.01%)	338,056k (± 0.01%)	~	338,026k	338,083k	p=1.000 n=6
Parse Time	2.91s (± 0.40%)	2.89s (± 0.28%)	-0.02s (- 0.52%)	2.88s	2.90s	p=0.048 n=6
Bind Time	1.09s (± 0.47%)	1.09s (± 0.69%)	~	1.08s	1.10s	p=0.784 n=6
Check Time	8.10s (± 0.19%)	8.08s (± 0.35%)	~	8.05s	8.12s	p=0.357 n=6
Emit Time	4.69s (± 1.27%)	4.68s (± 1.06%)	~	4.63s	4.76s	p=0.810 n=6
Total Time	16.79s (± 0.44%)	16.75s (± 0.35%)	~	16.70s	16.86s	p=0.296 n=6
TFS - node (v14.15.1, x64)
Memory used	294,260k (± 0.00%)	294,257k (± 0.00%)	~	294,237k	294,269k	p=0.810 n=6
Parse Time	2.40s (± 0.63%)	2.39s (± 0.89%)	~	2.37s	2.43s	p=0.139 n=6
Bind Time	1.08s (± 0.91%)	1.07s (± 1.45%)	~	1.06s	1.09s	p=0.149 n=6
Check Time	7.45s (± 0.38%)	7.49s (± 0.40%)	+0.04s (+ 0.49%)	7.43s	7.52s	p=0.029 n=6
Emit Time	4.30s (± 1.34%)	4.30s (± 0.69%)	~	4.27s	4.34s	p=0.809 n=6
Total Time	15.24s (± 0.37%)	15.24s (± 0.45%)	~	15.13s	15.31s	p=0.810 n=6
material-ui - node (v14.15.1, x64)
Memory used	471,351k (± 0.00%)	471,378k (± 0.00%)	~	471,369k	471,388k	p=0.066 n=6
Parse Time	3.51s (± 0.38%)	3.51s (± 0.36%)	~	3.49s	3.52s	p=0.788 n=6
Bind Time	1.00s (± 0.81%)	1.00s (± 0.52%)	~	0.99s	1.00s	p=0.140 n=6
Check Time	18.95s (± 0.55%)	19.00s (± 0.43%)	~	18.94s	19.14s	p=0.809 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	23.46s (± 0.46%)	23.50s (± 0.38%)	~	23.44s	23.66s	p=0.936 n=6
xstate - node (v14.15.1, x64)
Memory used	534,456k (± 0.01%)	534,448k (± 0.00%)	~	534,420k	534,480k	p=1.000 n=6
Parse Time	4.61s (± 0.59%)	4.57s (± 0.33%)	-0.04s (- 0.76%)	4.56s	4.60s	p=0.024 n=6
Bind Time	1.67s (± 0.73%)	1.66s (± 0.62%)	~	1.64s	1.67s	p=0.210 n=6
Check Time	3.15s (± 0.84%)	3.14s (± 0.47%)	~	3.12s	3.16s	p=0.419 n=6
Emit Time	0.10s (± 4.15%)	0.10s (± 0.00%)	~	0.10s	0.10s	p=0.405 n=6
Total Time	9.54s (± 0.41%)	9.48s (± 0.34%)	-0.06s (- 0.58%)	9.44s	9.52s	p=0.020 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52949	6
Baseline	main	6

TSServer

Comparison Report - main..52949

Metric	main	52949	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,362ms (± 0.75%)	2,375ms (± 0.62%)	~	2,351ms	2,391ms	p=0.261 n=6
Req 2 - geterr	5,313ms (± 0.85%)	5,285ms (± 0.41%)	~	5,255ms	5,315ms	p=0.378 n=6
Req 3 - references	338ms (± 0.73%)	338ms (± 0.60%)	~	336ms	342ms	p=0.806 n=6
Req 4 - navto	286ms (± 0.79%)	284ms (± 1.25%)	~	280ms	289ms	p=0.291 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	72ms (± 1.14%)	72ms (± 4.21%)	~	70ms	78ms	p=0.451 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,482ms (± 0.99%)	2,465ms (± 0.64%)	~	2,450ms	2,483ms	p=0.148 n=6
Req 2 - geterr	3,988ms (± 0.56%)	3,975ms (± 0.63%)	~	3,933ms	4,011ms	p=0.298 n=6
Req 3 - references	351ms (± 0.58%)	354ms (± 1.18%)	~	351ms	362ms	p=0.285 n=6
Req 4 - navto	293ms (± 0.35%)	292ms (± 0.60%)	~	290ms	295ms	p=0.162 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	68ms (± 1.79%)	68ms (± 1.24%)	~	67ms	69ms	p=1.000 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,170ms (± 0.73%)	3,153ms (± 0.59%)	~	3,139ms	3,182ms	p=0.128 n=6
Req 2 - geterr	1,608ms (± 0.87%)	1,611ms (± 0.86%)	~	1,588ms	1,627ms	p=0.810 n=6
Req 3 - references	102ms (± 1.18%)	103ms (± 2.74%)	~	100ms	108ms	p=0.935 n=6
Req 4 - navto	359ms (± 0.69%)	359ms (± 1.16%)	~	355ms	366ms	p=0.872 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	431ms (± 0.72%)	429ms (± 1.47%)	~	418ms	436ms	p=0.627 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,536ms (± 1.00%)	2,523ms (± 0.43%)	~	2,515ms	2,543ms	p=0.199 n=6
Req 2 - geterr	5,714ms (± 0.38%)	5,691ms (± 0.73%)	~	5,651ms	5,766ms	p=0.173 n=6
Req 3 - references	353ms (± 1.44%)	354ms (± 1.14%)	~	348ms	360ms	p=0.872 n=6
Req 4 - navto	279ms (± 0.64%)	280ms (± 0.29%)	~	279ms	281ms	p=0.677 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	82ms (± 4.40%)	83ms (± 4.63%)	~	76ms	87ms	p=0.627 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,665ms (± 0.43%)	2,653ms (± 0.36%)	~	2,641ms	2,668ms	p=0.078 n=6
Req 2 - geterr	4,363ms (± 0.59%)	4,352ms (± 0.31%)	~	4,339ms	4,377ms	p=0.261 n=6
Req 3 - references	363ms (± 1.25%)	365ms (± 1.27%)	~	358ms	370ms	p=0.466 n=6
Req 4 - navto	292ms (± 1.38%)	286ms (± 1.08%)	-6ms (- 1.89%)	283ms	290ms	p=0.036 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	74ms (± 1.87%)	73ms (± 1.22%)	~	72ms	74ms	p=0.673 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,345ms (± 0.19%)	3,332ms (± 0.43%)	~	3,309ms	3,349ms	p=0.128 n=6
Req 2 - geterr	1,804ms (± 3.77%)	1,866ms (± 5.65%)	~	1,751ms	1,983ms	p=0.378 n=6
Req 3 - references	111ms (± 0.74%)	109ms (± 1.58%)	~	107ms	111ms	p=0.183 n=6
Req 4 - navto	348ms (± 1.34%)	343ms (± 1.21%)	~	337ms	348ms	p=0.169 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	436ms (± 1.40%)	437ms (± 1.39%)	~	426ms	443ms	p=0.936 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,578ms (± 0.14%)	2,581ms (± 0.41%)	~	2,565ms	2,591ms	p=0.378 n=6
Req 2 - geterr	6,019ms (± 0.18%)	6,034ms (± 0.51%)	~	5,997ms	6,089ms	p=0.423 n=6
Req 3 - references	367ms (± 0.87%)	365ms (± 0.75%)	~	361ms	369ms	p=0.421 n=6
Req 4 - navto	276ms (± 0.27%)	276ms (± 0.46%)	~	274ms	278ms	p=0.788 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	101ms (± 0.63%)	101ms (± 0.63%)	~	100ms	102ms	p=1.000 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,793ms (± 0.75%)	2,811ms (± 0.43%)	~	2,793ms	2,828ms	p=0.173 n=6
Req 2 - geterr	4,566ms (± 2.27%)	4,453ms (± 1.66%)	~	4,393ms	4,599ms	p=0.065 n=6
Req 3 - references	381ms (± 0.68%)	377ms (± 0.57%)	-4ms (- 0.96%)	374ms	380ms	p=0.036 n=6
Req 4 - navto	293ms (± 1.28%)	295ms (± 1.05%)	~	289ms	298ms	p=0.571 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	83ms (± 1.27%)	90ms (± 9.73%)	+7ms (+ 8.89%)	82ms	101ms	p=0.035 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,675ms (± 0.30%)	3,665ms (± 0.94%)	~	3,640ms	3,731ms	p=0.173 n=6
Req 2 - geterr	1,837ms (± 0.43%)	1,851ms (± 0.37%)	+14ms (+ 0.75%)	1,839ms	1,858ms	p=0.016 n=6
Req 3 - references	126ms (± 2.70%)	127ms (± 3.69%)	~	122ms	133ms	p=0.686 n=6
Req 4 - navto	380ms (± 2.17%)	377ms (± 0.91%)	~	372ms	381ms	p=0.374 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	455ms (± 2.26%)	452ms (± 0.95%)	~	445ms	456ms	p=0.229 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52949	6
Baseline	main	6

Startup

Comparison Report - main..52949

Metric	main	52949	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	142.71ms (± 0.20%)	142.77ms (± 0.21%)	+0.07ms (+ 0.05%)	142.13ms	147.71ms	p=0.002 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	227.74ms (± 0.19%)	227.86ms (± 0.19%)	+0.11ms (+ 0.05%)	226.74ms	234.61ms	p=0.001 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	229.15ms (± 0.15%)	230.35ms (± 0.30%)	+1.20ms (+ 0.53%)	228.46ms	237.38ms	p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	210.01ms (± 0.18%)	212.02ms (± 0.38%)	+2.01ms (+ 0.96%)	209.29ms	218.50ms	p=0.000 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	52949	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/52949/merge:

Everything looks good!

[rbuckton]

This exists because the result for Awaited<null> in strictNullChecks: false is never, when it should be null (or even any, but certainly not never):

TypeScript Playground

[rbuckton]

• the test suite lacks the appropriate test case

This seems to be the case. We need to add a test for both Awaited<null> and Awaited<undefined> in tests/cases/compiler/awaitedtype.ts and tests/cases/compiler/awaitedTypeStrictNull.ts.

[rbuckton]

#52960 adds the missing tests. I have also verified that they do report a baseline change if the T extends null | undefined branch is removed.