Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Pick PR #52984 (Check for strict subtypes and then ...) into release-5.0 #53085

Conversation

typescript-bot
Copy link
Collaborator

This cherry-pick was triggered by a request on #52984
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @jakebailey

Component commits:
b3d3ec9 Use strictSubtypeRelation in getNarrowedType and narrow only for pure subtypes

0325f9d Accept new baselines

3df807f First check for strict subtypes, then check for regular subtypes

d737eee Accept new baselines

9b2d602 Add tests

9ea8a55 Accept new baselines

8bb30e2 Add another repro
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 4, 2023
@jakebailey jakebailey added this to the TypeScript 5.0.2 milestone Mar 4, 2023
@DanielRosenwasser
Copy link
Member

I tested the top 250 between latest and rc, and that run is over at #53122. I don't see any issues, so I am going to merge.

@DanielRosenwasser DanielRosenwasser merged commit 79bdd93 into microsoft:release-5.0 Mar 7, 2023
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Mar 7, 2023

Actually, there are two issues that may be notable:

examples/mega-form/tsconfig.json
error TS2589: Type instantiation is excessively deep and possibly infinite.
examples/mega-form/src/App.tsx#L17

boilerplate/tsconfig.json
error TS2345: Argument of type '[never, never]' is not assignable to parameter of type 'never'.
boilerplate/app/navigators/navigationUtilities.ts#L156

But I don't think they're related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants