Force add lib in workflows which commit LKG #53248
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
|
I am wondering if it'd be easier to just remove it from the gitignore on the branch, though. Not sure if that's more error prone (via accidentally merging it back) or not. |
| git add tests/baselines/reference/api/typescript.d.ts | ||
| git add tests/baselines/reference/api/tsserverlibrary.d.ts | ||
| git add ./lib | ||
| git add --force ./lib |
There was a problem hiding this comment.
Actually, do we run this on main? If we run this on main to bump the version, then this isn't a good idea. @DanielRosenwasser what do you do when you bump main's version?
There was a problem hiding this comment.
I do not run set-version on main, I set it manually.
| git add tests/baselines/reference/api/typescript.d.ts | ||
| git add tests/baselines/reference/api/tsserverlibrary.d.ts | ||
| git add ./lib | ||
| git add --force ./lib |
There was a problem hiding this comment.
I'm a little worried that this will work the first time, then be annoying when pulling in main another time because we'll need to force it to be included. If we use the "update-lkg" workflow to do it, then it probably will be fine, but if being done manually, it might get weird.
Maybe I should just make it remove the ignore from .gitignore?
|
Going to stick with |
4 participants
Follow-up to #52226; these need to be force added now that
libis gitignored.