-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(53204): Bug: __runInitializers(this) is emitted before super() call #53268
Conversation
Should we do one last cherry-pick/LKG if we can get the fix in today? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern of findSuperStatementIndex
is already used by both the ts transform (see transformConstructorBody
) and the classFields transform (see transformConstructorBody
); it seems like it'd be best to be able to fix these in such a way that we don't have to fix this bug over and over again, but, I'm not sure what that looks like.
So, LGTM, but I don't think my +1 should be the determining factor in if this fix is final or backportable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we have an error if super()
doesn't appear at the top level, I think we can bring this in.
@typescript-bot pack this |
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 9ce2780. You can monitor the build here. |
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
Hey @DanielRosenwasser, I've opened #53273 for you. |
…e-5.0 (#53273) Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
…to release-5.0 (microsoft#53273) Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
Fixes #53204