Skip to content

Reset type resolution stack when starting to compute variance #53549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2023
Merged

Reset type resolution stack when starting to compute variance #53549

merged 1 commit into from
Apr 11, 2023

Conversation

gabritto
Copy link
Member

@gabritto gabritto commented Mar 27, 2023 •
edited
Loading

Fixes #53470

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 27, 2023
@gabritto
Copy link
Member Author

@typescript-bot test this
@typescript-bot run DT
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test top100
@typescript-bot test tsserver top100
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @gabritto, I've started to run the diff-based user code test suite (tsserver) on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @gabritto, I've started to run the diff-based user code test suite on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @gabritto, I've started to run the perf test suite on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @gabritto, I've started to run the extended test suite on this PR at 3a2bbb3. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @gabritto, I've started to run the diff-based top-repos suite (tsserver) on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the user test suite comparing main and refs/pull/53549/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

  • [MISSING] error TS7023: '_get' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the user test suite comparing main and refs/pull/53549/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/53549/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/53549/merge:

Something interesting changed - please have a look.

Details

vercel/hyper

⚠️ Note that built had errors ⚠️ 
Timed out after 600000 ms

🎉 New server no longer has errors 🎉

@jakebailey
Copy link
Member

Huh, does the previous comment imply that 5.0 is hanging in this repo?

@jakebailey
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 3a2bbb3. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2023 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/151176/artifacts?artifactName=tgz&fileId=8D2E46C8B9243D607A68134078111BDC43ED99DC561A23F409F340BCA9DE1C6002&fileName=/typescript-5.1.0-insiders.20230328.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53549-16".;

@jakebailey
Copy link
Member

jakebailey commented Mar 28, 2023 •
edited
Loading

So, testing, this seems to almost fix #52892. Compare:

Some of the errors go away, which is good, but uncommenting that static block still seems to change the result. Not sure why exactly, but it at least an improvement.

@typescript-bot
Copy link
Collaborator

@gabritto
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53549
Metric main 53549 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 362,331k (± 0.01%) 362,329k (± 0.01%) ~ 362,301k 362,369k p=0.873 n=6
Parse Time 3.36s (± 0.42%) 3.38s (± 0.58%) +0.02s (+ 0.74%) 3.36s 3.42s p=0.033 n=6
Bind Time 1.12s (± 0.94%) 1.12s (± 0.00%) ~ 1.12s 1.12s p=0.293 n=6
Check Time 8.69s (± 0.48%) 8.69s (± 0.45%) ~ 8.65s 8.75s p=0.809 n=6
Emit Time 7.52s (± 0.96%) 7.50s (± 1.14%) ~ 7.43s 7.61s p=0.630 n=6
Total Time 20.69s (± 0.55%) 20.70s (± 0.58%) ~ 20.60s 20.91s p=0.936 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,703k (± 1.20%) 192,680k (± 1.50%) ~ 190,762k 196,494k p=0.149 n=6
Parse Time 1.49s (± 1.68%) 1.50s (± 0.70%) ~ 1.48s 1.51s p=0.805 n=6
Bind Time 0.77s (± 0.67%) 0.77s (± 0.53%) ~ 0.76s 0.77s p=0.114 n=6
Check Time 9.58s (± 0.48%) 9.65s (± 0.54%) ~ 9.58s 9.72s p=0.054 n=6
Emit Time 2.73s (± 1.00%) 2.74s (± 0.44%) ~ 2.72s 2.75s p=1.000 n=6
Total Time 14.58s (± 0.29%) 14.65s (± 0.42%) ~ 14.57s 14.73s p=0.066 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,421k (± 0.01%) 346,452k (± 0.01%) ~ 346,415k 346,475k p=0.093 n=6
Parse Time 2.57s (± 1.20%) 2.59s (± 1.21%) ~ 2.56s 2.63s p=0.468 n=6
Bind Time 1.01s (± 0.97%) 1.01s (± 0.81%) ~ 1.00s 1.02s p=0.862 n=6
Check Time 7.15s (± 0.46%) 7.13s (± 0.48%) ~ 7.08s 7.17s p=0.288 n=6
Emit Time 4.26s (± 1.19%) 4.25s (± 0.73%) ~ 4.21s 4.29s p=0.630 n=6
Total Time 14.99s (± 0.65%) 14.98s (± 0.47%) ~ 14.89s 15.09s p=0.936 n=6
TFS - node (v18.10.0, x64)
Memory used 300,677k (± 0.01%) 300,663k (± 0.01%) ~ 300,633k 300,686k p=0.423 n=6
Parse Time 2.06s (± 0.80%) 2.07s (± 0.71%) ~ 2.05s 2.09s p=0.188 n=6
Bind Time 1.14s (± 0.72%) 1.14s (± 0.72%) ~ 1.13s 1.15s p=0.787 n=6
Check Time 6.53s (± 0.45%) 6.55s (± 0.28%) ~ 6.52s 6.57s p=0.418 n=6
Emit Time 3.85s (± 0.91%) 3.85s (± 0.95%) ~ 3.80s 3.91s p=0.935 n=6
Total Time 13.57s (± 0.39%) 13.61s (± 0.34%) ~ 13.53s 13.66s p=0.258 n=6
material-ui - node (v18.10.0, x64)
Memory used 477,185k (± 0.01%) 477,180k (± 0.00%) ~ 477,150k 477,199k p=0.378 n=6
Parse Time 3.03s (± 2.23%) 2.98s (± 2.38%) ~ 2.92s 3.10s p=0.376 n=6
Bind Time 0.93s (± 6.84%) 1.01s (± 7.20%) ~ 0.92s 1.08s p=0.052 n=6
Check Time 17.14s (± 0.43%) 17.28s (± 1.14%) ~ 17.09s 17.63s p=0.198 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.09s (± 0.35%) 21.27s (± 1.05%) ~ 21.03s 21.64s p=0.128 n=6
xstate - node (v18.10.0, x64)
Memory used 552,950k (± 0.01%) 553,027k (± 0.02%) ~ 552,802k 553,139k p=0.230 n=6
Parse Time 3.75s (± 0.73%) 3.79s (± 0.49%) ~ 3.76s 3.81s p=0.062 n=6
Bind Time 1.66s (± 0.54%) 1.67s (± 0.50%) ~ 1.65s 1.67s p=0.339 n=6
Check Time 2.83s (± 0.41%) 2.86s (± 0.85%) ~ 2.83s 2.89s p=0.062 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.34s (± 0.32%) 8.39s (± 0.37%) +0.05s (+ 0.64%) 8.35s 8.44s p=0.019 n=6
Angular - node (v16.17.1, x64)
Memory used 361,718k (± 0.01%) 361,677k (± 0.01%) -41k (- 0.01%) 361,640k 361,723k p=0.045 n=6
Parse Time 3.53s (± 0.81%) 3.52s (± 0.64%) ~ 3.50s 3.56s p=0.678 n=6
Bind Time 1.18s (± 0.99%) 1.19s (± 0.69%) ~ 1.18s 1.20s p=0.401 n=6
Check Time 9.51s (± 0.22%) 9.50s (± 0.42%) ~ 9.46s 9.55s p=0.517 n=6
Emit Time 7.96s (± 0.76%) 7.97s (± 0.50%) ~ 7.90s 8.01s p=0.686 n=6
Total Time 22.18s (± 0.37%) 22.18s (± 0.29%) ~ 22.10s 22.28s p=1.000 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,581k (± 0.88%) 193,639k (± 0.86%) ~ 192,493k 195,885k p=0.471 n=6
Parse Time 1.58s (± 1.09%) 1.60s (± 0.47%) ~ 1.59s 1.61s p=0.062 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.66%) ~ 0.82s 0.83s p=0.282 n=6
Check Time 10.30s (± 0.43%) 10.37s (± 0.74%) ~ 10.22s 10.43s p=0.066 n=6
Emit Time 2.99s (± 0.61%) 2.98s (± 0.54%) ~ 2.97s 3.01s p=0.215 n=6
Total Time 15.70s (± 0.35%) 15.77s (± 0.35%) +0.07s (+ 0.44%) 15.66s 15.81s p=0.045 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,729k (± 0.01%) 345,776k (± 0.01%) +47k (+ 0.01%) 345,741k 345,794k p=0.008 n=6
Parse Time 2.72s (± 0.43%) 2.72s (± 0.50%) ~ 2.69s 2.73s p=0.864 n=6
Bind Time 1.08s (± 0.95%) 1.09s (± 0.37%) ~ 1.08s 1.09s p=0.257 n=6
Check Time 7.80s (± 0.44%) 7.84s (± 0.26%) +0.04s (+ 0.53%) 7.81s 7.87s p=0.030 n=6
Emit Time 4.45s (± 0.39%) 4.48s (± 0.94%) ~ 4.42s 4.54s p=0.226 n=6
Total Time 16.06s (± 0.32%) 16.13s (± 0.27%) +0.07s (+ 0.42%) 16.05s 16.17s p=0.037 n=6
TFS - node (v16.17.1, x64)
Memory used 300,020k (± 0.01%) 300,022k (± 0.00%) ~ 300,002k 300,035k p=1.000 n=6
Parse Time 2.16s (± 0.62%) 2.17s (± 0.94%) ~ 2.15s 2.20s p=0.290 n=6
Bind Time 1.24s (± 0.83%) 1.23s (± 0.84%) ~ 1.22s 1.25s p=0.560 n=6
Check Time 7.22s (± 0.73%) 7.20s (± 0.40%) ~ 7.16s 7.24s p=0.520 n=6
Emit Time 4.37s (± 1.05%) 4.38s (± 0.70%) ~ 4.34s 4.42s p=0.687 n=6
Total Time 14.99s (± 0.63%) 14.98s (± 0.32%) ~ 14.92s 15.04s p=0.936 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,458k (± 0.01%) 476,479k (± 0.00%) ~ 476,454k 476,503k p=0.093 n=6
Parse Time 3.22s (± 0.38%) 3.22s (± 0.48%) ~ 3.20s 3.24s p=0.739 n=6
Bind Time 0.95s (± 0.54%) 0.95s (± 0.00%) ~ 0.95s 0.95s p=0.174 n=6
Check Time 18.21s (± 0.37%) 18.17s (± 0.41%) ~ 18.07s 18.30s p=0.467 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.39s (± 0.28%) 22.34s (± 0.38%) ~ 22.23s 22.49s p=0.422 n=6
xstate - node (v16.17.1, x64)
Memory used 550,607k (± 0.02%) 550,485k (± 0.02%) -122k (- 0.02%) 550,419k 550,647k p=0.031 n=6
Parse Time 3.93s (± 0.49%) 3.94s (± 0.44%) ~ 3.92s 3.96s p=0.318 n=6
Bind Time 1.76s (± 0.43%) 1.75s (± 0.29%) ~ 1.75s 1.76s p=0.247 n=6
Check Time 3.09s (± 1.02%) 3.08s (± 0.69%) ~ 3.05s 3.11s p=0.746 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.87s (± 0.60%) 8.87s (± 0.32%) ~ 8.84s 8.91s p=0.685 n=6
Angular - node (v14.15.1, x64)
Memory used 355,570k (± 0.01%) 355,563k (± 0.01%) ~ 355,536k 355,599k p=0.336 n=6
Parse Time 3.62s (± 1.12%) 3.64s (± 1.09%) ~ 3.59s 3.71s p=0.422 n=6
Bind Time 1.22s (± 0.73%) 1.22s (± 0.68%) ~ 1.22s 1.24s p=0.437 n=6
Check Time 9.90s (± 0.36%) 9.93s (± 0.18%) ~ 9.91s 9.95s p=0.089 n=6
Emit Time 8.40s (± 1.18%) 8.41s (± 0.90%) ~ 8.33s 8.51s p=0.873 n=6
Total Time 23.14s (± 0.56%) 23.21s (± 0.49%) ~ 23.05s 23.36s p=0.261 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,789k (± 0.02%) 187,760k (± 0.01%) ~ 187,722k 187,802k p=0.173 n=6
Parse Time 1.59s (± 0.52%) 1.61s (± 0.32%) +0.01s (+ 0.73%) 1.60s 1.61s p=0.033 n=6
Bind Time 0.85s (± 0.61%) 0.85s (± 0.60%) ~ 0.85s 0.86s p=0.069 n=6
Check Time 10.39s (± 0.25%) 10.54s (± 0.52%) +0.15s (+ 1.44%) 10.45s 10.62s p=0.005 n=6
Emit Time 3.14s (± 0.63%) 3.15s (± 0.55%) ~ 3.12s 3.17s p=0.368 n=6
Total Time 15.97s (± 0.19%) 16.15s (± 0.40%) +0.18s (+ 1.13%) 16.05s 16.25s p=0.005 n=6
Monaco - node (v14.15.1, x64)
Memory used 340,614k (± 0.01%) 340,628k (± 0.01%) ~ 340,580k 340,677k p=0.521 n=6
Parse Time 2.81s (± 0.29%) 2.84s (± 0.59%) +0.03s (+ 0.95%) 2.81s 2.85s p=0.026 n=6
Bind Time 1.10s (± 0.74%) 1.10s (± 0.37%) ~ 1.09s 1.10s p=0.584 n=6
Check Time 8.15s (± 0.30%) 8.18s (± 0.54%) ~ 8.15s 8.26s p=0.567 n=6
Emit Time 4.67s (± 0.63%) 4.68s (± 0.65%) ~ 4.64s 4.72s p=0.520 n=6
Total Time 16.73s (± 0.23%) 16.80s (± 0.24%) +0.07s (+ 0.40%) 16.74s 16.86s p=0.029 n=6
TFS - node (v14.15.1, x64)
Memory used 295,094k (± 0.00%) 295,116k (± 0.00%) +22k (+ 0.01%) 295,108k 295,124k p=0.008 n=6
Parse Time 2.37s (± 1.12%) 2.39s (± 0.72%) ~ 2.36s 2.41s p=0.188 n=6
Bind Time 1.06s (± 0.00%) 1.06s (± 0.49%) ~ 1.06s 1.07s p=0.174 n=6
Check Time 7.52s (± 0.25%) 7.53s (± 0.25%) ~ 7.51s 7.56s p=0.255 n=6
Emit Time 4.28s (± 0.55%) 4.31s (± 1.30%) ~ 4.24s 4.38s p=0.259 n=6
Total Time 15.23s (± 0.33%) 15.30s (± 0.42%) ~ 15.19s 15.36s p=0.093 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,986k (± 0.01%) 471,974k (± 0.01%) ~ 471,935k 472,009k p=0.689 n=6
Parse Time 3.33s (± 0.49%) 3.37s (± 0.35%) +0.03s (+ 1.00%) 3.35s 3.38s p=0.012 n=6
Bind Time 0.99s (± 0.90%) 0.99s (± 1.22%) ~ 0.98s 1.01s p=0.676 n=6
Check Time 19.06s (± 0.46%) 19.19s (± 0.50%) +0.13s (+ 0.69%) 19.09s 19.34s p=0.029 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.38s (± 0.39%) 23.55s (± 0.45%) +0.17s (+ 0.73%) 23.44s 23.72s p=0.031 n=6
xstate - node (v14.15.1, x64)
Memory used 539,171k (± 0.01%) 539,191k (± 0.01%) ~ 539,134k 539,258k p=0.575 n=6
Parse Time 4.23s (± 0.62%) 4.24s (± 0.49%) ~ 4.20s 4.26s p=0.746 n=6
Bind Time 1.65s (± 0.46%) 1.66s (± 0.54%) ~ 1.65s 1.67s p=0.149 n=6
Check Time 3.19s (± 1.14%) 3.20s (± 0.36%) ~ 3.18s 3.21s p=0.459 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.16s (± 0.54%) 9.19s (± 0.25%) ~ 9.15s 9.21s p=0.521 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53549 6
Baseline main 6

TSServer

Comparison Report - main..53549
Metric main 53549 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,393ms (± 0.44%) 2,410ms (± 0.68%) ~ 2,392ms 2,427ms p=0.229 n=6
Req 2 - geterr 5,538ms (± 0.48%) 5,545ms (± 0.50%) ~ 5,508ms 5,580ms p=0.688 n=6
Req 3 - references 335ms (± 0.72%) 337ms (± 0.72%) ~ 333ms 340ms p=0.256 n=6
Req 4 - navto 281ms (± 0.65%) 282ms (± 0.54%) ~ 280ms 284ms p=0.402 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 82ms (± 3.56%) 82ms (± 3.72%) ~ 78ms 86ms p=0.935 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,508ms (± 0.93%) 2,528ms (± 1.24%) ~ 2,469ms 2,554ms p=0.149 n=6
Req 2 - geterr 4,062ms (± 0.58%) 4,075ms (± 0.52%) ~ 4,044ms 4,103ms p=0.378 n=6
Req 3 - references 349ms (± 0.71%) 348ms (± 0.80%) ~ 344ms 352ms p=0.808 n=6
Req 4 - navto 290ms (± 0.26%) 291ms (± 0.69%) ~ 289ms 294ms p=0.406 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 79ms (± 7.41%) 78ms (± 4.65%) ~ 75ms 84ms p=0.517 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,999ms (± 0.51%) 2,999ms (± 0.57%) ~ 2,984ms 3,028ms p=0.572 n=6
Req 2 - geterr 1,698ms (± 1.90%) 1,700ms (± 1.05%) ~ 1,669ms 1,722ms p=0.688 n=6
Req 3 - references 107ms (± 1.83%) 106ms (± 0.84%) ~ 105ms 107ms p=0.142 n=6
Req 4 - navto 357ms (± 0.45%) 357ms (± 0.51%) ~ 354ms 359ms p=1.000 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 384ms (± 0.75%) 382ms (± 1.84%) ~ 372ms 390ms p=0.872 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,504ms (± 0.76%) 2,517ms (± 0.73%) ~ 2,482ms 2,537ms p=0.470 n=6
Req 2 - geterr 5,885ms (± 0.45%) 5,899ms (± 0.55%) ~ 5,876ms 5,964ms p=0.689 n=6
Req 3 - references 345ms (± 0.40%) 346ms (± 0.42%) ~ 344ms 348ms p=0.084 n=6
Req 4 - navto 278ms (± 0.53%) 278ms (± 0.32%) ~ 277ms 279ms p=0.804 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 75ms (± 2.45%) 74ms (± 0.55%) ~ 73ms 74ms p=0.390 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,652ms (± 0.44%) 2,685ms (± 0.33%) +33ms (+ 1.23%) 2,668ms 2,694ms p=0.008 n=6
Req 2 - geterr 4,422ms (± 0.60%) 4,419ms (± 0.62%) ~ 4,370ms 4,448ms p=0.936 n=6
Req 3 - references 364ms (± 0.36%) 364ms (± 0.47%) ~ 362ms 366ms p=0.870 n=6
Req 4 - navto 287ms (± 0.52%) 288ms (± 0.47%) ~ 287ms 290ms p=0.114 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 77ms (± 2.59%) 77ms (± 1.91%) ~ 76ms 80ms p=0.485 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,149ms (± 0.59%) 3,147ms (± 0.40%) ~ 3,130ms 3,167ms p=0.810 n=6
Req 2 - geterr 1,852ms (± 1.75%) 1,847ms (± 0.73%) ~ 1,831ms 1,869ms p=1.000 n=6
Req 3 - references 113ms (± 0.87%) 113ms (± 1.07%) ~ 112ms 115ms p=0.498 n=6
Req 4 - navto 342ms (± 0.61%) 342ms (± 0.44%) ~ 341ms 345ms p=0.570 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 394ms (± 1.15%) 394ms (± 0.98%) ~ 390ms 399ms p=0.870 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,610ms (± 0.50%) 2,602ms (± 0.52%) ~ 2,586ms 2,623ms p=0.471 n=6
Req 2 - geterr 6,358ms (± 0.33%) 6,351ms (± 0.34%) ~ 6,320ms 6,377ms p=0.574 n=6
Req 3 - references 364ms (± 0.40%) 365ms (± 0.99%) ~ 361ms 371ms p=1.000 n=6
Req 4 - navto 281ms (± 0.70%) 282ms (± 0.70%) ~ 279ms 285ms p=0.411 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 99ms (± 8.37%) 94ms (± 7.83%) ~ 82ms 101ms p=0.064 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,805ms (± 0.36%) 2,828ms (± 0.51%) +23ms (+ 0.80%) 2,810ms 2,842ms p=0.013 n=6
Req 2 - geterr 4,791ms (± 0.22%) 4,786ms (± 0.37%) ~ 4,768ms 4,810ms p=0.688 n=6
Req 3 - references 371ms (± 0.48%) 371ms (± 0.31%) ~ 370ms 373ms p=1.000 n=6
Req 4 - navto 289ms (± 1.19%) 291ms (± 1.28%) ~ 287ms 298ms p=0.225 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 1.12%) 74ms (± 1.02%) ~ 73ms 75ms p=0.209 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,453ms (± 0.41%) 3,456ms (± 0.54%) ~ 3,427ms 3,485ms p=0.810 n=6
Req 2 - geterr 1,887ms (± 0.73%) 1,867ms (± 1.10%) ~ 1,835ms 1,894ms p=0.093 n=6
Req 3 - references 125ms (± 0.44%) 127ms (± 1.20%) +2ms (+ 1.61%) 125ms 129ms p=0.015 n=6
Req 4 - navto 373ms (± 0.24%) 373ms (± 0.63%) ~ 370ms 376ms p=0.806 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 412ms (± 1.43%) 406ms (± 0.77%) ~ 403ms 410ms p=0.090 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53549 6
Baseline main 6

Startup

Comparison Report - main..53549
Metric main 53549 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.50ms (± 0.17%) 142.14ms (± 0.21%) +0.65ms (+ 0.46%) 141.32ms 145.64ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.47ms (± 0.15%) 230.73ms (± 0.47%) +4.27ms (+ 1.88%) 226.86ms 236.37ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.43ms (± 0.18%) 231.41ms (± 0.39%) +2.98ms (+ 1.30%) 228.36ms 238.29ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.21ms (± 0.17%) 211.84ms (± 0.36%) +2.63ms (+ 1.26%) 209.00ms 217.49ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53549 6
Baseline main 6

Developer Information:

Download Benchmark

@DanielRosenwasser DanielRosenwasser mentioned this pull request Mar 28, 2023
Closed
@gabritto
Copy link
Member Author

So, testing, this seems to almost fix #52892. Compare:

Some of the errors go away, which is good, but uncommenting that static block still seems to change the result. Not sure why exactly, but it at least an improvement.

That is intriguing. But the correct behavior is to have the one error at A.B<A<T>>, no?

@jakebailey
Copy link
Member

I don't think so; uncomment the static block and note that the error goes away. But, it could be two issues in one.

@gabritto
Copy link
Member Author

I don't think so; uncomment the static block and note that the error goes away. But, it could be two issues in one.

I meant to say I think the leftover bug is the fact that the error goes away in the presence of the static block, when it shouldn't go away.

@jakebailey
Copy link
Member

Ah, yes, correct.

@gabritto gabritto changed the title reset type resolution stack when starting to compute variance Reset type resolution stack when starting to compute variance Mar 28, 2023
@gabritto gabritto marked this pull request as ready for review March 28, 2023 19:41
@gabritto gabritto merged commit 2db688e into main Apr 11, 2023
@gabritto gabritto deleted the gabritto/issue53470 branch April 11, 2023 21:05
@Andarist Andarist mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@gabritto gabritto

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Computing variance causes circularity error
4 participants
@gabritto @typescript-bot @jakebailey @weswigham