Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat TemplateExpression as possibly discriminant values #53903

Closed
wants to merge 1 commit into from
Closed

Treat TemplateExpression as possibly discriminant values #53903

wants to merge 1 commit into from

Conversation

Andarist
Copy link
Contributor

fixes the case based on which #53888 was created but it doesn't fix the case with which it was created 😅

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 18, 2023
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@jakebailey
Copy link
Member

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 0c66314. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 0c66314. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2023 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/152844/artifacts?artifactName=tgz&fileId=A1D97AECE465788DD56A58BE9EA362D7EC321DED81E66C7BCE8F81C6169D319D02&fileName=/typescript-5.1.0-insiders.20230418.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53903-8".;

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53903/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53903

Metric main 53903 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 365,132k (± 0.01%) 365,158k (± 0.01%) ~ 365,108k 365,197k p=0.093 n=6
Parse Time 3.53s (± 0.55%) 3.54s (± 0.42%) ~ 3.52s 3.56s p=0.255 n=6
Bind Time 1.18s (± 0.44%) 1.18s (± 0.83%) ~ 1.17s 1.19s p=0.931 n=6
Check Time 9.51s (± 0.53%) 9.52s (± 0.46%) ~ 9.46s 9.56s p=0.809 n=6
Emit Time 7.89s (± 0.59%) 7.96s (± 0.79%) ~ 7.90s 8.06s p=0.090 n=6
Total Time 22.10s (± 0.28%) 22.20s (± 0.45%) ~ 22.09s 22.34s p=0.199 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,202k (± 0.75%) 192,648k (± 0.04%) ~ 192,512k 192,719k p=0.689 n=6
Parse Time 1.58s (± 1.24%) 1.59s (± 0.51%) ~ 1.58s 1.60s p=0.411 n=6
Bind Time 0.82s (± 0.50%) 0.83s (± 0.76%) +0.01s (+ 1.43%) 0.82s 0.84s p=0.009 n=6
Check Time 10.17s (± 0.50%) 10.24s (± 0.33%) +0.07s (+ 0.72%) 10.21s 10.28s p=0.019 n=6
Emit Time 2.97s (± 0.58%) 2.98s (± 0.45%) ~ 2.96s 3.00s p=0.622 n=6
Total Time 15.54s (± 0.27%) 15.64s (± 0.29%) +0.10s (+ 0.63%) 15.59s 15.69s p=0.020 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,768k (± 0.00%) 345,761k (± 0.01%) ~ 345,728k 345,853k p=0.128 n=6
Parse Time 2.72s (± 0.38%) 2.72s (± 0.38%) ~ 2.71s 2.74s p=0.391 n=6
Bind Time 1.09s (± 0.82%) 1.08s (± 0.96%) ~ 1.06s 1.09s p=0.054 n=6
Check Time 7.81s (± 0.45%) 7.82s (± 0.86%) ~ 7.76s 7.93s p=0.872 n=6
Emit Time 4.44s (± 0.66%) 4.44s (± 0.73%) ~ 4.41s 4.50s p=1.000 n=6
Total Time 16.05s (± 0.38%) 16.07s (± 0.54%) ~ 15.99s 16.19s p=0.872 n=6
TFS - node (v16.17.1, x64)
Memory used 300,054k (± 0.01%) 300,044k (± 0.01%) ~ 300,015k 300,063k p=0.230 n=6
Parse Time 2.16s (± 0.74%) 2.16s (± 0.56%) ~ 2.14s 2.17s p=1.000 n=6
Bind Time 1.25s (± 1.31%) 1.25s (± 0.94%) ~ 1.24s 1.27s p=0.932 n=6
Check Time 7.21s (± 0.68%) 7.21s (± 0.45%) ~ 7.16s 7.25s p=0.809 n=6
Emit Time 4.36s (± 1.46%) 4.35s (± 0.93%) ~ 4.31s 4.43s p=0.936 n=6
Total Time 14.97s (± 0.77%) 14.97s (± 0.45%) ~ 14.90s 15.07s p=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,550k (± 0.01%) 481,599k (± 0.01%) ~ 481,524k 481,660k p=0.173 n=6
Parse Time 3.26s (± 0.61%) 3.25s (± 0.57%) ~ 3.23s 3.27s p=0.452 n=6
Bind Time 0.95s (± 0.67%) 0.94s (± 0.86%) ~ 0.93s 0.95s p=0.177 n=6
Check Time 17.97s (± 0.68%) 17.87s (± 0.69%) ~ 17.75s 18.03s p=0.127 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.17s (± 0.63%) 22.06s (± 0.61%) ~ 21.93s 22.24s p=0.199 n=6
xstate - node (v16.17.1, x64)
Memory used 561,294k (± 0.02%) 561,344k (± 0.03%) ~ 561,180k 561,605k p=0.810 n=6
Parse Time 4.04s (± 0.41%) 4.05s (± 0.47%) ~ 4.02s 4.07s p=0.324 n=6
Bind Time 1.77s (± 0.43%) 1.77s (± 0.50%) ~ 1.76s 1.78s p=0.798 n=6
Check Time 3.03s (± 0.54%) 3.03s (± 0.34%) ~ 3.02s 3.05s p=1.000 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.94s (± 0.35%) 8.94s (± 0.16%) ~ 8.92s 8.96s p=1.000 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53903 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member

I don't believe you

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53903

Metric main 53903 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 365,132k (± 0.01%) 365,157k (± 0.01%) ~ 365,102k 365,217k p=0.471 n=6
Parse Time 3.53s (± 0.55%) 3.53s (± 0.58%) ~ 3.51s 3.57s p=1.000 n=6
Bind Time 1.18s (± 0.44%) 1.17s (± 0.47%) ~ 1.17s 1.18s p=0.640 n=6
Check Time 9.51s (± 0.53%) 9.51s (± 0.51%) ~ 9.44s 9.59s p=1.000 n=6
Emit Time 7.89s (± 0.59%) 7.92s (± 0.39%) ~ 7.89s 7.97s p=0.227 n=6
Total Time 22.10s (± 0.28%) 22.14s (± 0.25%) ~ 22.08s 22.24s p=0.936 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,202k (± 0.75%) 192,626k (± 0.03%) ~ 192,525k 192,676k p=0.936 n=6
Parse Time 1.58s (± 1.24%) 1.60s (± 0.26%) ~ 1.59s 1.60s p=0.198 n=6
Bind Time 0.82s (± 0.50%) 0.83s (± 0.62%) +0.02s (+ 1.83%) 0.83s 0.84s p=0.003 n=6
Check Time 10.17s (± 0.50%) 10.29s (± 0.65%) +0.13s (+ 1.23%) 10.20s 10.37s p=0.016 n=6
Emit Time 2.97s (± 0.58%) 3.01s (± 1.21%) ~ 2.97s 3.07s p=0.053 n=6
Total Time 15.54s (± 0.27%) 15.73s (± 0.56%) +0.19s (+ 1.23%) 15.61s 15.85s p=0.008 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,768k (± 0.00%) 345,808k (± 0.01%) ~ 345,734k 345,872k p=0.173 n=6
Parse Time 2.72s (± 0.38%) 2.73s (± 0.72%) ~ 2.71s 2.76s p=0.183 n=6
Bind Time 1.09s (± 0.82%) 1.07s (± 1.52%) ~ 1.05s 1.09s p=0.084 n=6
Check Time 7.81s (± 0.45%) 7.84s (± 0.52%) ~ 7.77s 7.88s p=0.228 n=6
Emit Time 4.44s (± 0.66%) 4.47s (± 0.70%) ~ 4.42s 4.49s p=0.126 n=6
Total Time 16.05s (± 0.38%) 16.11s (± 0.32%) ~ 16.05s 16.16s p=0.077 n=6
TFS - node (v16.17.1, x64)
Memory used 300,054k (± 0.01%) 300,044k (± 0.01%) ~ 300,021k 300,070k p=0.298 n=6
Parse Time 2.16s (± 0.74%) 2.15s (± 0.68%) ~ 2.13s 2.17s p=0.317 n=6
Bind Time 1.25s (± 1.31%) 1.24s (± 0.83%) ~ 1.22s 1.25s p=0.183 n=6
Check Time 7.21s (± 0.68%) 7.18s (± 0.31%) ~ 7.14s 7.20s p=0.258 n=6
Emit Time 4.36s (± 1.46%) 4.36s (± 0.65%) ~ 4.32s 4.40s p=1.000 n=6
Total Time 14.97s (± 0.77%) 14.92s (± 0.33%) ~ 14.85s 14.97s p=0.297 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,550k (± 0.01%) 481,488k (± 0.00%) -63k (- 0.01%) 481,468k 481,520k p=0.030 n=6
Parse Time 3.26s (± 0.61%) 3.25s (± 0.75%) ~ 3.23s 3.29s p=0.504 n=6
Bind Time 0.95s (± 0.67%) 0.94s (± 0.58%) ~ 0.94s 0.95s p=0.201 n=6
Check Time 17.97s (± 0.68%) 17.76s (± 0.46%) -0.21s (- 1.15%) 17.65s 17.86s p=0.016 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.17s (± 0.63%) 21.96s (± 0.42%) -0.21s (- 0.97%) 21.84s 22.10s p=0.020 n=6
xstate - node (v16.17.1, x64)
Memory used 561,294k (± 0.02%) 561,318k (± 0.02%) ~ 561,168k 561,460k p=0.689 n=6
Parse Time 4.04s (± 0.41%) 4.05s (± 0.30%) ~ 4.04s 4.07s p=0.211 n=6
Bind Time 1.77s (± 0.43%) 1.77s (± 0.47%) ~ 1.76s 1.78s p=0.172 n=6
Check Time 3.03s (± 0.54%) 3.04s (± 0.38%) ~ 3.02s 3.05s p=0.622 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.94s (± 0.35%) 8.96s (± 0.15%) ~ 8.94s 8.98s p=0.125 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53903 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53903/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@Andarist Andarist mentioned this pull request Apr 19, 2023
Merged
@sandersn sandersn requested review from weswigham and gabritto May 2, 2023 23:00
@Andarist
Copy link
Contributor Author

This got merged as part of #53907

@Andarist Andarist closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham Awaiting requested review from weswigham

@gabritto gabritto Awaiting requested review from gabritto

Assignees

@gabritto gabritto

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andarist @typescript-bot @jakebailey @gabritto