Fix class alias reference in static initializer for legacy class decorators #54046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
approved these changes
Apr 27, 2023
|
Fantastic!! Thank you for the PR to fix this. I tried to work on the PR, but the code is quite a challenge to understand all of the meta concepts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue related to the class alias reference we emit for legacy decorators. Prior to this fix, static initializers would run before the class alias was initialized when the target is ES2022 or greater since the static fields would be preserved and initialized inline in the class, as opposed to after the class which would be the case for ES2021 and lower targets.
Fixes #52004
Fixes #44908