fix(55168): Computed properties do not respect setter signatures #55178

a-tarasyuk · 2023-07-27T20:34:12Z

…ix/55168

jakebailey · 2024-10-08T18:15:44Z

typescript-bot · 2024-10-08T18:15:48Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-10-08T18:48:42Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-10-08T18:48:58Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/55178/merge:

Everything looks good!

typescript-bot · 2024-10-08T18:54:18Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,772k (± 0.75%)}	_{195,201k (± 0.99%)}	_~	_192,443k	_196,546k	_{p=0.810 n=6}
_{Parse Time}	_{1.99s (± 0.99%)}	_{2.00s (± 0.52%)}	_~	_1.98s	_2.01s	_{p=0.250 n=6}
_{Bind Time}	_{1.09s (± 1.38%)}	_{1.08s (± 1.52%)}	_~	_1.06s	_1.10s	_{p=0.324 n=6}
_{Check Time}	_{14.54s (± 0.23%)}	_{14.59s (± 0.33%)}	_~	_14.54s	_14.67s	_{p=0.053 n=6}
_{Emit Time}	_{4.29s (± 4.13%)}	_{4.14s (± 3.39%)}	_~	_4.03s	_4.41s	_{p=0.093 n=6}
_{Total Time}	_{21.90s (± 1.03%)}	_{21.81s (± 0.67%)}	_~	_21.62s	_22.06s	_{p=0.521 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,808k (± 0.00%)}	_{1,224,807k (± 0.00%)}	_~	_1,224,754k	_1,224,906k	_{p=0.689 n=6}
_{Parse Time}	_{8.03s (± 0.95%)}	_{8.09s (± 1.04%)}	_~	_7.97s	_8.19s	_{p=0.229 n=6}
_{Bind Time}	_{2.26s (± 0.46%)}	_{2.27s (± 0.87%)}	_~	_2.24s	_2.30s	_{p=1.000 n=6}
_{Check Time}	_{37.97s (± 0.54%)}	_{37.85s (± 0.54%)}	_~	_37.61s	_38.11s	_{p=0.378 n=6}
_{Emit Time}	_{18.25s (± 0.62%)}	_{18.18s (± 0.37%)}	_~	_18.12s	_18.30s	_{p=0.192 n=6}
_{Total Time}	_{66.51s (± 0.20%)}	_{66.38s (± 0.44%)}	_~	_66.04s	_66.72s	_{p=0.469 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,678	_2,529,678	_~	_~	_~	_{p=1.000 n=6}
_Types	_916,161	_916,161	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,341,183k (± 0.01%)}	_{2,341,220k (± 0.00%)}	_~	_2,341,064k	_2,341,342k	_{p=0.810 n=6}
_{Parse Time}	_{13.77s (± 0.56%)}	_{13.81s (± 0.94%)}	_~	_13.56s	_13.93s	_{p=0.261 n=6}
_{Bind Time}	_{3.21s (± 1.17%)}	_{3.23s (± 0.51%)}	_~	_3.21s	_3.25s	_{p=0.686 n=6}
_{Check Time}	_{113.30s (± 2.36%)}	_{112.30s (± 2.35%)}	_~	_110.39s	_117.50s	_{p=0.378 n=6}
_{Emit Time}	_{0.42s (± 2.33%)}	_{0.42s (± 2.44%)}	_~	_0.41s	_0.44s	_{p=0.933 n=6}
_{Total Time}	_{130.71s (± 2.02%)}	_{129.76s (± 1.94%)}	_~	_127.90s	_134.73s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,266	_266,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,026,615k (± 9.77%)}	_{3,146,671k (± 0.05%)}	_~	_3,145,349k	_3,149,506k	_{p=0.689 n=6}
_{Parse Time}	_{6.58s (± 0.93%)}	_{6.59s (± 0.70%)}	_~	_6.52s	_6.65s	_{p=1.000 n=6}
_{Bind Time}	_{2.37s (± 0.87%)}	_{2.32s (± 1.58%)}	_~	_2.28s	_2.38s	_{p=0.052 n=6}
_{Check Time}	_{42.93s (± 0.17%)}	_{43.01s (± 0.10%)}	_~	_42.94s	_43.05s	_{p=0.066 n=6}
_{Emit Time}	_{3.53s (± 2.64%)}	_{3.53s (± 1.81%)}	_~	_3.44s	_3.60s	_{p=0.936 n=6}
_{Total Time}	_{55.41s (± 0.19%)}	_{55.46s (± 0.18%)}	_~	_55.35s	_55.57s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,266	_266,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,645,463k (±10.85%)}	_{2,646,376k (±10.84%)}	_~	_2,499,012k	_3,218,833k	_{p=0.471 n=6}
_{Parse Time}	_{8.24s (± 2.38%)}	_{8.21s (± 2.67%)}	_~	_8.07s	_8.64s	_{p=0.423 n=6}
_{Bind Time}	_{2.64s (± 1.21%)}	_{2.67s (± 0.80%)}	_~	_2.65s	_2.71s	_{p=0.127 n=6}
_{Check Time}	_{53.48s (± 0.94%)}	_{53.28s (± 0.47%)}	_~	_52.98s	_53.57s	_{p=0.471 n=6}
_{Emit Time}	_{4.40s (± 3.87%)}	_{4.28s (± 1.96%)}	_~	_4.18s	_4.41s	_{p=0.261 n=6}
_{Total Time}	_{68.78s (± 0.87%)}	_{68.44s (± 0.50%)}	_~	_67.92s	_68.73s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,786	_261,786	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,508	_106,508	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,774k (± 0.01%)}	_{438,767k (± 0.01%)}	_~	_438,671k	_438,843k	_{p=1.000 n=6}
_{Parse Time}	_{3.55s (± 0.34%)}	_{3.55s (± 0.92%)}	_~	_3.51s	_3.60s	_{p=0.871 n=6}
_{Bind Time}	_{1.31s (± 0.62%)}	_{1.32s (± 0.62%)}	_~	_1.31s	_1.33s	_{p=0.666 n=6}
_{Check Time}	_{18.94s (± 0.24%)}	_{18.93s (± 0.45%)}	_~	_18.85s	_19.08s	_{p=0.470 n=6}
_{Emit Time}	_{1.53s (± 1.07%)}	_{1.53s (± 0.89%)}	_~	_1.51s	_1.55s	_{p=0.512 n=6}
_{Total Time}	_{25.33s (± 0.21%)}	_{25.33s (± 0.38%)}	_~	_25.19s	_25.48s	_{p=1.000 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,084k (± 0.01%)}	_{371,065k (± 0.01%)}	_~	_371,002k	_371,130k	_{p=0.575 n=6}
_{Parse Time}	_{2.91s (± 1.24%)}	_{2.90s (± 1.17%)}	_~	_2.85s	_2.93s	_{p=0.629 n=6}
_{Bind Time}	_{1.58s (± 1.53%)}	_{1.58s (± 1.36%)}	_~	_1.55s	_1.61s	_{p=0.936 n=6}
_{Check Time}	_{16.38s (± 0.40%)}	_{16.35s (± 0.15%)}	_~	_16.32s	_16.38s	_{p=0.378 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.87s (± 0.46%)}	_{20.83s (± 0.18%)}	_~	_20.79s	_20.90s	_{p=0.227 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,113,231	_3,113,231	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,073,156	_1,073,156	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,206,506k (± 0.01%)}	_{3,206,412k (± 0.01%)}	_~	_3,206,050k	_3,206,755k	_{p=0.689 n=6}
_{Parse Time}	_{11.54s (± 0.79%)}	_{11.53s (± 0.48%)}	_~	_11.47s	_11.61s	_{p=0.873 n=6}
_{Bind Time}	_{3.69s (± 0.37%)}	_{3.68s (± 0.51%)}	_~	_3.65s	_3.70s	_{p=0.618 n=6}
_{Check Time}	_{72.02s (± 0.20%)}	_{72.03s (± 0.30%)}	_~	_71.78s	_72.29s	_{p=0.810 n=6}
_{Emit Time}	_{20.80s (± 9.83%)}	_{21.54s (± 8.81%)}	_~	_19.00s	_23.19s	_{p=0.471 n=6}
_{Total Time}	_{108.04s (± 1.83%)}	_{108.79s (± 1.62%)}	_~	_106.53s	_110.69s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_285,172	_285,172	_~	_~	_~	_{p=1.000 n=6}
_Types	_115,780	_115,780	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{434,951k (± 0.01%)}	_{435,042k (± 0.02%)}	_~	_434,932k	_435,126k	_{p=0.093 n=6}
_{Parse Time}	_{4.06s (± 1.28%)}	_{4.04s (± 0.96%)}	_~	_3.99s	_4.10s	_{p=0.574 n=6}
_{Bind Time}	_{1.72s (± 1.34%)}	_{1.74s (± 2.16%)}	_~	_1.69s	_1.78s	_{p=0.466 n=6}
_{Check Time}	_{18.31s (± 0.40%)}	_{18.30s (± 0.57%)}	_~	_18.15s	_18.46s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.10s (± 0.34%)}	_{24.08s (± 0.42%)}	_~	_23.90s	_24.18s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,222	_540,222	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,145	_181,145	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,886k (± 0.02%)}	_{483,854k (± 0.02%)}	_~	_483,643k	_483,947k	_{p=0.936 n=6}
_{Parse Time}	_{3.38s (± 0.95%)}	_{3.35s (± 0.44%)}	_~	_3.34s	_3.38s	_{p=0.088 n=6}
_{Bind Time}	_{1.17s (± 0.88%)}	_{1.18s (± 0.93%)}	_~	_1.16s	_1.19s	_{p=0.281 n=6}
_{Check Time}	_{19.10s (± 0.50%)}	_{19.20s (± 1.18%)}	_~	_19.00s	_19.64s	_{p=0.423 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.65s (± 0.37%)}	_{23.73s (± 0.92%)}	_~	_23.53s	_24.16s	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-10-08T20:08:53Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/55178/merge:

Everything looks good!

…ix/55168

a-tarasyuk · 2024-10-21T21:33:25Z

@jakebailey it appears that similar changes were made a while back. Should the PR be closed, or should the test be merged to resolve the issue?

jakebailey · 2024-10-21T22:53:26Z

Taking the tests should be fine, though it'd be nice to know which PR actually fixed this...

a-tarasyuk · 2024-10-22T05:45:20Z

@jakebailey It looks like this one

jakebailey · 2024-10-22T20:10:45Z

Aha, yep. I knew I read that somewhere.

fix(55168): use setter type for computed prop assignments

43debaa

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 27, 2023

sandersn requested review from andrewbranch and navya9singh August 11, 2023 23:19

sandersn assigned navya9singh Aug 11, 2023

a-tarasyuk added 2 commits October 6, 2024 17:56

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

8cb5f9c

…ix/55168

update baseline

129ff3c

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

02857ae

…ix/55168

jakebailey approved these changes Oct 22, 2024

View reviewed changes

jakebailey merged commit 241a6c9 into microsoft:main Oct 22, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(55168): Computed properties do not respect setter signatures #55178

fix(55168): Computed properties do not respect setter signatures #55178

a-tarasyuk commented Jul 27, 2023

jakebailey commented Oct 8, 2024

typescript-bot commented Oct 8, 2024 •

edited

Loading

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

tsc

typescript-bot commented Oct 8, 2024

a-tarasyuk commented Oct 21, 2024

jakebailey commented Oct 21, 2024

a-tarasyuk commented Oct 22, 2024

jakebailey commented Oct 22, 2024

fix(55168): Computed properties do not respect setter signatures #55178

fix(55168): Computed properties do not respect setter signatures #55178

Conversation

a-tarasyuk commented Jul 27, 2023

jakebailey commented Oct 8, 2024

typescript-bot commented Oct 8, 2024 • edited Loading

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

tsc

typescript-bot commented Oct 8, 2024

a-tarasyuk commented Oct 21, 2024

jakebailey commented Oct 21, 2024

a-tarasyuk commented Oct 22, 2024

jakebailey commented Oct 22, 2024

typescript-bot commented Oct 8, 2024 •

edited

Loading