Skip to content

Resolve JSX intrinsic elements to index signature symbols #55245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

Resolve JSX intrinsic elements to index signature symbols #55245

merged 1 commit into from
Aug 7, 2023

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Aug 2, 2023 •
edited
Loading

fixes #5984
fixes #10996
fixes #55240

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 2, 2023
@Andarist Andarist force-pushed the resolve-index-signature-symbols-on-jsx-intrinsics branch from c366dac to 312b661 Compare August 3, 2023 08:00
@RyanCavanaugh RyanCavanaugh requested a review from weswigham August 4, 2023 21:35
@weswigham
Copy link
Member

@typescript-bot test this
@typescript-bot run dt
@typescript-bot test top100
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 5, 2023 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 312b661. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 5, 2023 •
edited
Loading

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 312b661. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 5, 2023 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at 312b661. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 5, 2023 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at 312b661. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/55245/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @weswigham, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..55245
Metric main 55245 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 368,842k (± 0.01%) 368,837k (± 0.01%) ~ 368,815k 368,867k p=1.000 n=6
Parse Time 3.39s (± 0.83%) 3.39s (± 0.44%) ~ 3.37s 3.41s p=1.000 n=6
Bind Time 1.13s (± 0.49%) 1.13s (± 0.72%) ~ 1.12s 1.14s p=0.859 n=6
Check Time 9.06s (± 0.59%) 9.06s (± 0.67%) ~ 8.95s 9.13s p=1.000 n=6
Emit Time 7.56s (± 0.53%) 7.58s (± 0.82%) ~ 7.47s 7.66s p=0.376 n=6
Total Time 21.14s (± 0.41%) 21.16s (± 0.56%) ~ 20.93s 21.28s p=0.422 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,982k (± 0.11%) 192,063k (± 0.01%) ~ 192,030k 192,102k p=0.689 n=6
Parse Time 1.50s (± 0.91%) 1.51s (± 0.42%) ~ 1.50s 1.52s p=0.614 n=6
Bind Time 0.78s (± 0.71%) 0.77s (± 0.53%) ~ 0.77s 0.78s p=0.282 n=6
Check Time 9.59s (± 0.20%) 9.50s (± 0.81%) -0.09s (- 0.90%) 9.40s 9.58s p=0.013 n=6
Emit Time 2.76s (± 1.91%) 2.75s (± 0.84%) ~ 2.72s 2.78s p=0.808 n=6
Total Time 14.63s (± 0.45%) 14.53s (± 0.58%) ~ 14.40s 14.60s p=0.109 n=6
Monaco - node (v18.10.0, x64)
Memory used 347,777k (± 0.01%) 347,770k (± 0.01%) ~ 347,719k 347,802k p=0.936 n=6
Parse Time 2.60s (± 1.26%) 2.60s (± 0.66%) ~ 2.57s 2.62s p=0.626 n=6
Bind Time 1.01s (± 0.54%) 1.01s (± 0.51%) ~ 1.01s 1.02s p=0.640 n=6
Check Time 7.39s (± 0.47%) 7.41s (± 0.51%) ~ 7.36s 7.46s p=0.376 n=6
Emit Time 4.24s (± 0.97%) 4.27s (± 0.80%) ~ 4.23s 4.31s p=0.172 n=6
Total Time 15.24s (± 0.63%) 15.29s (± 0.54%) ~ 15.17s 15.39s p=0.261 n=6
TFS - node (v18.10.0, x64)
Memory used 301,807k (± 0.01%) 301,803k (± 0.01%) ~ 301,775k 301,834k p=0.810 n=6
Parse Time 2.07s (± 1.63%) 2.08s (± 1.59%) ~ 2.04s 2.14s p=0.683 n=6
Bind Time 1.13s (± 1.35%) 1.12s (± 0.36%) ~ 1.11s 1.12s p=0.490 n=6
Check Time 6.67s (± 0.52%) 6.66s (± 0.44%) ~ 6.63s 6.71s p=0.560 n=6
Emit Time 3.87s (± 0.67%) 3.84s (± 0.65%) ~ 3.81s 3.87s p=0.076 n=6
Total Time 13.75s (± 0.49%) 13.69s (± 0.48%) ~ 13.64s 13.82s p=0.108 n=6
material-ui - node (v18.10.0, x64)
Memory used 482,623k (± 0.01%) 482,658k (± 0.01%) +35k (+ 0.01%) 482,616k 482,753k p=0.045 n=6
Parse Time 3.11s (± 0.56%) 3.08s (± 3.08%) ~ 2.96s 3.17s p=0.871 n=6
Bind Time 0.93s (± 1.11%) 0.96s (± 5.19%) ~ 0.92s 1.03s p=0.558 n=6
Check Time 17.50s (± 0.99%) 17.47s (± 0.60%) ~ 17.34s 17.60s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.54s (± 0.82%) 21.51s (± 0.67%) ~ 21.38s 21.69s p=0.873 n=6
xstate - node (v18.10.0, x64)
Memory used 563,896k (± 0.02%) 563,830k (± 0.02%) ~ 563,747k 564,022k p=0.298 n=6
Parse Time 3.84s (± 0.56%) 3.83s (± 0.42%) ~ 3.80s 3.84s p=0.318 n=6
Bind Time 1.65s (± 1.17%) 1.63s (± 1.19%) ~ 1.61s 1.66s p=0.126 n=6
Check Time 2.82s (± 0.74%) 2.80s (± 0.54%) ~ 2.79s 2.82s p=0.118 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.40s (± 0.54%) 8.35s (± 0.21%) -0.05s (- 0.58%) 8.33s 8.37s p=0.036 n=6
Angular - node (v16.17.1, x64)
Memory used 368,250k (± 0.01%) 368,238k (± 0.01%) ~ 368,204k 368,262k p=0.298 n=6
Parse Time 3.57s (± 0.42%) 3.55s (± 0.68%) ~ 3.51s 3.58s p=0.096 n=6
Bind Time 1.18s (± 0.46%) 1.18s (± 1.03%) ~ 1.16s 1.19s p=0.441 n=6
Check Time 9.80s (± 0.34%) 9.80s (± 0.40%) ~ 9.75s 9.85s p=0.872 n=6
Emit Time 8.01s (± 0.70%) 7.99s (± 0.55%) ~ 7.95s 8.07s p=0.517 n=6
Total Time 22.56s (± 0.39%) 22.53s (± 0.29%) ~ 22.47s 22.65s p=0.470 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,788k (± 0.02%) 193,814k (± 0.02%) ~ 193,748k 193,864k p=0.298 n=6
Parse Time 1.58s (± 1.01%) 1.59s (± 0.47%) ~ 1.58s 1.60s p=0.301 n=6
Bind Time 0.82s (± 0.92%) 0.82s (± 0.92%) ~ 0.81s 0.83s p=0.487 n=6
Check Time 10.20s (± 0.62%) 10.20s (± 0.49%) ~ 10.11s 10.24s p=0.936 n=6
Emit Time 2.98s (± 0.87%) 2.98s (± 1.15%) ~ 2.94s 3.03s p=0.809 n=6
Total Time 15.58s (± 0.50%) 15.59s (± 0.26%) ~ 15.54s 15.64s p=1.000 n=6
Monaco - node (v16.17.1, x64)
Memory used 347,099k (± 0.00%) 347,099k (± 0.01%) ~ 347,080k 347,127k p=1.000 n=6
Parse Time 2.77s (± 0.32%) 2.76s (± 0.32%) ~ 2.75s 2.77s p=0.113 n=6
Bind Time 1.08s (± 0.38%) 1.08s (± 0.51%) ~ 1.07s 1.08s p=0.282 n=6
Check Time 8.06s (± 0.15%) 8.06s (± 0.47%) ~ 8.03s 8.12s p=0.809 n=6
Emit Time 4.48s (± 1.00%) 4.45s (± 0.52%) ~ 4.43s 4.49s p=0.121 n=6
Total Time 16.39s (± 0.28%) 16.35s (± 0.38%) ~ 16.30s 16.44s p=0.147 n=6
TFS - node (v16.17.1, x64)
Memory used 301,136k (± 0.01%) 301,126k (± 0.01%) ~ 301,106k 301,168k p=0.471 n=6
Parse Time 2.19s (± 0.45%) 2.20s (± 0.89%) ~ 2.18s 2.23s p=0.188 n=6
Bind Time 1.21s (± 1.73%) 1.21s (± 1.21%) ~ 1.19s 1.23s p=1.000 n=6
Check Time 7.36s (± 0.29%) 7.32s (± 0.40%) ~ 7.28s 7.35s p=0.053 n=6
Emit Time 4.34s (± 1.26%) 4.30s (± 0.28%) ~ 4.29s 4.32s p=0.373 n=6
Total Time 15.09s (± 0.50%) 15.04s (± 0.34%) ~ 14.97s 15.11s p=0.374 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,863k (± 0.01%) 481,894k (± 0.01%) ~ 481,843k 482,028k p=0.471 n=6
Parse Time 3.25s (± 0.60%) 3.24s (± 0.36%) ~ 3.22s 3.25s p=0.222 n=6
Bind Time 0.95s (± 0.57%) 0.95s (± 0.57%) ~ 0.95s 0.96s p=1.000 n=6
Check Time 18.48s (± 0.64%) 18.39s (± 0.41%) ~ 18.29s 18.48s p=0.297 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.68s (± 0.56%) 22.58s (± 0.33%) ~ 22.48s 22.66s p=0.336 n=6
xstate - node (v16.17.1, x64)
Memory used 561,397k (± 0.02%) 561,383k (± 0.02%) ~ 561,290k 561,542k p=1.000 n=6
Parse Time 4.02s (± 0.42%) 4.01s (± 0.22%) ~ 4.00s 4.02s p=0.362 n=6
Bind Time 1.67s (± 5.70%) 1.70s (± 6.36%) ~ 1.55s 1.79s p=0.810 n=6
Check Time 3.13s (± 2.87%) 3.12s (± 2.90%) ~ 3.05s 3.25s p=1.000 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=0.595 n=6
Total Time 8.92s (± 0.43%) 8.92s (± 0.32%) ~ 8.88s 8.96s p=1.000 n=6
Angular - node (v14.21.3, x64)
Memory used 362,153k (± 0.01%) 362,152k (± 0.01%) ~ 362,114k 362,187k p=0.748 n=6
Parse Time 3.73s (± 0.43%) 3.72s (± 0.44%) ~ 3.70s 3.74s p=0.121 n=6
Bind Time 1.22s (± 0.85%) 1.22s (± 0.42%) ~ 1.21s 1.22s p=0.793 n=6
Check Time 10.26s (± 0.33%) 10.20s (± 0.34%) -0.06s (- 0.57%) 10.16s 10.25s p=0.030 n=6
Emit Time 8.37s (± 0.87%) 8.34s (± 0.80%) ~ 8.26s 8.45s p=0.575 n=6
Total Time 23.57s (± 0.47%) 23.47s (± 0.29%) ~ 23.40s 23.58s p=0.149 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used 189,111k (± 0.01%) 189,077k (± 0.05%) ~ 188,880k 189,143k p=0.936 n=6
Parse Time 1.61s (± 0.85%) 1.61s (± 0.52%) ~ 1.60s 1.62s p=0.262 n=6
Bind Time 0.84s (± 0.61%) 0.84s (± 0.61%) ~ 0.84s 0.85s p=1.000 n=6
Check Time 10.40s (± 0.61%) 10.37s (± 0.23%) ~ 10.32s 10.39s p=0.261 n=6
Emit Time 3.12s (± 0.37%) 3.16s (± 4.63%) ~ 3.09s 3.46s p=0.250 n=6
Total Time 15.98s (± 0.46%) 15.97s (± 1.07%) ~ 15.86s 16.32s p=0.521 n=6
Monaco - node (v14.21.3, x64)
Memory used 342,091k (± 0.01%) 342,100k (± 0.01%) ~ 342,075k 342,129k p=0.336 n=6
Parse Time 2.81s (± 0.49%) 2.82s (± 0.53%) ~ 2.79s 2.83s p=0.680 n=6
Bind Time 1.09s (± 0.37%) 1.09s (± 0.76%) ~ 1.09s 1.11s p=0.527 n=6
Check Time 8.38s (± 0.25%) 8.37s (± 0.41%) ~ 8.34s 8.43s p=0.373 n=6
Emit Time 4.66s (± 0.58%) 4.67s (± 0.67%) ~ 4.63s 4.72s p=0.687 n=6
Total Time 16.94s (± 0.18%) 16.95s (± 0.34%) ~ 16.89s 17.04s p=1.000 n=6
TFS - node (v14.21.3, x64)
Memory used 296,214k (± 0.00%) 296,214k (± 0.01%) ~ 296,197k 296,240k p=0.688 n=6
Parse Time 2.43s (± 0.92%) 2.41s (± 1.10%) ~ 2.38s 2.45s p=0.329 n=6
Bind Time 1.08s (± 0.70%) 1.08s (± 0.91%) ~ 1.07s 1.09s p=1.000 n=6
Check Time 7.71s (± 0.37%) 7.69s (± 0.25%) ~ 7.66s 7.71s p=0.256 n=6
Emit Time 4.30s (± 0.77%) 4.28s (± 0.65%) ~ 4.25s 4.32s p=0.252 n=6
Total Time 15.52s (± 0.28%) 15.47s (± 0.25%) ~ 15.42s 15.51s p=0.075 n=6
material-ui - node (v14.21.3, x64)
Memory used 477,369k (± 0.00%) 477,374k (± 0.00%) ~ 477,354k 477,399k p=0.575 n=6
Parse Time 3.29s (± 0.17%) 3.30s (± 0.46%) ~ 3.29s 3.32s p=0.490 n=6
Bind Time 0.99s (± 0.64%) 0.99s (± 0.76%) ~ 0.98s 1.00s p=0.718 n=6
Check Time 19.27s (± 0.15%) 19.24s (± 0.27%) ~ 19.18s 19.30s p=0.520 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.55s (± 0.12%) 23.54s (± 0.20%) ~ 23.48s 23.61s p=0.572 n=6
xstate - node (v14.21.3, x64)
Memory used 550,254k (± 0.01%) 550,208k (± 0.01%) ~ 550,179k 550,263k p=0.066 n=6
Parse Time 4.21s (± 0.51%) 4.21s (± 0.60%) ~ 4.18s 4.24s p=0.569 n=6
Bind Time 1.67s (± 2.63%) 1.68s (± 2.31%) ~ 1.60s 1.71s p=1.000 n=6
Check Time 3.12s (± 0.69%) 3.13s (± 0.56%) ~ 3.10s 3.15s p=0.936 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=0.405 n=6
Total Time 9.10s (± 0.49%) 9.10s (± 0.41%) ~ 9.04s 9.15s p=1.000 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
Benchmark Name Iterations
Current 55245 6
Baseline main 6

TSServer

Comparison Report - main..55245
Metric main 55245 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,533ms (± 0.37%) 2,536ms (± 1.09%) ~ 2,490ms 2,568ms p=0.689 n=6
Req 2 - geterr 5,444ms (± 0.51%) 5,448ms (± 0.37%) ~ 5,414ms 5,468ms p=0.810 n=6
Req 3 - references 341ms (± 0.45%) 340ms (± 0.43%) ~ 338ms 342ms p=0.415 n=6
Req 4 - navto 287ms (± 0.28%) 289ms (± 0.51%) ~ 287ms 291ms p=0.079 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 86ms (± 3.41%) 83ms (± 7.06%) ~ 75ms 88ms p=0.366 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,631ms (± 0.87%) 2,609ms (± 0.86%) ~ 2,591ms 2,643ms p=0.092 n=6
Req 2 - geterr 4,151ms (± 0.24%) 4,138ms (± 0.45%) ~ 4,119ms 4,169ms p=0.228 n=6
Req 3 - references 356ms (± 0.59%) 356ms (± 0.52%) ~ 354ms 359ms p=0.935 n=6
Req 4 - navto 289ms (± 0.47%) 290ms (± 0.44%) ~ 288ms 291ms p=0.408 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 89ms (± 0.94%) 88ms (± 1.11%) ~ 87ms 89ms p=0.588 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,079ms (± 0.35%) 3,099ms (± 1.02%) ~ 3,060ms 3,144ms p=0.295 n=6
Req 2 - geterr 1,565ms (± 0.93%) 1,579ms (± 0.40%) ~ 1,570ms 1,584ms p=0.062 n=6
Req 3 - references 114ms (± 0.86%) 114ms (± 2.27%) ~ 111ms 116ms p=1.000 n=6
Req 4 - navto 369ms (± 0.41%) 371ms (± 0.88%) ~ 367ms 376ms p=0.745 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 380ms (± 1.16%) 386ms (± 2.08%) ~ 375ms 399ms p=0.199 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,609ms (± 0.78%) 2,632ms (± 0.51%) +24ms (+ 0.91%) 2,612ms 2,649ms p=0.045 n=6
Req 2 - geterr 6,073ms (± 0.36%) 6,083ms (± 0.55%) ~ 6,020ms 6,109ms p=0.261 n=6
Req 3 - references 358ms (± 1.35%) 358ms (± 1.31%) ~ 354ms 364ms p=0.936 n=6
Req 4 - navto 287ms (± 0.92%) 289ms (± 0.77%) ~ 287ms 293ms p=0.459 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 81ms (± 0.68%) 81ms (± 1.22%) ~ 80ms 82ms p=0.662 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,794ms (± 0.59%) 2,788ms (± 0.68%) ~ 2,753ms 2,805ms p=1.000 n=6
Req 2 - geterr 4,703ms (± 0.60%) 4,696ms (± 0.32%) ~ 4,679ms 4,711ms p=0.688 n=6
Req 3 - references 362ms (± 0.60%) 362ms (± 0.28%) ~ 361ms 364ms p=1.000 n=6
Req 4 - navto 282ms (± 0.73%) 283ms (± 1.28%) ~ 280ms 289ms p=0.739 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 77ms (± 1.37%) 78ms (± 3.71%) ~ 75ms 83ms p=0.805 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,218ms (± 0.31%) 3,214ms (± 0.26%) ~ 3,202ms 3,227ms p=0.630 n=6
Req 2 - geterr 1,696ms (± 0.45%) 1,690ms (± 0.78%) ~ 1,665ms 1,699ms p=0.687 n=6
Req 3 - references 127ms (± 6.64%) 128ms (± 6.74%) ~ 123ms 145ms p=0.511 n=6
Req 4 - navto 354ms (± 0.56%) 355ms (± 1.13%) ~ 350ms 361ms p=0.418 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 411ms (± 0.83%) 406ms (± 1.63%) ~ 399ms 417ms p=0.199 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,766ms (± 0.53%) 2,756ms (± 0.56%) ~ 2,739ms 2,776ms p=0.298 n=6
Req 2 - geterr 6,266ms (± 1.39%) 6,215ms (± 0.68%) ~ 6,150ms 6,268ms p=0.471 n=6
Req 3 - references 362ms (± 1.23%) 364ms (± 1.04%) ~ 360ms 370ms p=0.519 n=6
Req 4 - navto 291ms (± 1.57%) 290ms (± 0.74%) ~ 288ms 294ms p=0.935 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 103ms (± 8.93%) 102ms (± 8.82%) ~ 91ms 112ms p=0.572 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,938ms (± 0.45%) 2,929ms (± 0.40%) ~ 2,906ms 2,940ms p=0.297 n=6
Req 2 - geterr 4,585ms (± 0.56%) 4,602ms (± 0.44%) ~ 4,568ms 4,626ms p=0.173 n=6
Req 3 - references 374ms (± 0.58%) 373ms (± 0.95%) ~ 368ms 377ms p=1.000 n=6
Req 4 - navto 295ms (± 0.54%) 295ms (± 0.92%) ~ 292ms 298ms p=0.805 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 84ms (± 1.47%) 89ms (± 8.53%) ~ 82ms 100ms p=0.220 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 3,503ms (± 1.35%) 3,484ms (± 1.15%) ~ 3,413ms 3,530ms p=0.229 n=6
Req 2 - geterr 1,816ms (± 0.49%) 1,815ms (± 0.77%) ~ 1,802ms 1,842ms p=0.422 n=6
Req 3 - references 146ms (± 7.24%) 146ms (± 7.82%) ~ 131ms 155ms p=1.000 n=6
Req 4 - navto 388ms (± 1.54%) 389ms (± 1.32%) ~ 385ms 399ms p=0.317 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 422ms (± 1.27%) 421ms (± 1.60%) ~ 415ms 431ms p=0.746 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
Benchmark Name Iterations
Current 55245 6
Baseline main 6

Startup

Comparison Report - main..55245
Metric main 55245 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.90ms (± 0.18%) 142.29ms (± 0.18%) -0.61ms (- 0.43%) 141.43ms 145.95ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 222.67ms (± 0.31%) 221.55ms (± 0.18%) -1.13ms (- 0.51%) 220.62ms 228.97ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 224.82ms (± 0.37%) 222.97ms (± 0.17%) -1.85ms (- 0.82%) 222.09ms 232.89ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 205.71ms (± 0.22%) 205.09ms (± 0.19%) -0.62ms (- 0.30%) 204.26ms 214.82ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 55245 6
Baseline main 6

Developer Information:

Download Benchmark

@weswigham
Copy link
Member

DT failure was just one of the runners having an npm install failure again, so I'll merge this. @sandersn did we not manage to actually fix that, or did we just decide that issue was transient and probably not our fault/responsibility?

@weswigham weswigham merged commit 5ea2952 into microsoft:main Aug 7, 2023
@sandersn
Copy link
Member

sandersn commented Aug 9, 2023

Moving DT to a modern monorepo structure is blocked on Jake getting the perf infrastructure working, since he was working around a couple of pnpm limitations still left before we can make the switch.

@Andarist Andarist mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
4 participants
@Andarist @weswigham @typescript-bot @sandersn