Make tsserver and typingsInstaller thin wrappers around public API #55326

jakebailey · 2023-08-09T22:58:28Z

If you check out the tsconfigs for tsserver and typescript (previously tsserverlibrary), you'll note that they're the same! typescript is just a plain reexport for public use, meaning that tsserver is a strict superset of the public API and could be implemented as a bundle which just imports the API. We already do this for vscode.dev, which adds a web host; tsserver is what adds the node host. The same thing is true for typingsInstaller as well; we exported it in the public API in #53394.

This PR instead makes those projects import from the public API project. Then at bundle time, this import is replaced with a reference to a local ./typescript.js. (In --no-bundle, this isn't done, and the original import still works.)

After this, we're down to only having copies of our code in typescript.js and tsc.js, where the latter is a significantly different bundle for performance reasons.

Package size report

Overall package size

	Before	After	Diff	Diff (percent)
Packed	5.51 MiB	3.76 MiB	-1.74 MiB	-31.66%
Unpacked	30.18 MiB	20.36 MiB	-9.82 MiB	-32.55%

Files

	Before	After	Diff	Diff (percent)
`lib/tsserver.js`	8.19 MiB	24.64 KiB	-8.16 MiB	-99.71%
`lib/typingsInstaller.js`	1.67 MiB	10.47 KiB	-1.66 MiB	-99.39%

jakebailey · 2024-03-08T22:04:21Z

@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2024-03-08T22:04:24Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-03-08T22:09:02Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160244/artifacts?artifactName=tgz&fileId=B7289D42EBA0857A2E6D4A8DE5473F868A9A787C6A17B7FEEC1B2C4A629A480D02&fileName=/typescript-5.5.0-insiders.20240308.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-55326-5".;

typescript-bot · 2024-03-08T22:49:40Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,523k (± 0.01%)}	_{295,528k (± 0.01%)}	_~	_295,502k	_295,545k	_{p=0.936 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.67s (± 0.15%)}	_{+0.01s (+ 0.31%)}	_2.66s	_2.67s	_{p=0.033 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.83s (± 1.40%)}	_~	_0.82s	_0.85s	_{p=0.542 n=6}
_{Check Time}	_{8.23s (± 0.26%)}	_{8.21s (± 0.40%)}	_~	_8.15s	_8.24s	_{p=0.746 n=6}
_{Emit Time}	_{7.13s (± 0.14%)}	_{7.16s (± 0.35%)}	_~	_7.11s	_7.18s	_{p=0.052 n=6}
_{Total Time}	_{18.84s (± 0.13%)}	_{18.87s (± 0.23%)}	_~	_18.82s	_18.93s	_{p=0.326 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,771k (± 0.94%)}	_{191,535k (± 0.09%)}	_~	_191,360k	_191,772k	_{p=0.128 n=6}
_{Parse Time}	_{1.36s (± 0.55%)}	_{1.35s (± 0.81%)}	_~	_1.33s	_1.36s	_{p=0.195 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.38s (± 0.38%)}	_{9.34s (± 0.26%)}	_~	_9.32s	_9.38s	_{p=0.053 n=6}
_{Emit Time}	_{2.60s (± 0.46%)}	_{2.61s (± 0.61%)}	_~	_2.59s	_2.63s	_{p=0.492 n=6}
_{Total Time}	_{14.07s (± 0.26%)}	_{14.02s (± 0.32%)}	_~	_13.97s	_14.09s	_{p=0.127 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,301k (± 0.01%)}	_{347,314k (± 0.01%)}	_~	_347,276k	_347,349k	_{p=0.520 n=6}
_{Parse Time}	_{2.48s (± 0.22%)}	_{2.48s (± 0.42%)}	_~	_2.46s	_2.49s	_{p=0.663 n=6}
_{Bind Time}	_{0.92s (± 0.90%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.923 n=6}
_{Check Time}	_{6.96s (± 0.22%)}	_{6.95s (± 0.27%)}	_~	_6.92s	_6.97s	_{p=0.563 n=6}
_{Emit Time}	_{4.07s (± 0.61%)}	_{4.07s (± 0.20%)}	_~	_4.06s	_4.08s	_{p=0.864 n=6}
_{Total Time}	_{14.43s (± 0.16%)}	_{14.43s (± 0.12%)}	_~	_14.40s	_14.44s	_{p=0.935 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,758k (± 0.01%)}	_{302,758k (± 0.01%)}	_~	_302,740k	_302,780k	_{p=0.873 n=6}
_{Parse Time}	_{2.01s (± 0.49%)}	_{2.01s (± 0.86%)}	_~	_1.99s	_2.04s	_{p=0.869 n=6}
_{Bind Time}	_{1.00s (± 1.26%)}	_{1.00s (± 0.98%)}	_~	_0.99s	_1.02s	_{p=0.672 n=6}
_{Check Time}	_{6.34s (± 0.46%)}	_{6.35s (± 0.54%)}	_~	_6.31s	_6.40s	_{p=0.936 n=6}
_{Emit Time}	_{3.61s (± 0.52%)}	_{3.60s (± 0.45%)}	_~	_3.57s	_3.62s	_{p=0.373 n=6}
_{Total Time}	_{12.96s (± 0.23%)}	_{12.96s (± 0.28%)}	_~	_12.92s	_13.02s	_{p=0.936 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,200k (± 0.00%)}	_{511,205k (± 0.00%)}	_~	_511,191k	_511,215k	_{p=1.000 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.66s (± 0.34%)}	_~	_2.65s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.98s (± 1.06%)}	_{0.99s (± 0.64%)}	_~	_0.98s	_1.00s	_{p=0.388 n=6}
_{Check Time}	_{17.31s (± 0.62%)}	_{17.27s (± 0.38%)}	_~	_17.18s	_17.35s	_{p=0.520 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.50%)}	_{20.93s (± 0.32%)}	_~	_20.83s	_20.99s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,789,566k (± 0.00%)}	_{1,789,558k (± 0.00%)}	_~	_1,789,532k	_1,789,599k	_{p=0.630 n=6}
_{Parse Time}	_{6.64s (± 0.38%)}	_{6.66s (± 0.43%)}	_~	_6.63s	_6.71s	_{p=0.746 n=6}
_{Bind Time}	_{2.39s (± 0.00%)}	_{2.39s (± 0.17%)}	_~	_2.38s	_2.39s	_{p=0.405 n=6}
_{Check Time}	_{58.82s (± 0.40%)}	_{58.98s (± 0.18%)}	_~	_58.82s	_59.08s	_{p=0.229 n=6}
_{Emit Time}	_{0.16s (± 0.00%)}	_{0.16s (± 3.16%)}	_~	_0.16s	_0.17s	_{p=0.174 n=6}
_{Total Time}	_{68.02s (± 0.35%)}	_{68.19s (± 0.17%)}	_~	_68.02s	_68.34s	_{p=0.199 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,354k (± 0.04%)}	_{2,394,144k (± 0.02%)}	_~	_2,393,559k	_2,394,937k	_{p=0.689 n=6}
_{Parse Time}	_{5.05s (± 0.82%)}	_{5.07s (± 0.79%)}	_~	_5.02s	_5.12s	_{p=0.689 n=6}
_{Bind Time}	_{1.89s (± 0.70%)}	_{1.90s (± 0.58%)}	_~	_1.89s	_1.92s	_{p=0.357 n=6}
_{Check Time}	_{33.70s (± 0.33%)}	_{33.69s (± 0.28%)}	_~	_33.57s	_33.78s	_{p=0.873 n=6}
_{Emit Time}	_{2.67s (± 0.70%)}	_{2.68s (± 1.80%)}	_~	_2.64s	_2.77s	_{p=0.630 n=6}
_{Total Time}	_{43.34s (± 0.28%)}	_{43.34s (± 0.27%)}	_~	_43.20s	_43.49s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{414,494k (± 0.01%)}	_{414,507k (± 0.01%)}	_~	_414,465k	_414,523k	_{p=0.471 n=6}
_{Parse Time}	_{2.81s (± 0.86%)}	_{2.81s (± 0.79%)}	_~	_2.79s	_2.85s	_{p=0.808 n=6}
_{Bind Time}	_{1.07s (± 0.70%)}	_{1.07s (± 0.59%)}	_~	_1.06s	_1.08s	_{p=0.718 n=6}
_{Check Time}	_{15.19s (± 0.38%)}	_{15.15s (± 0.22%)}	_~	_15.11s	_15.20s	_{p=0.172 n=6}
_{Emit Time}	_{1.11s (± 1.33%)}	_{1.11s (± 1.67%)}	_~	_1.09s	_1.13s	_{p=0.677 n=6}
_{Total Time}	_{20.18s (± 0.35%)}	_{20.14s (± 0.20%)}	_~	_20.08s	_20.18s	_{p=0.627 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,865,706k (± 0.00%)}	_{2,865,735k (± 0.00%)}	_~	_2,865,702k	_2,865,781k	_{p=0.173 n=6}
_{Parse Time}	_{10.78s (± 0.40%)}	_{10.77s (± 0.29%)}	_~	_10.74s	_10.81s	_{p=1.000 n=6}
_{Bind Time}	_{3.44s (± 0.43%)}	_{3.44s (± 0.57%)}	_~	_3.41s	_3.46s	_{p=0.868 n=6}
_{Check Time}	_{61.20s (± 0.56%)}	_{61.22s (± 0.47%)}	_~	_60.93s	_61.57s	_{p=0.810 n=6}
_{Emit Time}	_{16.24s (± 0.93%)}	_{16.20s (± 0.38%)}	_~	_16.14s	_16.28s	_{p=0.688 n=6}
_{Total Time}	_{91.66s (± 0.53%)}	_{91.63s (± 0.32%)}	_~	_91.36s	_92.02s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{397,043k (± 0.01%)}	_{397,066k (± 0.02%)}	_~	_396,956k	_397,143k	_{p=0.378 n=6}
_{Parse Time}	_{3.12s (± 0.55%)}	_{3.13s (± 0.77%)}	_~	_3.11s	_3.17s	_{p=1.000 n=6}
_{Bind Time}	_{1.39s (± 0.76%)}	_{1.39s (± 1.67%)}	_~	_1.37s	_1.43s	_{p=0.869 n=6}
_{Check Time}	_{14.03s (± 0.41%)}	_{13.99s (± 0.41%)}	_~	_13.88s	_14.05s	_{p=0.462 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.53s (± 0.33%)}	_{18.50s (± 0.34%)}	_~	_18.39s	_18.58s	_{p=0.684 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,137k (± 0.01%)}	_{513,159k (± 0.01%)}	_~	_513,104k	_513,207k	_{p=0.471 n=6}
_{Parse Time}	_{3.27s (± 0.32%)}	_{3.28s (± 0.31%)}	_~	_3.27s	_3.30s	_{p=0.134 n=6}
_{Bind Time}	_{1.54s (± 0.34%)}	_{1.54s (± 0.33%)}	_~	_1.54s	_1.55s	_{p=0.069 n=6}
_{Check Time}	_{2.86s (± 0.36%)}	_{2.85s (± 0.42%)}	_~	_2.84s	_2.87s	_{p=0.211 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.25%)}	_{7.75s (± 0.18%)}	_~	_7.73s	_7.77s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,343ms (± 0.76%)}	_{2,342ms (± 0.74%)}	_~	_2,322ms	_2,361ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{5,610ms (± 1.10%)}	_{5,646ms (± 0.17%)}	_~	_5,636ms	_5,661ms	_{p=0.230 n=6}
_{Req 3 - references}	_{324ms (± 1.19%)}	_{323ms (± 0.89%)}	_~	_321ms	_329ms	_{p=0.554 n=6}
_{Req 4 - navto}	_{274ms (± 0.60%)}	_{272ms (± 0.19%)}	_{-2ms (- 0.67%)}	_271ms	_272ms	_{p=0.039 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{91ms (± 6.30%)}	_{93ms (± 0.81%)}	_~	_92ms	_94ms	_{p=0.340 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,506ms (± 0.86%)}	_{2,501ms (± 0.99%)}	_~	_2,474ms	_2,529ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{4,205ms (± 1.93%)}	_{4,279ms (± 0.16%)}	_~	_4,266ms	_4,285ms	_{p=0.128 n=6}
_{Req 3 - references}	_{338ms (± 1.50%)}	_{335ms (± 1.02%)}	_~	_332ms	_340ms	_{p=0.418 n=6}
_{Req 4 - navto}	_{285ms (± 0.29%)}	_{284ms (± 0.35%)}	_~	_283ms	_285ms	_{p=0.181 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 7.08%)}	_{82ms (± 5.71%)}	_~	_78ms	_88ms	_{p=0.155 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,603ms (± 0.47%)}	_{2,620ms (± 0.26%)}	_{+17ms (+ 0.63%)}	_2,613ms	_2,631ms	_{p=0.025 n=6}
_{Req 2 - geterr}	_{1,720ms (± 1.98%)}	_{1,744ms (± 1.79%)}	_~	_1,716ms	_1,788ms	_{p=0.128 n=6}
_{Req 3 - references}	_{124ms (± 7.12%)}	_{119ms (± 9.17%)}	_~	_104ms	_128ms	_{p=0.119 n=6}
_{Req 4 - navto}	_{371ms (± 0.43%)}	_{372ms (± 0.88%)}	_~	_366ms	_375ms	_{p=0.289 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{307ms (± 1.82%)}	_{306ms (± 2.27%)}	_~	_298ms	_314ms	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.80ms (± 0.16%)}	_{152.74ms (± 0.17%)}	_{-0.06ms (- 0.04%)}	_151.68ms	_157.24ms	_{p=0.010 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.15ms (± 0.16%)}	_{228.01ms (± 0.14%)}	_{-1.13ms (- 0.49%)}	_226.30ms	_233.80ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.63ms (± 0.15%)}	_{221.64ms (± 0.15%)}	_~	_220.05ms	_224.85ms	_{p=0.560 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.62ms (± 0.16%)}	_{221.72ms (± 0.16%)}	_{+0.10ms (+ 0.04%)}	_220.15ms	_225.47ms	_{p=0.009 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-03-08T22:50:51Z

No perf impact, nice. (Was not expecting any, but still.)

Herebyfile.mjs

weswigham

Should we do a const {...} = ts.server; at the top of the changed files, to keep the diff minimal and the accesses more static? Though I guess that won't work for types and we never added support for import {...} = ts.server iirc.

jakebailey · 2024-03-15T18:33:19Z

Sure, let me give that a try, though I think most of these are actually types that change? Not sure if I can named import using an import = like that to grab the namespace...

weswigham

Either way this is fine, it'd probably just be nice if we didn't have to do the long ts.server everywhere in these files and could retain the short direct references.

jakebailey · 2024-03-15T18:47:23Z

I couldn't figure out how to get named imports from a nested object like that, but was able to do something slightly different by reexporting the namespaces through the older files, which keeps the diff minimal.

This won't really work for ESM but that's another day.

jakebailey · 2024-03-15T18:49:39Z

@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2024-03-15T18:49:42Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-03-15T18:54:13Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160436/artifacts?artifactName=tgz&fileId=B48BA0209CD400AD4C7FAB644A870E08C4DB5B3BA9699740862DA9D4B6CC2EA702&fileName=/typescript-5.5.0-insiders.20240315.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-55326-12".;

typescript-bot · 2024-03-15T20:05:30Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,680k (± 0.01%)}	_{295,682k (± 0.01%)}	_~	_295,653k	_295,710k	_{p=0.470 n=6}
_{Parse Time}	_{2.66s (± 0.19%)}	_{2.66s (± 0.41%)}	_~	_2.65s	_2.68s	_{p=0.324 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.282 n=6}
_{Check Time}	_{8.22s (± 0.28%)}	_{8.22s (± 0.37%)}	_~	_8.18s	_8.25s	_{p=0.746 n=6}
_{Emit Time}	_{7.16s (± 0.44%)}	_{7.15s (± 0.11%)}	_~	_7.14s	_7.16s	_{p=1.000 n=6}
_{Total Time}	_{18.87s (± 0.20%)}	_{18.86s (± 0.14%)}	_~	_18.82s	_18.88s	_{p=0.568 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{194,367k (± 0.91%)}	_{193,207k (± 0.93%)}	_~	_192,012k	_195,539k	_{p=0.471 n=6}
_{Parse Time}	_{1.36s (± 1.08%)}	_{1.36s (± 1.43%)}	_~	_1.33s	_1.39s	_{p=0.683 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.53s (± 0.48%)}	_{9.49s (± 0.56%)}	_~	_9.43s	_9.56s	_{p=0.228 n=6}
_{Emit Time}	_{2.64s (± 0.65%)}	_{2.65s (± 0.53%)}	_~	_2.63s	_2.67s	_{p=0.370 n=6}
_{Total Time}	_{14.26s (± 0.45%)}	_{14.22s (± 0.50%)}	_~	_14.14s	_14.33s	_{p=0.295 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,378k (± 0.00%)}	_{347,382k (± 0.00%)}	_~	_347,371k	_347,391k	_{p=0.748 n=6}
_{Parse Time}	_{2.47s (± 0.49%)}	_{2.48s (± 0.47%)}	_~	_2.46s	_2.49s	_{p=0.507 n=6}
_{Bind Time}	_{0.93s (± 0.90%)}	_{0.93s (± 0.68%)}	_~	_0.92s	_0.94s	_{p=0.226 n=6}
_{Check Time}	_{7.02s (± 0.45%)}	_{7.01s (± 0.31%)}	_~	_6.98s	_7.04s	_{p=0.517 n=6}
_{Emit Time}	_{4.08s (± 0.26%)}	_{4.07s (± 0.18%)}	_~	_4.06s	_4.08s	_{p=0.273 n=6}
_{Total Time}	_{14.49s (± 0.18%)}	_{14.48s (± 0.19%)}	_~	_14.43s	_14.51s	_{p=0.514 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,752k (± 0.01%)}	_{302,754k (± 0.01%)}	_~	_302,711k	_302,777k	_{p=0.873 n=6}
_{Parse Time}	_{2.01s (± 0.81%)}	_{2.02s (± 0.49%)}	_~	_2.01s	_2.03s	_{p=0.934 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.00s (± 1.09%)}	_~	_0.99s	_1.02s	_{p=1.000 n=6}
_{Check Time}	_{6.30s (± 0.34%)}	_{6.32s (± 0.43%)}	_~	_6.28s	_6.36s	_{p=0.076 n=6}
_{Emit Time}	_{3.60s (± 0.64%)}	_{3.61s (± 0.21%)}	_~	_3.60s	_3.62s	_{p=0.621 n=6}
_{Total Time}	_{12.91s (± 0.21%)}	_{12.95s (± 0.14%)}	_{+0.04s (+ 0.34%)}	_12.93s	_12.98s	_{p=0.009 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,325k (± 0.01%)}	_{511,328k (± 0.01%)}	_~	_511,275k	_511,395k	_{p=1.000 n=6}
_{Parse Time}	_{2.64s (± 0.50%)}	_{2.65s (± 0.65%)}	_~	_2.63s	_2.67s	_{p=0.235 n=6}
_{Bind Time}	_{0.98s (± 0.85%)}	_{0.98s (± 0.77%)}	_~	_0.97s	_0.99s	_{p=0.652 n=6}
_{Check Time}	_{17.33s (± 0.48%)}	_{17.36s (± 0.57%)}	_~	_17.24s	_17.51s	_{p=0.747 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.43%)}	_{21.00s (± 0.47%)}	_~	_20.88s	_21.15s	_{p=0.630 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,798,063k (± 0.00%)}	_{1,798,076k (± 0.00%)}	_~	_1,798,024k	_1,798,104k	_{p=0.470 n=6}
_{Parse Time}	_{6.64s (± 0.49%)}	_{6.62s (± 0.54%)}	_~	_6.59s	_6.69s	_{p=0.467 n=6}
_{Bind Time}	_{2.38s (± 0.56%)}	_{2.39s (± 0.46%)}	_~	_2.37s	_2.40s	_{p=0.140 n=6}
_{Check Time}	_{59.00s (± 0.22%)}	_{59.16s (± 0.32%)}	_~	_58.91s	_59.44s	_{p=0.128 n=6}
_{Emit Time}	_{0.17s (± 3.32%)}	_{0.16s (± 3.16%)}	_~	_0.16s	_0.17s	_{p=0.640 n=6}
_{Total Time}	_{68.18s (± 0.24%)}	_{68.34s (± 0.28%)}	_~	_68.09s	_68.59s	_{p=0.199 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,397,480k (± 0.04%)}	_{2,398,319k (± 0.04%)}	_~	_2,396,829k	_2,399,594k	_{p=0.230 n=6}
_{Parse Time}	_{5.05s (± 0.38%)}	_{5.06s (± 0.72%)}	_~	_5.00s	_5.10s	_{p=0.628 n=6}
_{Bind Time}	_{1.91s (± 0.69%)}	_{1.90s (± 0.98%)}	_~	_1.88s	_1.92s	_{p=0.418 n=6}
_{Check Time}	_{33.75s (± 0.35%)}	_{33.88s (± 0.32%)}	_~	_33.67s	_33.98s	_{p=0.078 n=6}
_{Emit Time}	_{2.68s (± 0.62%)}	_{2.67s (± 1.71%)}	_~	_2.61s	_2.73s	_{p=0.574 n=6}
_{Total Time}	_{43.40s (± 0.25%)}	_{43.53s (± 0.28%)}	_{+0.13s (+ 0.30%)}	_43.34s	_43.71s	_{p=0.045 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,428k (± 0.01%)}	_{415,446k (± 0.01%)}	_~	_415,400k	_415,487k	_{p=0.521 n=6}
_{Parse Time}	_{2.80s (± 1.40%)}	_{2.78s (± 0.54%)}	_~	_2.77s	_2.81s	_{p=0.289 n=6}
_{Bind Time}	_{1.06s (± 0.49%)}	_{1.07s (± 0.38%)}	_{+0.01s (+ 0.78%)}	_1.07s	_1.08s	_{p=0.022 n=6}
_{Check Time}	_{15.26s (± 0.26%)}	_{15.22s (± 0.18%)}	_{-0.04s (- 0.29%)}	_15.17s	_15.24s	_{p=0.036 n=6}
_{Emit Time}	_{1.09s (± 1.38%)}	_{1.10s (± 0.89%)}	_~	_1.09s	_1.11s	_{p=0.621 n=6}
_{Total Time}	_{20.22s (± 0.35%)}	_{20.17s (± 0.19%)}	_~	_20.11s	_20.21s	_{p=0.199 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,880,512k (± 0.00%)}	_{2,880,569k (± 0.00%)}	_~	_2,880,547k	_2,880,600k	_{p=0.109 n=6}
_{Parse Time}	_{10.81s (± 0.26%)}	_{10.81s (± 0.29%)}	_~	_10.75s	_10.83s	_{p=0.746 n=6}
_{Bind Time}	_{3.47s (± 0.34%)}	_{3.47s (± 0.22%)}	_~	_3.46s	_3.48s	_{p=0.396 n=6}
_{Check Time}	_{61.70s (± 0.77%)}	_{61.64s (± 0.47%)}	_~	_61.16s	_61.92s	_{p=0.936 n=6}
_{Emit Time}	_{17.60s (±10.10%)}	_{16.99s (± 8.14%)}	_~	_16.31s	_19.81s	_{p=0.230 n=6}
_{Total Time}	_{93.57s (± 2.35%)}	_{92.91s (± 1.61%)}	_~	_91.90s	_95.89s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{406,564k (± 0.01%)}	_{406,586k (± 0.01%)}	_~	_406,508k	_406,666k	_{p=0.471 n=6}
_{Parse Time}	_{3.19s (± 1.28%)}	_{3.20s (± 0.73%)}	_~	_3.17s	_3.23s	_{p=0.746 n=6}
_{Bind Time}	_{1.38s (± 0.60%)}	_{1.38s (± 1.48%)}	_~	_1.36s	_1.42s	_{p=0.280 n=6}
_{Check Time}	_{14.26s (± 0.30%)}	_{14.27s (± 0.34%)}	_~	_14.22s	_14.34s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.84s (± 0.23%)}	_{18.85s (± 0.39%)}	_~	_18.76s	_18.95s	_{p=1.000 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,267k (± 0.01%)}	_{513,238k (± 0.01%)}	_~	_513,166k	_513,278k	_{p=0.575 n=6}
_{Parse Time}	_{3.28s (± 0.25%)}	_{3.28s (± 0.36%)}	_~	_3.26s	_3.29s	_{p=0.738 n=6}
_{Bind Time}	_{1.54s (± 0.49%)}	_{1.54s (± 0.41%)}	_~	_1.53s	_1.55s	_{p=0.718 n=6}
_{Check Time}	_{2.86s (± 0.76%)}	_{2.86s (± 0.95%)}	_~	_2.82s	_2.90s	_{p=1.000 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.43%)}	_{7.75s (± 0.44%)}	_~	_7.70s	_7.80s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,355ms (± 0.62%)}	_{2,346ms (± 0.75%)}	_~	_2,325ms	_2,370ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{5,683ms (± 1.53%)}	_{5,745ms (± 1.79%)}	_~	_5,601ms	_5,824ms	_{p=0.378 n=6}
_{Req 3 - references}	_{321ms (± 0.76%)}	_{343ms (± 8.47%)}	_{🔻+22ms (+ 6.70%)}	_323ms	_380ms	_{p=0.035 n=6}
_{Req 4 - navto}	_{276ms (± 0.42%)}	_{270ms (± 2.24%)}	_{-6ms (- 2.11%)}	_258ms	_273ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 3.03%)}	_{91ms (± 6.40%)}	_~	_83ms	_95ms	_{p=0.071 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,517ms (± 0.55%)}	_{2,489ms (± 0.73%)}	_{-28ms (- 1.11%)}	_2,470ms	_2,520ms	_{p=0.013 n=6}
_{Req 2 - geterr}	_{4,218ms (± 2.06%)}	_{4,146ms (± 0.27%)}	_~	_4,130ms	_4,157ms	_{p=0.378 n=6}
_{Req 3 - references}	_{332ms (± 0.68%)}	_{339ms (± 0.91%)}	_{+7ms (+ 2.11%)}	_335ms	_342ms	_{p=0.006 n=6}
_{Req 4 - navto}	_{285ms (± 0.52%)}	_{290ms (± 2.40%)}	_~	_284ms	_303ms	_{p=0.141 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 7.27%)}	_{86ms (± 7.08%)}	_~	_78ms	_90ms	_{p=0.176 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,614ms (± 0.20%)}	_{2,616ms (± 0.24%)}	_~	_2,605ms	_2,623ms	_{p=0.520 n=6}
_{Req 2 - geterr}	_{1,728ms (± 2.10%)}	_{1,767ms (± 0.75%)}	_~	_1,747ms	_1,786ms	_{p=0.065 n=6}
_{Req 3 - references}	_{120ms (± 8.22%)}	_{119ms (± 8.38%)}	_~	_105ms	_126ms	_{p=0.467 n=6}
_{Req 4 - navto}	_{370ms (± 0.75%)}	_{367ms (± 0.42%)}	_{-3ms (- 0.86%)}	_364ms	_368ms	_{p=0.043 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{306ms (± 1.69%)}	_{309ms (± 0.91%)}	_~	_306ms	_314ms	_{p=0.422 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.21ms (± 0.17%)}	_{153.23ms (± 0.17%)}	_~	_152.16ms	_156.10ms	_{p=0.992 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.56ms (± 0.16%)}	_{243.45ms (± 0.86%)}	_{🔻+13.89ms (+ 6.05%)}	_241.54ms	_280.25ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.64ms (± 0.14%)}	_{222.89ms (± 0.16%)}	_{+0.25ms (+ 0.11%)}	_221.42ms	_229.26ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.47ms (± 0.14%)}	_{221.47ms (± 0.15%)}	_~	_220.11ms	_225.85ms	_{p=0.957 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-03-15T20:11:58Z

I can see from the benchmark that the last commit made tsserver 6% slower to start. I confirmed that locally too. Probably the extra copy of the server object that gets made.

I'm going to revert it and stick with the version that uses ts.server.* instead to prevent that slowdown, and come back to this later to see if I've missed a better way to write this.

This reverts commit 1e5fd9d.

typescript-bot assigned jakebailey Aug 9, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 9, 2023

This comment was marked as outdated.

Sign in to view

Make tsserver a thin wrapper around tsserverlibrary

1aa4d3a

jakebailey force-pushed the thin-tsserver-wrapper branch from d2458e3 to 1aa4d3a Compare August 14, 2023 19:46

jakebailey changed the title ~~[experiment] Make tsserver a thin wrapper around tsserverlibrary.js (rather, typescript.js)~~ [experiment] Make tsserver a thin wrapper around API Aug 24, 2023

jakebailey added 7 commits December 11, 2023 12:16

Merge branch 'main' into thin-tsserver-wrapper

7d7f531

fmt

8318c80

Merge branch 'main' into thin-tsserver-wrapper

f693e45

Merge branch 'main' into thin-tsserver-wrapper

af14919

Rework a little

fde5d2f

yay node 14

9ffd92c

now do typingsInstaller

7184143

jakebailey changed the title ~~[experiment] Make tsserver a thin wrapper around API~~ Make tsserver and typingsInstaller thin wrappers around public API Mar 8, 2024

jakebailey added 2 commits March 8, 2024 14:14

Revert eslint config

dcf3c70

Simplfy terms

40601ab

jakebailey mentioned this pull request Mar 8, 2024

[experiment] make tsc use the public API #57703

Draft

jakebailey marked this pull request as ready for review March 9, 2024 00:51

jakebailey commented Mar 15, 2024

View reviewed changes

Herebyfile.mjs Outdated Show resolved Hide resolved

Update Herebyfile.mjs

273e354

jakebailey requested review from DanielRosenwasser and weswigham March 15, 2024 18:26

jakebailey requested a review from RyanCavanaugh March 15, 2024 18:26

weswigham reviewed Mar 15, 2024

View reviewed changes

weswigham approved these changes Mar 15, 2024

View reviewed changes

Merge branch 'main' into thin-tsserver-wrapper

a4c977f

DanielRosenwasser mentioned this pull request Mar 15, 2024

Design Meeting Notes, 3/15/2024 #57793

Open

Restore namespace files and pass through namespaces

1e5fd9d

Revert "Restore namespace files and pass through namespaces"

68b5ef5

This reverts commit 1e5fd9d.

jakebailey merged commit aeddd65 into microsoft:main Mar 15, 2024
26 checks passed

jakebailey deleted the thin-tsserver-wrapper branch March 15, 2024 20:25

This was referenced Mar 18, 2024

Don't indirect through _namespaces in tsserver/typingsInstaller #57829

Merged

Don't hide typescript.js from stack traces microsoft/typescript-error-deltas#149

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make tsserver and typingsInstaller thin wrappers around public API #55326

Make tsserver and typingsInstaller thin wrappers around public API #55326

jakebailey commented Aug 9, 2023 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

jakebailey commented Mar 8, 2024

typescript-bot commented Mar 8, 2024 •

edited

Loading

typescript-bot commented Mar 8, 2024 •

edited

Loading

typescript-bot commented Mar 8, 2024

tsc

tsserver

startup

jakebailey commented Mar 8, 2024

weswigham left a comment •

edited

Loading

jakebailey commented Mar 15, 2024

weswigham left a comment

jakebailey commented Mar 15, 2024

jakebailey commented Mar 15, 2024

typescript-bot commented Mar 15, 2024 •

edited

Loading

typescript-bot commented Mar 15, 2024 •

edited

Loading

typescript-bot commented Mar 15, 2024

tsc

tsserver

startup

jakebailey commented Mar 15, 2024

Make tsserver and typingsInstaller thin wrappers around public API #55326

Make tsserver and typingsInstaller thin wrappers around public API #55326

Conversation

jakebailey commented Aug 9, 2023 • edited Loading

Package size report

Overall package size

Files

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

jakebailey commented Mar 8, 2024

typescript-bot commented Mar 8, 2024 • edited Loading

typescript-bot commented Mar 8, 2024 • edited Loading

typescript-bot commented Mar 8, 2024

tsc

tsserver

startup

jakebailey commented Mar 8, 2024

weswigham left a comment • edited Loading

Choose a reason for hiding this comment

jakebailey commented Mar 15, 2024

weswigham left a comment

Choose a reason for hiding this comment

jakebailey commented Mar 15, 2024

jakebailey commented Mar 15, 2024

typescript-bot commented Mar 15, 2024 • edited Loading

typescript-bot commented Mar 15, 2024 • edited Loading

typescript-bot commented Mar 15, 2024

tsc

tsserver

startup

jakebailey commented Mar 15, 2024

jakebailey commented Aug 9, 2023 •

edited

Loading

typescript-bot commented Mar 8, 2024 •

edited

Loading

typescript-bot commented Mar 8, 2024 •

edited

Loading

weswigham left a comment •

edited

Loading

typescript-bot commented Mar 15, 2024 •

edited

Loading

typescript-bot commented Mar 15, 2024 •

edited

Loading