Fix export path patterns with .d.ts target extensions in AutoImportProvider #55815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
commented
Sep 21, 2023
| @@ -2212,7 +2212,11 @@ function loadEntrypointsFromExportMap( | |||
| scope.packageDirectory, | |||
| extensionsToExtensionsArray(extensions), | |||
| /*excludes*/ undefined, | |||
| [changeAnyExtension(target.replace("*", "**/*"), getDeclarationEmitExtensionForPath(target))], | |||
There was a problem hiding this comment.
This was turning *.d.ts into *.d.d.ts
jakebailey
reviewed
Sep 21, 2023
Comment on lines
+2217
to
+2218
| ? target.replace("*", "**/*") | ||
| : changeAnyExtension(target.replace("*", "**/*"), getDeclarationEmitExtensionForPath(target)), |
There was a problem hiding this comment.
Can't wait for CodeQL to complain about these
jakebailey
approved these changes
Sep 21, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| [changeAnyExtension(target.replace("*", "**/*"), getDeclarationEmitExtensionForPath(target))], | ||
| [ | ||
| isDeclarationFileName(target) | ||
| ? target.replace("*", "**/*") |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| [ | ||
| isDeclarationFileName(target) | ||
| ? target.replace("*", "**/*") | ||
| : changeAnyExtension(target.replace("*", "**/*"), getDeclarationEmitExtensionForPath(target)), |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
sheetalkamat
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53116 (a corner case of the 5.2 feature not working)