-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] Some tweaking to handle project references for auto import #55955
Conversation
May be we also need some tweaking if referenced project was discovered while |
We also could get info from opened referenced project instead of adding to auto import provider but I wanted to first check if we want something like this which understands referenced project or not before adding anything more to this experiment |
This was the approach I took in #47690 which ended up being problematic for the export info and module specifier caches. I forgot about this distinction when we talked the other day. I think using the |
4856328
to
2836e26
Compare
@andrewbranch ready for review |
…orts This also adds output file instead of input file names so that there is no deduplication needed and the correct paths are used for completions
42833f8
to
12f6c2e
Compare
@andrewbranch i had missed the editor services to update to check for same flag when i first pushed commit .. didn’t realize you already looked at it or I would I have made separate commit .. i will also add a test when that option is not set in host preferences just for completeness when I get to desk |
Fixes #55879