Ignore awaited self tail calls when collecting the return type of an async function #56020

Andarist · 2023-10-07T17:42:04Z

…async function

jakebailey · 2023-10-09T18:41:42Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-10-09T18:41:45Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 0d970e4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-09T18:41:45Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 0d970e4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-09T18:41:45Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 0d970e4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-09T18:41:45Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 0d970e4. You can monitor the build here.

Update: The results are in!

jakebailey

This seems correct to me. But, will wait for the extended results of course.

typescript-bot · 2023-10-09T18:59:52Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56020/merge:

There were infrastructure failures potentially unrelated to your change:

3 instances of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Something interesting changed - please have a look.

Details

webpack

tsconfig.json

[NEW] error TS2322: Type 'string | Set<string>' is not assignable to type 'string'.
- lib/DefinePlugin.js#L98
[NEW] error TS2345: Argument of type 'Promise<boolean>' is not assignable to parameter of type 'true | PromiseLike<true>'.
- lib/serialization/FileMiddleware.js#L516

tsconfig.types.json

[NEW] error TS2322: Type 'string | Set<string> | undefined' is not assignable to type 'string | undefined'.
- lib/DefinePlugin.js#L98
[NEW] error TS2345: Argument of type 'Promise<boolean>' is not assignable to parameter of type 'true | PromiseLike<true>'.
- lib/serialization/FileMiddleware.js#L516
[NEW] error TS2322: Type '() => T | undefined' is not assignable to type 'FunctionReturning<T>'.
- lib/util/memoize.js#L18

jakebailey · 2023-10-09T19:01:01Z

Hm, seems like this might be wrong as it's removing the JSDoc annotation around parens.

See above

typescript-bot · 2023-10-09T19:08:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,098k (± 0.02%)}	_{295,067k (± 0.01%)}	_~	_295,032k	_295,102k	_{p=0.149 n=6}
_{Parse Time}	_{2.64s (± 0.65%)}	_{2.62s (± 0.82%)}	_~	_2.59s	_2.64s	_{p=0.147 n=6}
_{Bind Time}	_{0.84s (± 0.90%)}	_{0.84s (± 1.17%)}	_~	_0.83s	_0.85s	_{p=1.000 n=6}
_{Check Time}	_{8.09s (± 0.25%)}	_{8.07s (± 0.28%)}	_~	_8.05s	_8.10s	_{p=0.192 n=6}
_{Emit Time}	_{7.04s (± 0.35%)}	_{7.06s (± 0.15%)}	_~	_7.05s	_7.08s	_{p=0.054 n=6}
_{Total Time}	_{18.61s (± 0.08%)}	_{18.59s (± 0.23%)}	_~	_18.54s	_18.65s	_{p=0.517 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,024k (± 1.51%)}	_{192,549k (± 1.56%)}	_~	_190,599k	_196,461k	_{p=0.936 n=6}
_{Parse Time}	_{1.35s (± 0.38%)}	_{1.34s (± 0.62%)}	_~	_1.33s	_1.35s	_{p=0.923 n=6}
_{Bind Time}	_{0.73s (± 0.56%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.14s (± 0.59%)}	_{9.12s (± 0.56%)}	_~	_9.05s	_9.19s	_{p=0.421 n=6}
_{Emit Time}	_{2.64s (± 0.65%)}	_{2.64s (± 0.52%)}	_~	_2.61s	_2.65s	_{p=0.738 n=6}
_{Total Time}	_{13.86s (± 0.31%)}	_{13.83s (± 0.40%)}	_~	_13.78s	_13.90s	_{p=0.257 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,302k (± 0.01%)}	_{347,303k (± 0.01%)}	_~	_347,278k	_347,326k	_{p=1.000 n=6}
_{Parse Time}	_{2.45s (± 0.48%)}	_{2.45s (± 0.49%)}	_~	_2.44s	_2.47s	_{p=0.563 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.67%)}	_~	_0.93s	_0.95s	_{p=0.673 n=6}
_{Check Time}	_{6.91s (± 0.62%)}	_{6.93s (± 0.51%)}	_~	_6.88s	_6.97s	_{p=0.628 n=6}
_{Emit Time}	_{4.02s (± 0.26%)}	_{4.01s (± 0.35%)}	_~	_3.99s	_4.03s	_{p=0.410 n=6}
_{Total Time}	_{14.33s (± 0.25%)}	_{14.33s (± 0.24%)}	_~	_14.27s	_14.36s	_{p=0.687 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,579k (± 0.02%)}	_{302,588k (± 0.01%)}	_~	_302,540k	_302,617k	_{p=0.689 n=6}
_{Parse Time}	_{1.99s (± 0.84%)}	_{2.00s (± 1.45%)}	_~	_1.96s	_2.04s	_{p=0.624 n=6}
_{Bind Time}	_{1.01s (± 1.53%)}	_{1.01s (± 0.88%)}	_~	_1.00s	_1.02s	_{p=0.796 n=6}
_{Check Time}	_{6.26s (± 0.31%)}	_{6.25s (± 0.29%)}	_~	_6.23s	_6.27s	_{p=0.254 n=6}
_{Emit Time}	_{3.57s (± 0.50%)}	_{3.55s (± 0.41%)}	_~	_3.54s	_3.57s	_{p=0.082 n=6}
_{Total Time}	_{12.83s (± 0.20%)}	_{12.80s (± 0.32%)}	_~	_12.75s	_12.85s	_{p=0.421 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,492k (± 0.01%)}	_{470,493k (± 0.00%)}	_~	_470,460k	_470,509k	_{p=0.936 n=6}
_{Parse Time}	_{2.58s (± 0.32%)}	_{2.57s (± 0.63%)}	_~	_2.55s	_2.60s	_{p=0.605 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{1.00s (± 1.17%)}	_~	_0.99s	_1.02s	_{p=0.432 n=6}
_{Check Time}	_{16.62s (± 0.24%)}	_{16.59s (± 0.50%)}	_~	_16.45s	_16.66s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.20s (± 0.21%)}	_{20.16s (± 0.39%)}	_~	_20.02s	_20.24s	_{p=0.686 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,600k (± 0.00%)}	_{512,608k (± 0.02%)}	_~	_512,534k	_512,746k	_{p=0.471 n=6}
_{Parse Time}	_{3.27s (± 0.45%)}	_{3.27s (± 0.30%)}	_~	_3.26s	_3.28s	_{p=0.796 n=6}
_{Bind Time}	_{1.55s (± 0.26%)}	_{1.55s (± 0.48%)}	_~	_1.54s	_1.56s	_{p=1.000 n=6}
_{Check Time}	_{2.86s (± 1.07%)}	_{2.87s (± 1.16%)}	_~	_2.84s	_2.93s	_{p=0.520 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.51%)}	_{7.77s (± 0.40%)}	_~	_7.75s	_7.83s	_{p=0.467 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,362ms (± 1.59%)}	_{2,370ms (± 1.23%)}	_~	_2,335ms	_2,409ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{5,389ms (± 1.44%)}	_{5,394ms (± 1.39%)}	_~	_5,284ms	_5,449ms	_{p=0.688 n=6}
_{Req 3 - references}	_{329ms (± 0.92%)}	_{330ms (± 1.47%)}	_~	_325ms	_336ms	_{p=0.807 n=6}
_{Req 4 - navto}	_{275ms (± 1.37%)}	_{276ms (± 1.44%)}	_~	_271ms	_281ms	_{p=0.807 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 8.67%)}	_{86ms (± 8.35%)}	_~	_74ms	_90ms	_{p=0.789 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,458ms (± 0.86%)}	_{2,470ms (± 1.14%)}	_~	_2,426ms	_2,497ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{4,159ms (± 1.94%)}	_{4,161ms (± 1.86%)}	_~	_4,058ms	_4,227ms	_{p=0.747 n=6}
_{Req 3 - references}	_{336ms (± 1.36%)}	_{336ms (± 1.32%)}	_~	_332ms	_342ms	_{p=0.869 n=6}
_{Req 4 - navto}	_{283ms (± 0.27%)}	_{283ms (± 0.47%)}	_~	_281ms	_285ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 7.32%)}	_{79ms (± 7.50%)}	_~	_75ms	_87ms	_{p=0.798 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,600ms (± 0.40%)}	_{2,595ms (± 0.73%)}	_~	_2,564ms	_2,618ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{1,679ms (± 0.86%)}	_{1,671ms (± 2.25%)}	_~	_1,635ms	_1,733ms	_{p=0.298 n=6}
_{Req 3 - references}	_{113ms (± 9.36%)}	_{113ms (± 9.38%)}	_~	_106ms	_127ms	_{p=0.492 n=6}
_{Req 4 - navto}	_{360ms (± 0.38%)}	_{359ms (± 0.21%)}	_~	_358ms	_360ms	_{p=0.740 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{303ms (± 2.48%)}	_{305ms (± 0.92%)}	_~	_299ms	_307ms	_{p=0.744 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.57ms (± 0.17%)}	_{152.36ms (± 0.18%)}	_{-0.21ms (- 0.14%)}	_151.25ms	_155.05ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.69ms (± 0.16%)}	_{227.59ms (± 0.16%)}	_{-0.10ms (- 0.05%)}	_226.04ms	_233.61ms	_{p=0.006 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.05ms (± 0.16%)}	_{228.97ms (± 0.18%)}	_{-0.08ms (- 0.04%)}	_227.37ms	_235.65ms	_{p=0.015 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.84ms (± 0.17%)}	_{228.82ms (± 0.16%)}	_~	_227.31ms	_233.92ms	_{p=0.739 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2023-10-09T19:31:19Z

Of course, someone's already thought of this. We need:

skipParentheses(node, /*excludeJSDocTypeAssertions*/ true)

typescript-bot · 2023-10-09T20:11:29Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-10-09T20:29:23Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56020/merge:

Everything looks good!

jakebailey · 2023-10-09T21:27:13Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-10-09T21:27:16Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at cd61223. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-09T21:27:16Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at cd61223. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-09T21:27:16Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at cd61223. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-09T21:27:16Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at cd61223. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-09T21:44:27Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56020/merge:

There were infrastructure failures potentially unrelated to your change:

3 instances of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2023-10-09T21:47:57Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,106k (± 0.01%)}	_{295,104k (± 0.01%)}	_~	_295,068k	_295,155k	_{p=1.000 n=6}
_{Parse Time}	_{2.64s (± 0.71%)}	_{2.64s (± 0.32%)}	_~	_2.62s	_2.64s	_{p=0.607 n=6}
_{Bind Time}	_{0.84s (± 0.89%)}	_{0.84s (± 1.17%)}	_~	_0.83s	_0.85s	_{p=0.554 n=6}
_{Check Time}	_{8.09s (± 0.39%)}	_{8.08s (± 0.36%)}	_~	_8.04s	_8.11s	_{p=0.935 n=6}
_{Emit Time}	_{7.05s (± 0.31%)}	_{7.06s (± 0.38%)}	_~	_7.03s	_7.10s	_{p=0.935 n=6}
_{Total Time}	_{18.61s (± 0.14%)}	_{18.61s (± 0.22%)}	_~	_18.57s	_18.68s	_{p=0.747 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,562k (± 1.55%)}	_{192,552k (± 1.56%)}	_~	_190,577k	_196,484k	_{p=0.521 n=6}
_{Parse Time}	_{1.33s (± 0.91%)}	_{1.34s (± 1.02%)}	_~	_1.32s	_1.36s	_{p=0.059 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.12s (± 0.44%)}	_{9.13s (± 0.27%)}	_~	_9.10s	_9.17s	_{p=0.686 n=6}
_{Emit Time}	_{2.63s (± 0.81%)}	_{2.63s (± 0.71%)}	_~	_2.61s	_2.66s	_{p=0.871 n=6}
_{Total Time}	_{13.80s (± 0.31%)}	_{13.83s (± 0.16%)}	_~	_13.79s	_13.86s	_{p=0.570 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,295k (± 0.00%)}	_{347,304k (± 0.00%)}	_~	_347,284k	_347,316k	_{p=0.173 n=6}
_{Parse Time}	_{2.46s (± 0.21%)}	_{2.45s (± 0.52%)}	_~	_2.44s	_2.47s	_{p=0.273 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.89s (± 0.48%)}	_{6.91s (± 0.37%)}	_~	_6.88s	_6.94s	_{p=0.252 n=6}
_{Emit Time}	_{4.01s (± 0.27%)}	_{4.01s (± 0.40%)}	_~	_3.99s	_4.03s	_{p=0.933 n=6}
_{Total Time}	_{14.30s (± 0.20%)}	_{14.31s (± 0.22%)}	_~	_14.27s	_14.35s	_{p=0.627 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,600k (± 0.01%)}	_{302,574k (± 0.01%)}	_~	_302,533k	_302,631k	_{p=0.230 n=6}
_{Parse Time}	_{2.00s (± 0.88%)}	_{2.00s (± 0.61%)}	_~	_1.98s	_2.01s	_{p=0.869 n=6}
_{Bind Time}	_{1.01s (± 1.16%)}	_{1.01s (± 1.62%)}	_~	_0.99s	_1.03s	_{p=0.870 n=6}
_{Check Time}	_{6.25s (± 0.36%)}	_{6.28s (± 0.47%)}	_~	_6.23s	_6.32s	_{p=0.145 n=6}
_{Emit Time}	_{3.56s (± 0.57%)}	_{3.57s (± 0.14%)}	_~	_3.56s	_3.57s	_{p=0.667 n=6}
_{Total Time}	_{12.82s (± 0.23%)}	_{12.85s (± 0.31%)}	_~	_12.79s	_12.91s	_{p=0.260 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,480k (± 0.00%)}	_{470,493k (± 0.00%)}	_~	_470,478k	_470,514k	_{p=0.378 n=6}
_{Parse Time}	_{2.58s (± 0.64%)}	_{2.57s (± 0.38%)}	_~	_2.55s	_2.58s	_{p=0.070 n=6}
_{Bind Time}	_{0.99s (± 1.22%)}	_{0.99s (± 0.64%)}	_~	_0.98s	_1.00s	_{p=0.673 n=6}
_{Check Time}	_{16.60s (± 0.44%)}	_{16.61s (± 0.41%)}	_~	_16.49s	_16.69s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.18s (± 0.42%)}	_{20.16s (± 0.34%)}	_~	_20.05s	_20.25s	_{p=0.936 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,623k (± 0.01%)}	_{512,607k (± 0.00%)}	_~	_512,586k	_512,639k	_{p=0.936 n=6}
_{Parse Time}	_{3.27s (± 0.57%)}	_{3.28s (± 0.26%)}	_~	_3.26s	_3.28s	_{p=0.300 n=6}
_{Bind Time}	_{1.55s (± 0.63%)}	_{1.55s (± 0.00%)}	_~	_1.55s	_1.55s	_{p=0.652 n=6}
_{Check Time}	_{2.88s (± 1.17%)}	_{2.86s (± 0.41%)}	_~	_2.84s	_2.87s	_{p=0.512 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{7.77s (± 0.39%)}	_{7.76s (± 0.28%)}	_~	_7.73s	_7.79s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,386ms (± 0.99%)}	_{2,385ms (± 0.93%)}	_~	_2,357ms	_2,422ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{5,302ms (± 1.30%)}	_{5,320ms (± 1.15%)}	_~	_5,267ms	_5,440ms	_{p=0.261 n=6}
_{Req 3 - references}	_{326ms (± 0.79%)}	_{325ms (± 0.42%)}	_~	_323ms	_327ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{279ms (± 1.02%)}	_{279ms (± 0.98%)}	_~	_274ms	_282ms	_{p=0.599 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 7.42%)}	_{79ms (± 7.24%)}	_~	_75ms	_90ms	_{p=0.871 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,487ms (± 1.06%)}	_{2,468ms (± 0.58%)}	_~	_2,448ms	_2,485ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{4,135ms (± 2.20%)}	_{4,135ms (± 1.98%)}	_~	_4,054ms	_4,219ms	_{p=0.810 n=6}
_{Req 3 - references}	_{338ms (± 1.64%)}	_{338ms (± 1.69%)}	_~	_332ms	_344ms	_{p=0.622 n=6}
_{Req 4 - navto}	_{284ms (± 0.47%)}	_{284ms (± 0.26%)}	_~	_283ms	_285ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 7.23%)}	_{81ms (± 6.54%)}	_~	_76ms	_87ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,600ms (± 0.55%)}	_{2,586ms (± 0.63%)}	_~	_2,565ms	_2,614ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{1,712ms (± 1.92%)}	_{1,727ms (± 1.71%)}	_~	_1,679ms	_1,758ms	_{p=0.688 n=6}
_{Req 3 - references}	_{112ms (± 9.08%)}	_{111ms (± 8.15%)}	_~	_105ms	_128ms	_{p=0.685 n=6}
_{Req 4 - navto}	_{359ms (± 0.33%)}	_{360ms (± 0.45%)}	_~	_358ms	_362ms	_{p=0.680 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{306ms (± 2.69%)}	_{310ms (± 1.01%)}	_~	_306ms	_315ms	_{p=0.229 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.45ms (± 0.17%)}	_{152.36ms (± 0.17%)}	_{-0.09ms (- 0.06%)}	_151.19ms	_154.85ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.70ms (± 0.14%)}	_{227.67ms (± 0.17%)}	_~	_226.22ms	_233.66ms	_{p=0.059 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.03ms (± 0.16%)}	_{229.02ms (± 0.18%)}	_~	_227.45ms	_234.98ms	_{p=0.411 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.29ms (± 0.15%)}	_{228.52ms (± 0.17%)}	_{+0.23ms (+ 0.10%)}	_227.04ms	_235.29ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

RyanCavanaugh · 2023-10-09T21:59:25Z

@typescript-bot pack this

typescript-bot · 2023-10-09T21:59:28Z

Heya @RyanCavanaugh, I've started to run the tarball bundle task on this PR at cd61223. You can monitor the build here.

typescript-bot · 2023-10-09T22:01:03Z

Hey @RyanCavanaugh, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158158/artifacts?artifactName=tgz&fileId=B20185A36910C47D10FD2F8CBF521D04B667A7B38918E973DBE89A6F63B13F3F02&fileName=/typescript-5.3.0-insiders.20231009.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-56020-20".;

jakebailey

Seems correct to me (again)... 😄

typescript-bot · 2023-10-09T22:57:50Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-10-09T23:22:27Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56020/merge:

Everything looks good!

Ignore awaited self tail calls when collecting the return type of an …

0d970e4

…async function

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 7, 2023

jakebailey previously approved these changes Oct 9, 2023

View reviewed changes

jakebailey mentioned this pull request Oct 9, 2023

Fixed type narrowing in switch statements with parenthesized expressions #56035

Merged

Andarist added 2 commits October 9, 2023 22:31

fixed jsdoc casts

021f6cd

add correct lib setting to the added test case

cd61223

Andarist requested a review from jakebailey October 9, 2023 20:56

jakebailey approved these changes Oct 9, 2023

View reviewed changes

RyanCavanaugh merged commit 521f8a8 into microsoft:main Oct 10, 2023

Andarist deleted the awaitedTailCalls branch October 10, 2023 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ignore awaited self tail calls when collecting the return type of an async function #56020

Ignore awaited self tail calls when collecting the return type of an async function #56020

Andarist commented Oct 7, 2023

jakebailey commented Oct 9, 2023

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

jakebailey left a comment

typescript-bot commented Oct 9, 2023

webpack

tsconfig.json

tsconfig.types.json

jakebailey commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

Compiler

tsserver

Startup

jakebailey commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

jakebailey commented Oct 9, 2023

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

Compiler

tsserver

Startup

RyanCavanaugh commented Oct 9, 2023

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

jakebailey left a comment

typescript-bot commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

Ignore awaited self tail calls when collecting the return type of an async function #56020

Ignore awaited self tail calls when collecting the return type of an async function #56020

Conversation

Andarist commented Oct 7, 2023

jakebailey commented Oct 9, 2023

typescript-bot commented Oct 9, 2023 • edited Loading

typescript-bot commented Oct 9, 2023 • edited Loading

typescript-bot commented Oct 9, 2023 • edited Loading

typescript-bot commented Oct 9, 2023 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Oct 9, 2023

webpack

tsconfig.json

tsconfig.types.json

jakebailey commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

Compiler

tsserver

Startup

jakebailey commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

jakebailey commented Oct 9, 2023

typescript-bot commented Oct 9, 2023 • edited Loading

typescript-bot commented Oct 9, 2023 • edited Loading

typescript-bot commented Oct 9, 2023 • edited Loading

typescript-bot commented Oct 9, 2023 • edited Loading

typescript-bot commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

Compiler

tsserver

Startup

RyanCavanaugh commented Oct 9, 2023

typescript-bot commented Oct 9, 2023 • edited Loading

typescript-bot commented Oct 9, 2023 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Oct 9, 2023

typescript-bot commented Oct 9, 2023

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading