-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer conditional types with parenthesized multi-element tuple types in extends
clause
#56271
Defer conditional types with parenthesized multi-element tuple types in extends
clause
#56271
Conversation
…in `extends` clause
As per my comments here I don't think we want this to change. |
Reopening on @jakebailey’s request |
@typescript-bot pack this |
Heya @jakebailey, I've started to run the tarball bundle task on this PR at ec113c0. You can monitor the build here. |
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
If we were resolving from the inside out, rather than the outside in, we would also cover cases like |
I'm not sure if this is what you mean, but potentially a better fix would have been to strip parens around anything passed into |
Well, that can't be the actual implementation, but almost. I'll send a PR for discussion as the parens inside are still significant (and my intention was to not have that be the case). |
I am confusing myself; this doesn't matter; Basically, the intent is just "parens don't affect semantics"; anything else is out of scope. |
I think "out of scope" covers it. But what I meant was an inside-to-outside order processing of nodes to types. That would include stripping parens, but also more. |
…in `extends` clause (microsoft#56271) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
fixes #56270