Various fixes for sourcemap and breakpoints of decorators #5724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er skipping trivia from decorators end
…akpoint on all the decorators On resolution, this would be call to __decorate
…and not from decorators
…corator expression
| @@ -5685,10 +5685,10 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, Promi | |||
| function emitDecoratorsOfConstructor(node: ClassLikeDeclaration) { | |||
| const decorators = node.decorators; | |||
| const constructor = getFirstConstructorWithBody(node); | |||
| const hasDecoratedParameters = constructor && forEach(constructor.parameters, nodeIsDecorated); | |||
| const parameterDecorators = constructor && forEach(constructor.parameters, parameter => parameter.decorators); | |||
There was a problem hiding this comment.
this is just the first paramter decorator, what about the rest?
There was a problem hiding this comment.
i see, never mind, i would rename this as firstParameterDecorator to avoid the confusion.
|
looks good. please coordinate with @rbuckton on which change go in first. |
sheetalkamat
added a commit
that referenced
this pull request
Nov 30, 2015
Various fixes for sourcemap and breakpoints of decorators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #5584