Disambiguate string literal types from other string literals. #5725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a type position.
| @@ -4531,7 +4531,7 @@ namespace ts { | |||
| return links.resolvedType; | |||
| } | |||
|
|
|||
| function getStringLiteralType(node: StringLiteral): StringLiteralType { | |||
| function getStringLiteralType(node: StringLiteral | StringLiteralTypeNode): StringLiteralType { | |||
There was a problem hiding this comment.
Maybe this should just take the string and call it getStringLiteralTypeForText; what are your thoughts?
There was a problem hiding this comment.
No need to change the name, I can just change the argument to be a string.
|
Can you add those two examples we talked about that caused crashes? |
|
@DanielRosenwasser Were you talking about the Debug.assert when combining a What was the other example? |
|
I don't remember either. Let that be a lesson to both of us. 😞 Otherwise 👍 |
rbuckton
added a commit
that referenced
this pull request
Nov 24, 2015
Disambiguate string literal types from other string literals.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional type cleanup, partially based on this suggestion: #5719 (comment).
Also splits off template literal fragments into a separate type that is not
LiteralExpression.Supports #5595.