apply 'noImplicitReturns' rule for functions that don't have type an… #5733
Conversation
| @@ -9815,13 +9815,19 @@ namespace ts { | |||
| // An explicitly typed function whose return type isn't the Void or the Any type | |||
| // must have at least one return statement somewhere in its body. | |||
| // An exception to this rule is if the function implementation consists of a single 'throw' statement. | |||
| // @param returnType - return type of the function, can be undefined if return type is not explicitly specified | |||
There was a problem hiding this comment.
This should be switched to JSDoc
|
Can you add a test for |
| // Functions that return 'void' or 'any' don't need any return expressions. | ||
| if (returnType === voidType || isTypeAny(returnType)) { | ||
| // Functions with explicitly specified return type which is either 'void' or 'any' don't need any return expressions. | ||
| if (returnType && (returnType === voidType || isTypeAny(returnType))) { |
There was a problem hiding this comment.
What about a Promise<void> in an async function?
There was a problem hiding this comment.
for async functions returnType is contain promised type so in case of Promise<void> return type will be just void
|
I don't know how desirable the behavior is right now. I'm kind of torn on it - on one hand, this is great for people who wrote a Would a better approach be to just see if some non-void and non-any type can be inferred for the promised or returned type, and if so, perform the appropriate checking? |
|
If this was behavior by default then yes, we definitely should provide a way to opt out of this check. However in our case this is not a default behavior and user has explicitly asked (via compiler option) to do apply this rule. In this case putting another barrier for the rule seems redundant to me. |
| function checkAllCodePathsInNonVoidFunctionReturnOrThrow(func: FunctionLikeDeclaration, returnType: Type): void { | ||
| if (!produceDiagnostics) { | ||
| return; | ||
| } | ||
|
|
||
| // Functions that return 'void' or 'any' don't need any return expressions. | ||
| if (returnType === voidType || isTypeAny(returnType)) { | ||
| // Functions with with an explicitly specified 'void' or 'any' return type don't need any return expressions. |
|
👍 |
apply 'noImplicitReturns' rule for functions that don't have type an…
|
We have started rolling this out inside Google. However, we found a case that isn't caught, which I think it ought to be: Again I wonder whether you have the ability to perform these checks or auto-fix within eg. Azure to know whether the check has the right positive and negative cases. |
|
Oops, Evan found the issue for it already: #5916 |
…notations, since user has already opted-in to perform this check. This makes experience mentioned here (##228) slightly better since it will be very cumbersome to ask user to specify type annotations for all callbacks in promises