Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer type predicates from function bodies using control flow analysis #57465

Merged
merged 43 commits into from
Mar 15, 2024
Merged

Infer type predicates from function bodies using control flow analysis #57465

merged 43 commits into from
Mar 15, 2024

Commits on Feb 20, 2024

  1. Infer type predicates from function bodies

    @danvk
    danvk committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0c24ccc View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Run formatter

    @danvk
    danvk committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e2684f1 View commit details
    Browse the repository at this point in the history

  2. Add secondary subtype check and tests

    @danvk
    danvk committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    101df93 View commit details
    Browse the repository at this point in the history

  3. add union type test to baselines

    @danvk
    danvk committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d0e385e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. add prisma circularity test with failing baseline

    @danvk
    danvk committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a72b1f1 View commit details
    Browse the repository at this point in the history

  2. Various fixes for circularity issue

    @danvk
    danvk committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ef2d465 View commit details
    Browse the repository at this point in the history

  3. circularity test is fixed

    @danvk
    danvk committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9336052 View commit details
    Browse the repository at this point in the history

  4. revert back to CheckMode.TypeOnly

    @danvk
    danvk committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    41f624d View commit details
    Browse the repository at this point in the history

  5. Add test case for a predicate that throws

    @danvk
    danvk committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    52df115 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Drop isTriviallyNonBoolean, switch to simpler test, check for assertions

    @danvk
    danvk committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3ab6fae View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Use unescapeLeadingUnderscores

    @danvk
    danvk committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9591231 View commit details
    Browse the repository at this point in the history

  2. tests are fixed

    @danvk
    danvk committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9a8c0a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Always bind flow nodes to return statements + other fixes

    @ahejlsberg
    ahejlsberg committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a4ff6b4 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    869422f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'suggested-changes-57465' into infer-type-predicate-16069

    @danvk
    danvk committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    adbdc7d View commit details
    Browse the repository at this point in the history

  4. simplify

    @danvk
    danvk committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0dec9c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Delay expensive functionHasImplicitReturn call

    @ahejlsberg
    ahejlsberg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    703253a View commit details
    Browse the repository at this point in the history

  2. Avoid creating closures

    @ahejlsberg
    ahejlsberg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    c7f1c3d View commit details
    Browse the repository at this point in the history

  3. Add fallback isTypeAssignableTo check to test for equivalence

    @danvk
    danvk committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    25743a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. try caching the antecedent

    @danvk
    danvk committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4e79d76 View commit details
    Browse the repository at this point in the history

  2. revert fallback assignability check

    @danvk
    danvk committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    a5725d2 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Revert "try caching the antecedent" 

    This reverts commit 4e79d76.
    @danvk
    danvk committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3323573 View commit details
    Browse the repository at this point in the history

  2. Merge commit 'c7f1c3d309' into infer-type-predicate-16069

    @danvk
    danvk committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    76a5abd View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. accept baselines

    @danvk
    danvk committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5ec6f1f View commit details
    Browse the repository at this point in the history

  2. ignore rest parameters & update baseline

    @danvk
    danvk committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3491c78 View commit details
    Browse the repository at this point in the history

  3. switch to getParameterCount

    @danvk
    danvk committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c4ee1f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Revert "switch to getParameterCount" 

    This reverts commit c4ee1f0.
    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    4e934fa View commit details
    Browse the repository at this point in the history

  2. Revert "ignore rest parameters & update baseline" 

    This reverts commit 3491c78.
    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    37951ca View commit details
    Browse the repository at this point in the history

  3. Revert "accept baselines" 

    This reverts commit 5ec6f1f.
    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    cabed97 View commit details
    Browse the repository at this point in the history

  4. try setting @declaration: true

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6a88111 View commit details
    Browse the repository at this point in the history

  5. accept baselines

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    151d026 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into test-fix-expt-16069

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0b6a24a View commit details
    Browse the repository at this point in the history

  7. accept baseline

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0f31362 View commit details
    Browse the repository at this point in the history

  8. Add rest parameter test and accept baselines

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2354072 View commit details
    Browse the repository at this point in the history

  9. ignore rest parameters & update baseline

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f63105c View commit details
    Browse the repository at this point in the history

  10. switch to getParameterCount

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    eea3994 View commit details
    Browse the repository at this point in the history

  11. accept baseline

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e474bfc View commit details
    Browse the repository at this point in the history

  12. emit inferred type predicates in createReturnTypeOfSignatureDeclaration

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a6a734c View commit details
    Browse the repository at this point in the history

  13. accept baselines

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f5a9404 View commit details
    Browse the repository at this point in the history

  14. correct isDate / flakyIsDate pair

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    784e2a3 View commit details
    Browse the repository at this point in the history

  15. handle asserts predicates as well

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    33826df View commit details
    Browse the repository at this point in the history

  16. Pass flags for type predicate emit

    @danvk
    danvk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f002b28 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Factor out nodeBuilder.typePredicateToTypePredicateNode

    @danvk
    danvk committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    50803a0 View commit details
    Browse the repository at this point in the history