Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 5.5 deprecated compiler options #57527

Merged
merged 14 commits into from
Feb 28, 2024

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Feb 25, 2024

This removes all of the deprecated options listed in #51909 (except es3, which was removed separately in #57525).

Like #57525, the options aren't fully removed; we still need to error on them.

Package size report

Overall package size

Before After Diff Diff (percent)
Packed 5.52 MiB 5.52 MiB -4.63 KiB -0.08%
Unpacked 30.67 MiB 30.65 MiB -24.41 KiB -0.08%

Files

Before After Diff Diff (percent)
lib/tsc.js 5.57 MiB 5.56 MiB -7.59 KiB -0.13%
lib/tsserver.js 8.18 MiB 8.17 MiB -7.92 KiB -0.09%
lib/typescript.d.ts 579.90 KiB 580.33 KiB +441.00 B +0.07%
lib/typescript.js 8.66 MiB 8.65 MiB -8.13 KiB -0.09%
lib/typingsInstaller.js 1.67 MiB 1.67 MiB -1.21 KiB -0.07%

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 25, 2024
@jakebailey
Copy link
Member Author

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 25, 2024

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 310712f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 25, 2024

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 310712f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 25, 2024

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 310712f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 25, 2024

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 310712f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary.

@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/57527/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,654k (± 0.01%) 295,614k (± 0.01%) -40k (- 0.01%) 295,579k 295,644k p=0.020 n=6
Parse Time 2.66s (± 0.15%) 2.67s (± 0.31%) ~ 2.66s 2.68s p=0.248 n=6
Bind Time 0.83s (± 1.19%) 0.83s (± 0.99%) ~ 0.82s 0.84s p=0.862 n=6
Check Time 8.26s (± 0.25%) 8.22s (± 0.30%) -0.04s (- 0.42%) 8.18s 8.25s p=0.029 n=6
Emit Time 7.11s (± 0.27%) 7.12s (± 0.17%) ~ 7.11s 7.14s p=0.324 n=6
Total Time 18.86s (± 0.17%) 18.84s (± 0.16%) ~ 18.81s 18.89s p=0.420 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 192,994k (± 1.24%) 192,533k (± 1.24%) ~ 191,536k 197,426k p=0.066 n=6
Parse Time 1.36s (± 0.86%) 1.35s (± 0.61%) ~ 1.33s 1.35s p=0.056 n=6
Bind Time 0.72s (± 0.00%) 0.72s (± 0.00%) ~ 0.72s 0.72s p=1.000 n=6
Check Time 9.35s (± 0.54%) 9.38s (± 0.24%) ~ 9.36s 9.42s p=0.173 n=6
Emit Time 2.62s (± 0.63%) 2.62s (± 0.57%) ~ 2.59s 2.63s p=0.742 n=6
Total Time 14.04s (± 0.33%) 14.07s (± 0.20%) ~ 14.04s 14.11s p=0.293 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,480k (± 0.00%) 347,407k (± 0.01%) -73k (- 0.02%) 347,377k 347,455k p=0.008 n=6
Parse Time 2.48s (± 0.49%) 2.48s (± 0.59%) ~ 2.46s 2.50s p=0.408 n=6
Bind Time 0.92s (± 0.56%) 0.92s (± 0.59%) ~ 0.92s 0.93s p=0.640 n=6
Check Time 6.94s (± 0.22%) 6.97s (± 0.74%) ~ 6.91s 7.06s p=0.102 n=6
Emit Time 4.06s (± 0.24%) 4.07s (± 0.24%) ~ 4.06s 4.08s p=0.151 n=6
Total Time 14.39s (± 0.20%) 14.45s (± 0.33%) +0.05s (+ 0.37%) 14.39s 14.53s p=0.044 n=6
TFS - node (v18.15.0, x64)
Memory used 302,888k (± 0.02%) 302,828k (± 0.01%) -60k (- 0.02%) 302,807k 302,856k p=0.013 n=6
Parse Time 2.02s (± 0.75%) 2.02s (± 1.32%) ~ 1.97s 2.04s p=0.869 n=6
Bind Time 1.00s (± 1.03%) 1.00s (± 1.26%) ~ 0.99s 1.02s p=0.560 n=6
Check Time 6.38s (± 0.32%) 6.37s (± 0.33%) ~ 6.34s 6.39s p=0.684 n=6
Emit Time 3.60s (± 0.43%) 3.60s (± 0.14%) ~ 3.60s 3.61s p=0.929 n=6
Total Time 12.99s (± 0.33%) 12.99s (± 0.31%) ~ 12.93s 13.03s p=1.000 n=6
material-ui - node (v18.15.0, x64)
Memory used 511,343k (± 0.02%) 511,268k (± 0.00%) -75k (- 0.01%) 511,245k 511,287k p=0.020 n=6
Parse Time 2.66s (± 0.55%) 2.65s (± 0.52%) ~ 2.63s 2.66s p=0.192 n=6
Bind Time 0.99s (± 1.11%) 0.99s (± 0.41%) ~ 0.99s 1.00s p=1.000 n=6
Check Time 17.24s (± 0.28%) 17.28s (± 0.35%) ~ 17.23s 17.40s p=0.332 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.89s (± 0.21%) 20.92s (± 0.32%) ~ 20.88s 21.05s p=0.568 n=6
mui-docs - node (v18.15.0, x64)
Memory used 2,293,501k (± 0.00%) 2,293,438k (± 0.00%) -63k (- 0.00%) 2,293,310k 2,293,484k p=0.013 n=6
Parse Time 11.94s (± 0.82%) 12.02s (± 0.97%) ~ 11.86s 12.20s p=0.148 n=6
Bind Time 2.63s (± 0.44%) 2.63s (± 0.42%) ~ 2.61s 2.64s p=1.000 n=6
Check Time 103.08s (± 0.80%) 101.97s (± 0.94%) ~ 101.03s 103.74s p=0.066 n=6
Emit Time 0.32s (± 1.27%) 0.32s (± 1.28%) ~ 0.31s 0.32s p=0.218 n=6
Total Time 117.98s (± 0.76%) 116.95s (± 0.76%) -1.03s (- 0.87%) 116.18s 118.56s p=0.045 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,406,507k (± 0.03%) 2,405,300k (± 0.02%) -1,207k (- 0.05%) 2,404,690k 2,406,033k p=0.020 n=6
Parse Time 5.06s (± 1.23%) 5.12s (± 0.87%) ~ 5.05s 5.18s p=0.173 n=6
Bind Time 1.89s (± 0.56%) 1.88s (± 1.23%) ~ 1.85s 1.92s p=0.622 n=6
Check Time 33.64s (± 0.25%) 33.67s (± 0.40%) ~ 33.57s 33.93s p=0.936 n=6
Emit Time 2.68s (± 1.76%) 2.71s (± 0.98%) ~ 2.67s 2.74s p=0.471 n=6
Total Time 43.29s (± 0.29%) 43.40s (± 0.28%) ~ 43.29s 43.63s p=0.230 n=6
self-compiler - node (v18.15.0, x64)
Memory used 419,233k (± 0.01%) 418,486k (± 0.01%) -748k (- 0.18%) 418,448k 418,538k p=0.005 n=6
Parse Time 2.82s (± 0.97%) 2.82s (± 1.19%) ~ 2.79s 2.88s p=0.808 n=6
Bind Time 1.07s (± 0.78%) 1.08s (± 0.48%) ~ 1.07s 1.08s p=0.923 n=6
Check Time 15.26s (± 0.45%) 15.23s (± 0.27%) ~ 15.18s 15.28s p=0.630 n=6
Emit Time 1.13s (± 0.92%) 1.14s (± 0.90%) ~ 1.13s 1.16s p=0.241 n=6
Total Time 20.29s (± 0.39%) 20.27s (± 0.17%) ~ 20.22s 20.31s p=1.000 n=6
vscode - node (v18.15.0, x64)
Memory used 2,848,538k (± 0.00%) 2,848,524k (± 0.00%) ~ 2,848,415k 2,848,609k p=0.936 n=6
Parse Time 10.77s (± 0.18%) 10.77s (± 0.24%) ~ 10.72s 10.79s p=0.803 n=6
Bind Time 3.43s (± 0.30%) 3.45s (± 0.76%) ~ 3.41s 3.49s p=0.143 n=6
Check Time 60.63s (± 0.19%) 60.74s (± 0.43%) ~ 60.35s 61.17s p=0.423 n=6
Emit Time 16.28s (± 0.53%) 16.27s (± 0.44%) ~ 16.20s 16.39s p=0.936 n=6
Total Time 91.11s (± 0.19%) 91.23s (± 0.33%) ~ 90.73s 91.60s p=0.471 n=6
webpack - node (v18.15.0, x64)
Memory used 396,923k (± 0.01%) 396,881k (± 0.02%) ~ 396,750k 396,976k p=0.575 n=6
Parse Time 3.16s (± 0.95%) 3.15s (± 0.48%) ~ 3.13s 3.17s p=0.682 n=6
Bind Time 1.39s (± 0.98%) 1.39s (± 0.87%) ~ 1.38s 1.41s p=1.000 n=6
Check Time 14.08s (± 0.38%) 14.09s (± 0.51%) ~ 13.96s 14.16s p=0.572 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 18.64s (± 0.28%) 18.64s (± 0.40%) ~ 18.53s 18.72s p=0.936 n=6
xstate - node (v18.15.0, x64)
Memory used 513,434k (± 0.01%) 513,323k (± 0.01%) -111k (- 0.02%) 513,231k 513,383k p=0.005 n=6
Parse Time 3.28s (± 0.17%) 3.28s (± 0.37%) ~ 3.26s 3.29s p=0.865 n=6
Bind Time 1.54s (± 0.67%) 1.54s (± 0.00%) ~ 1.54s 1.54s p=0.599 n=6
Check Time 2.86s (± 0.48%) 2.86s (± 0.22%) ~ 2.85s 2.87s p=0.614 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 7.77s (± 0.29%) 7.76s (± 0.25%) ~ 7.74s 7.79s p=0.627 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,341ms (± 0.94%) 2,343ms (± 0.47%) ~ 2,334ms 2,360ms p=0.809 n=6
Req 2 - geterr 5,524ms (± 1.42%) 5,517ms (± 1.44%) ~ 5,429ms 5,643ms p=0.936 n=6
Req 3 - references 323ms (± 0.39%) 327ms (± 1.66%) ~ 322ms 336ms p=0.060 n=6
Req 4 - navto 276ms (± 1.19%) 275ms (± 0.93%) ~ 272ms 278ms p=0.510 n=6
Req 5 - completionInfo count 1,357 (± 0.00%) 1,357 (± 0.00%) ~ 1,357 1,357 p=1.000 n=6
Req 5 - completionInfo 85ms (± 8.40%) 84ms (± 9.11%) ~ 78ms 94ms p=0.607 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,479ms (± 0.98%) 2,490ms (± 0.68%) ~ 2,469ms 2,508ms p=0.377 n=6
Req 2 - geterr 4,225ms (± 1.75%) 4,142ms (± 1.36%) -83ms (- 1.96%) 4,105ms 4,254ms p=0.045 n=6
Req 3 - references 335ms (± 1.29%) 337ms (± 1.17%) ~ 333ms 342ms p=0.518 n=6
Req 4 - navto 284ms (± 0.41%) 284ms (± 0.75%) ~ 281ms 286ms p=0.807 n=6
Req 5 - completionInfo count 1,519 (± 0.00%) 1,519 (± 0.00%) ~ 1,519 1,519 p=1.000 n=6
Req 5 - completionInfo 83ms (± 7.06%) 86ms (± 7.08%) ~ 78ms 90ms p=0.220 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,608ms (± 0.33%) 2,608ms (± 0.51%) ~ 2,592ms 2,627ms p=0.872 n=6
Req 2 - geterr 1,745ms (± 1.96%) 1,741ms (± 2.20%) ~ 1,671ms 1,776ms p=1.000 n=6
Req 3 - references 111ms (± 7.67%) 115ms (± 9.15%) ~ 107ms 129ms p=0.176 n=6
Req 4 - navto 371ms (± 0.20%) 370ms (± 0.93%) ~ 363ms 372ms p=0.933 n=6
Req 5 - completionInfo count 2,079 (± 0.00%) 2,079 (± 0.00%) ~ 2,079 2,079 p=1.000 n=6
Req 5 - completionInfo 312ms (± 1.14%) 310ms (± 2.00%) ~ 300ms 316ms p=0.936 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 153.82ms (± 0.21%) 153.54ms (± 0.20%) -0.28ms (- 0.18%) 152.41ms 156.26ms p=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 230.32ms (± 0.15%) 229.90ms (± 0.15%) -0.42ms (- 0.18%) 228.60ms 233.06ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 231.30ms (± 0.16%) 230.99ms (± 0.18%) -0.31ms (- 0.13%) 229.32ms 235.11ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 231.13ms (± 0.17%) 231.03ms (± 0.19%) -0.10ms (- 0.04%) 229.47ms 236.67ms p=0.000 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/57527/merge:

Everything looks good!

@jakebailey jakebailey force-pushed the remove-others branch 2 times, most recently from 8fb984c to bd8d942 Compare February 26, 2024 19:36
@jakebailey
Copy link
Member Author

@andrewbranch The last two commits remove importsNotUsedAsValues and preserveValueImports, but breaks some auto import tests. Some of them are easy to fix, but others I can't seem to fix. Do you have any suggestions? (The CI will eventually error...)

@jakebailey
Copy link
Member Author

jakebailey commented Feb 26, 2024

Theoretically I think this PR is ready, and I'd appreciate review where needed, but I probably won't undraft until #57525 is merged. that or, I can merge the two together and we remove everything in one go.

(Thank you @andrewbranch!)

@jakebailey jakebailey marked this pull request as ready for review February 27, 2024 19:41
src/compiler/utilities.ts Outdated Show resolved Hide resolved
src/compiler/utilities.ts Outdated Show resolved Hide resolved
@jakebailey jakebailey merged commit 26df0cb into microsoft:main Feb 28, 2024
19 checks passed
@jakebailey jakebailey deleted the remove-others branch February 28, 2024 22:35
@jakebailey jakebailey added the Breaking Change Would introduce errors in existing code label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team Breaking Change Would introduce errors in existing code For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants