Some refactoring so we arent checking undefined on program or asserting it so much #58782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
reviewed
Jun 5, 2024
| /** @internal */ | ||
| export function isBuilderProgram(program: Program | BuilderProgram): program is BuilderProgram { | ||
| return !!(program as BuilderProgram).getState; | ||
| export function isBuilderProgram<T extends BuilderProgram>(program: Program | BuilderProgram): program is T { |
Member
There was a problem hiding this comment.
This seems unsafe; this could conform to anything, right?
Member
There was a problem hiding this comment.
I guess it's copied from somewhere else...
jakebailey
approved these changes
Jun 5, 2024
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Reminds me that we should see if we can make Debug.checkDefined or Debug.assert reject always-defined or never-falsy values (statically or at lint time), in case there are more of these that could be removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.